70/96a6660f656334f16cce26f3f6da6a9bbb4eba

   1 Return-Path: <amdragon@gmail.com>\r
   2 X-Original-To: notmuch@notmuchmail.org\r
   3 Delivered-To: notmuch@notmuchmail.org\r
   4 Received: from localhost (localhost [127.0.0.1])\r
   5         by olra.theworths.org (Postfix) with ESMTP id AC991429E20\r
   6         for <notmuch@notmuchmail.org>; Sun,  8 May 2011 15:02:01 -0700 (PDT)\r
   7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
   8 X-Spam-Flag: NO\r
   9 X-Spam-Score: -0.699\r
  10 X-Spam-Level: \r
  11 X-Spam-Status: No, score=-0.699 tagged_above=-999 required=5\r
  12         tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, FREEMAIL_FROM=0.001,\r
  13         RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
  14 Received: from olra.theworths.org ([127.0.0.1])\r
  15         by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
  16         with ESMTP id XS8K9qf6PM03 for <notmuch@notmuchmail.org>;\r
  17         Sun,  8 May 2011 15:02:01 -0700 (PDT)\r
  18 Received: from mail-qy0-f181.google.com (mail-qy0-f181.google.com\r
  19         [209.85.216.181]) (using TLSv1 with cipher RC4-SHA (128/128 bits))\r
  20         (No client certificate requested)\r
  21         by olra.theworths.org (Postfix) with ESMTPS id 2BB54431FB5\r
  22         for <notmuch@notmuchmail.org>; Sun,  8 May 2011 15:02:01 -0700 (PDT)\r
  23 Received: by qyg14 with SMTP id 14so3979062qyg.5\r
  24         for <notmuch@notmuchmail.org>; Sun, 08 May 2011 15:02:00 -0700 (PDT)\r
  25 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;\r
  26         h=domainkey-signature:mime-version:sender:in-reply-to:references:date\r
  27         :x-google-sender-auth:message-id:subject:from:to:cc:content-type;\r
  28         bh=jLFL+tYIrM3i0s77qqoz4IIV2wu5v1UVhLk2nA1JaUk=;\r
  29         b=syUPO+LtxKTIFTFQr7SptE+y6TpwD8STrRZQPt75yDMBZgsUGQOsH+XNWeXI7kXe+O\r
  30         VNcm8NsB3B6A0CJoXeJn6eZ46wHI9VrV5t6zio7+8SS/7eTbZtV6+H9lYNFOnHCgfhjr\r
  31         DHLmuIYlr9FaAe2C/C5sOVsgPW9PuKomanY7g=\r
  32 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma;\r
  33         h=mime-version:sender:in-reply-to:references:date\r
  34         :x-google-sender-auth:message-id:subject:from:to:cc:content-type;\r
  35         b=SXKetYBmFcbGWrYMUfAxYOh/IGv1Yp6VBcnNNR361ahsBsW44dO5tUavUBZvsnWNwt\r
  36         byj19cLooYd7QZ6GnTZY0KyLgm3zoruQBnYxt0hxO2u9e9hcoMD+svEkoxW1FeMkG01g\r
  37         weYBGzsW96Sa0qbvmyXUoVnDLdLjT9j4Z98Hs=\r
  38 MIME-Version: 1.0\r
  39 Received: by 10.229.251.13 with SMTP id mq13mr4515856qcb.36.1304892120245;\r
  40         Sun, 08 May 2011 15:02:00 -0700 (PDT)\r
  41 Sender: amdragon@gmail.com\r
  42 Received: by 10.229.233.17 with HTTP; Sun, 8 May 2011 15:02:00 -0700 (PDT)\r
  43 In-Reply-To: <877ha06epi.fsf@eve.chaoflow.net>\r
  44 References: <87liyjgvyw.fsf@servo.factory.finestructure.net>\r
  45         <1304889273-24560-1-git-send-email-flo@chaoflow.net>\r
  46         <1304889273-24560-2-git-send-email-flo@chaoflow.net>\r
  47         <BANLkTi=ta-abS09Wa7=2_k7Q307u_Y4A0Q@mail.gmail.com>\r
  48         <877ha06epi.fsf@eve.chaoflow.net>\r
  49 Date: Sun, 8 May 2011 18:02:00 -0400\r
  50 X-Google-Sender-Auth: ZaOdP_KmC7MjcWp_Dqrh9LXjdJk\r
  51 Message-ID: <BANLkTi=zkF5UtGPc69O06ZEaaCes-52y4w@mail.gmail.com>\r
  52 Subject: Re: [PATCH] Sanitize "Subject:" and "Author:" fields to not contain\r
  53         control characters in notmuch-search\r
  54 From: Austin Clements <amdragon@mit.edu>\r
  55 To: Florian Friesdorf <flo@chaoflow.net>\r
  56 Content-Type: text/plain; charset=ISO-8859-1\r
  57 Cc: notmuch@notmuchmail.org, Andreas Amann <a.amann@ucc.ie>\r
  58 X-BeenThere: notmuch@notmuchmail.org\r
  59 X-Mailman-Version: 2.1.13\r
  60 Precedence: list\r
  61 List-Id: "Use and development of the notmuch mail system."\r
  62         <notmuch.notmuchmail.org>\r
  63 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
  64         <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
  65 List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
  66 List-Post: <mailto:notmuch@notmuchmail.org>\r
  67 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
  68 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
  69         <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
  70 X-List-Received-Date: Sun, 08 May 2011 22:02:01 -0000\r
  71 \r
  72 On Sun, May 8, 2011 at 5:54 PM, Florian Friesdorf <flo@chaoflow.net> wrote:\r
  73 > On Sun, 8 May 2011 17:40:54 -0400, Austin Clements <amdragon@mit.edu> wrote:\r
  74 >> Also, existing code conventionally uses a variable named "local"\r
  75 >> for function-level talloc contexts such as your ctx_quote.\r
  76 >\r
  77 > In notmuch-search.c there is no variable named "local", in the other\r
  78 > functions its also named ctx_quote. Should I rename all ctx_quote to\r
  79 > "local"?\r
  80 \r
  81 Huh, sure enough.  Looks like the library uses "local" consistently,\r
  82 but the CLI uses ctx_quote multiple times and "local" appears only\r
  83 once, so, yeah, stick with ctx_quote.\r