1 Return-Path: <imain@redhat.com>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id A85F9431FBC
\r
6 for <notmuch@notmuchmail.org>; Fri, 3 Oct 2014 11:41:30 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=0 tagged_above=-999 required=5
\r
12 tests=[RCVD_IN_DNSWL_NONE=-0.0001] autolearn=disabled
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id guVlFOMdp+5l for <notmuch@notmuchmail.org>;
\r
16 Fri, 3 Oct 2014 11:41:23 -0700 (PDT)
\r
17 Received: from cmta18.telus.net (cmta18.telus.net [209.171.16.91])
\r
18 by olra.theworths.org (Postfix) with ESMTP id 67ACC431FB6
\r
19 for <notmuch@notmuchmail.org>; Fri, 3 Oct 2014 11:41:23 -0700 (PDT)
\r
20 Received: from ovo.mains.priv ([207.102.88.62]) by cmta18.telus.net with TELUS
\r
21 id yihM1o00c1LiWEf01ihMB4; Fri, 03 Oct 2014 12:41:22 -0600
\r
22 X-Authority-Analysis: v=2.0 cv=GdvJa3rL c=1 sm=2
\r
23 a=EcQDfIwDZEqJA1f7rVUV8Q==:17 a=S-IsBHyFrF4A:10 a=IkcTkHD0fZMA:10
\r
24 a=tsa3CZZnAAAA:8 a=9IXG43mSqOdJ_MyTbwwA:9 a=QEXdDO2ut3YA:10
\r
25 a=P87eogJZi2UA:10 a=EcQDfIwDZEqJA1f7rVUV8Q==:117
\r
26 X-Telus-Outbound-IP: 207.102.88.62
\r
27 Received: from ovo.mains.priv (localhost.localdomain [127.0.0.1])
\r
28 by ovo.mains.priv (8.14.8/8.14.8) with ESMTP id s93IfD6T020357;
\r
29 Fri, 3 Oct 2014 11:41:14 -0700
\r
30 Received: (from imain@localhost)
\r
31 by ovo.mains.priv (8.14.8/8.14.8/Submit) id s93IfCT9020356;
\r
32 Fri, 3 Oct 2014 11:41:12 -0700
\r
33 X-Authentication-Warning: ovo.mains.priv: imain set sender to imain@redhat.com
\r
35 Date: Fri, 03 Oct 2014 11:41:12 -0700
\r
36 From: Ian Main <imain@stemwinder.org>
\r
37 To: David Bremner <david@tethera.net>, David Bremner <david@tethera.net>,
\r
38 notmuch@notmuchmail.org
\r
39 Message-ID: <542eedc8cb635_ed1ddfe8cd0@ovo.mains.priv.notmuch>
\r
40 In-Reply-To: <87r3ypr6cm.fsf@maritornes.cs.unb.ca>
\r
41 References: <1412286796-27479-1-git-send-email-imain@stemwinder.org>
\r
42 <1412293635-31273-1-git-send-email-imain@stemwinder.org>
\r
43 <87r3ypr6cm.fsf@maritornes.cs.unb.ca>
\r
44 Subject: Re: [PATCH v2] VIM: Use notmuch CLI for config
\r
46 Content-Type: text/plain;
\r
48 Content-Transfer-Encoding: 7bit
\r
49 X-BeenThere: notmuch@notmuchmail.org
\r
50 X-Mailman-Version: 2.1.13
\r
52 List-Id: "Use and development of the notmuch mail system."
\r
53 <notmuch.notmuchmail.org>
\r
54 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
55 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
56 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
57 List-Post: <mailto:notmuch@notmuchmail.org>
\r
58 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
59 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
60 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
61 X-List-Received-Date: Fri, 03 Oct 2014 18:41:30 -0000
\r
63 David Bremner wrote:
\r
64 > Ian Main <imain@stemwinder.org> writes:
\r
66 > > This patch switches from reading .notmuch-config directly to using
\r
67 > > the CLI the same way that emacs does it. It actually uses less code
\r
68 > > and is probably less error prone.
\r
72 > The general approach seems sane; it seems quite brittle to read the
\r
73 > config file directly. I notice there is not really any error handling;
\r
74 > OTOH, as far as I can read Ruby, there is not any in the previous
\r
75 > version either. Technically, this does add a dependency of the vim
\r
76 > client on the CLI that did not exist before. Personally I don't find
\r
77 > this onerous (even notmuch-vim users need "notmuch new", except in
\r
78 > rather unusual circumstances.).
\r
80 > I'd like feedback/testing from actual vim interface users before
\r
83 I am actually just following suit on what was already being done.
\r
84 The Vim client was already calling out to notmuch CLI for other things,
\r
87 system "notmuch show --format=mbox id:#{m.message_id} > #{mbox} && #{cmd}"
\r
89 Is used to save the email for display in another program. Also with no
\r
90 error checking. I think basically we are relying on rubys exception handling
\r
91 to display errors to the user.. not the best idea but it is functional.
\r
93 I could add a check for 'notmuch' binary.. especially there because loading
\r
94 the config is the first thing that is done on startup.
\r