1 Return-Path: <tomi.ollila@iki.fi>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by arlo.cworth.org (Postfix) with ESMTP id 0F9106DE02A9
\r
6 for <notmuch@notmuchmail.org>; Sun, 8 May 2016 01:25:37 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at cworth.org
\r
11 X-Spam-Status: No, score=0.595 tagged_above=-999 required=5 tests=[AWL=-0.057,
\r
12 SPF_NEUTRAL=0.652] autolearn=disabled
\r
13 Received: from arlo.cworth.org ([127.0.0.1])
\r
14 by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id vgyYkMpJ5Prb for <notmuch@notmuchmail.org>;
\r
16 Sun, 8 May 2016 01:25:28 -0700 (PDT)
\r
17 Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])
\r
18 by arlo.cworth.org (Postfix) with ESMTP id 9BD116DE0217
\r
19 for <notmuch@notmuchmail.org>; Sun, 8 May 2016 01:25:28 -0700 (PDT)
\r
20 Received: from guru.guru-group.fi (localhost [IPv6:::1])
\r
21 by guru.guru-group.fi (Postfix) with ESMTP id 2506B1000B3;
\r
22 Sun, 8 May 2016 11:25:24 +0300 (EEST)
\r
23 From: Tomi Ollila <tomi.ollila@iki.fi>
\r
24 To: David Bremner <david@tethera.net>, notmuch@notmuchmail.org
\r
25 Subject: Re: v4 of libconfig / single argument date / named query patches
\r
26 In-Reply-To: <1462665889-17121-1-git-send-email-david@tethera.net>
\r
27 References: <1462665889-17121-1-git-send-email-david@tethera.net>
\r
28 User-Agent: Notmuch/0.22+9~gb26b5ad (http://notmuchmail.org) Emacs/24.3.1
\r
29 (x86_64-unknown-linux-gnu)
\r
30 X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
\r
31 $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
\r
32 !)g;OY^,BjTbr)Np:%c_o'jj,Z
\r
33 Date: Sun, 08 May 2016 11:25:23 +0300
\r
34 Message-ID: <m2oa8h2byk.fsf@guru.guru-group.fi>
\r
36 Content-Type: text/plain
\r
37 X-BeenThere: notmuch@notmuchmail.org
\r
38 X-Mailman-Version: 2.1.20
\r
40 List-Id: "Use and development of the notmuch mail system."
\r
41 <notmuch.notmuchmail.org>
\r
42 List-Unsubscribe: <https://notmuchmail.org/mailman/options/notmuch>,
\r
43 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
44 List-Archive: <http://notmuchmail.org/pipermail/notmuch/>
\r
45 List-Post: <mailto:notmuch@notmuchmail.org>
\r
46 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
47 List-Subscribe: <https://notmuchmail.org/mailman/listinfo/notmuch>,
\r
48 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
49 X-List-Received-Date: Sun, 08 May 2016 08:25:37 -0000
\r
51 On Sun, May 08 2016, David Bremner <david@tethera.net> wrote:
\r
55 > id:1462065879-29860-1-git-send-email-david@tethera.net
\r
57 looks pretty good & tests pass. one problem though, rest are nits:
\r
60 ;; This buffer is for notes you don't want to save, and for Lisp evaluation.
\r
61 ;; If you want to create a file, visit that file with C-x C-f,
\r
62 ;; then enter the text in that file's own buffer.
\r
65 *** in id:1462665889-17121-2-git-send-email-david@tethera.net
\r
67 + -DHAVE_XAPIAN_FIELD_PROCESSOR=\$(HAVE_XAPIAN_PROCESSOR) \\
\r
69 build gives compile /warning/ there, unfortunately this is not fatal and
\r
70 therefore can go unnoticed. -Wundef would do the same, complain about
\r
71 undefined macro but would not be fatal.
\r
73 then, some more nits:
\r
76 *** id:1462665889-17121-4-git-send-email-david@tethera.net
\r
78 +_notmuch_config_list_options () {
\r
81 *** id:1462665889-17121-8-git-send-email-david@tethera.net
\r
83 +typedef enum dump_includes {
\r
84 + DUMP_INCLUDE_TAGS=1,
\r
85 + DUMP_INCLUDE_CONFIG=2,
\r
88 print_dump_header () has some empty lines before closing '}'
\r
91 *** id:1462665889-17121-9-git-send-email-david@tethera.net
\r
93 +process_config_line(notmuch_database_t *notmuch, const char* line){
\r
95 + val_p = strtok_len_c(key_p+key_len, delim, &val_len);
\r
102 *** id:1462665889-17121-12-git-send-email-david@tethera.net
\r
104 +/* query-fp.cc - "query:" field processor glue glue
\r
107 id:1462665889-17121-13-git-send-email-david@tethera.net
\r
109 +_notmuch_config_list_built_with () {
\r