1 Return-Path: <aidecoe@aidecoe.name>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id B5643431FD0
\r
6 for <notmuch@notmuchmail.org>; Fri, 25 Nov 2011 07:12:30 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5
\r
12 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id b4kYE-tvcvNR for <notmuch@notmuchmail.org>;
\r
16 Fri, 25 Nov 2011 07:12:30 -0800 (PST)
\r
17 Received: from mail-bw0-f53.google.com (mail-bw0-f53.google.com
\r
18 [209.85.214.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits))
\r
19 (No client certificate requested)
\r
20 by olra.theworths.org (Postfix) with ESMTPS id EE146431FB6
\r
21 for <notmuch@notmuchmail.org>; Fri, 25 Nov 2011 07:12:29 -0800 (PST)
\r
22 Received: by bkaq10 with SMTP id q10so4872190bka.26
\r
23 for <notmuch@notmuchmail.org>; Fri, 25 Nov 2011 07:12:28 -0800 (PST)
\r
24 Received: by 10.204.8.77 with SMTP id g13mr32869970bkg.89.1322233948092;
\r
25 Fri, 25 Nov 2011 07:12:28 -0800 (PST)
\r
26 Received: from localhost (abtw56.neoplus.adsl.tpnet.pl. [83.8.168.56])
\r
27 by mx.google.com with ESMTPS id e20sm28864703fab.2.2011.11.25.07.12.25
\r
28 (version=TLSv1/SSLv3 cipher=OTHER);
\r
29 Fri, 25 Nov 2011 07:12:26 -0800 (PST)
\r
30 From: =?utf-8?q?Amadeusz_=C5=BBo=C5=82nowski?= <aidecoe@aidecoe.name>
\r
31 To: David Bremner <david@tethera.net>
\r
32 Subject: Re: [PATCH 1/2] Build symbol-test with make instead of hardcoding in
\r
34 In-reply-to: <878vn4bbf7.fsf@convex-new.cs.unb.ca>
\r
35 References: <1322218492-8300-1-git-send-email-aidecoe@aidecoe.name>
\r
36 <878vn4bbf7.fsf@convex-new.cs.unb.ca>
\r
37 Date: Fri, 25 Nov 2011 16:12:24 +0100
\r
38 Message-Id: <1322233411-sup-6651@ittemni>
\r
40 Content-Transfer-Encoding: 8bit
\r
42 Content-Type: multipart/signed; protocol="application/pgp-signature";
\r
43 boundary="=-1322233944-445180-28641-4206-1-="
\r
44 Cc: notmuch <notmuch@notmuchmail.org>
\r
45 X-BeenThere: notmuch@notmuchmail.org
\r
46 X-Mailman-Version: 2.1.13
\r
48 List-Id: "Use and development of the notmuch mail system."
\r
49 <notmuch.notmuchmail.org>
\r
50 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
51 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
52 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
53 List-Post: <mailto:notmuch@notmuchmail.org>
\r
54 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
55 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
56 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
57 X-List-Received-Date: Fri, 25 Nov 2011 15:12:30 -0000
\r
60 --=-1322233944-445180-28641-4206-1-=
\r
61 Content-Type: text/plain; charset=UTF-8
\r
62 Content-Transfer-Encoding: quoted-printable
\r
64 Excerpts from David Bremner's message of 2011-11-25 14:04:44 +0100:
\r
65 > On Fri, 25 Nov 2011 11:54:51 +0100, Amadeusz =C5=BBo=C5=82nowski <aidec=
\r
66 oe@aidecoe.name> wrote:
\r
69 > > +$(dir)/symbol-test: $(dir)/symbol-test.o
\r
70 > > + $(call quiet,CC) $^ -o $@ -Llib -lnotmuch -lxapian
\r
73 > I'm a bit surprised no -I is neaded here. Is that taken care in the CC
\r
76 -I is for headers which are not used when linking. symbol-test.o is
\r
77 compiled according to rule defined earlier in some parent Makefile.
\r
80 > > .PHONY: test check
\r
81 > > -test: all $(dir)/smtp-dummy
\r
82 > > +test: all $(dir)/smtp-dummy $(dir)/symbol-test
\r
83 > > @${dir}/notmuch-test $(OPTIONS)
\r
86 > The instructions were already wrong, but maybe they should be updated t=
\r
88 > point out that calling the test scripts directly requires smtp-dummy an=
\r
90 > symbol-test already be built. Or maybe the tests should check for these=
\r
92 > binaries as pre-reqs along with emacs, gpg, etc... =
\r
96 > > + -e "/^(emacs.expected-output|smtp-dummy|smtp-dummy.c|test-ver=
\r
97 bose|symbol-test.cc|symbol-test|symbol-test.o)/d" \
\r
100 > I wonder if this should be shortened (and made a bit sloppier) with the=
\r
104 Thanks it's so straightforward. I found this line quickly without deep
\r
105 analysis of all test-framework. :-) It could only be made more flexible
\r
106 - put list of this files into some separate text file. But that's
\r
107 subject for another patch. Purpose of this one is to make building out
\r
112 Amadeusz =C5=BBo=C5=82nowski
\r
114 --=-1322233944-445180-28641-4206-1-=
\r
115 Content-Disposition: attachment; filename="signature.asc"
\r
116 Content-Type: application/pgp-signature; name="signature.asc"
\r
118 -----BEGIN PGP SIGNATURE-----
\r
119 Version: GnuPG v2.0.18 (GNU/Linux)
\r
121 iQEcBAEBAgAGBQJOz7BYAAoJEPATRTHh2/q1sJUIAIBRHA27PddyBEm/+xYFQp+m
\r
122 3m6AkOBNtxjZ11DOxFD5Yva98De3/mmwnvn0xCj9DcRT+lXZamxE1BU22TouxMRx
\r
123 J7FFuUVX1DP9EJPnGfc3P0ZKlcEGWKKLSSL0lt38IoWEK4mmUY/XjTSuhh8B5v/4
\r
124 +0T7pWeU/TBS0U7pEr/z2AtzODq9PMP771BzHGzrevIeDul3RJ390g55h5Vlo5oa
\r
125 jYELaqPSx5C2tuLzBWJ0LVhDGVRtp/YpQw973ltKJz4vyPgU87h4AjNYvj8CYj/B
\r
126 qsX15qljqbNnGK8WeRKH2poKLCVFrG9OpXvhYX4UWBuXuRxiVqBil+eFxfLVR0E=
\r
128 -----END PGP SIGNATURE-----
\r
130 --=-1322233944-445180-28641-4206-1-=--
\r