Re: Flat search and threaded views
[notmuch-archives.git] / 6c / c36bca6b4d3452a307f543edc2f15a634b8c1f
1 Return-Path: <wking@tremily.us>\r
2 X-Original-To: notmuch@notmuchmail.org\r
3 Delivered-To: notmuch@notmuchmail.org\r
4 Received: from localhost (localhost [127.0.0.1])\r
5         by olra.theworths.org (Postfix) with ESMTP id 35D96431FD2\r
6         for <notmuch@notmuchmail.org>; Sat,  5 Apr 2014 10:31:38 -0700 (PDT)\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
8 X-Amavis-Alert: BAD HEADER SECTION, Duplicate header field: "References"\r
9 X-Spam-Flag: NO\r
10 X-Spam-Score: 0\r
11 X-Spam-Level: \r
12 X-Spam-Status: No, score=0 tagged_above=-999 required=5\r
13         tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001]\r
14         autolearn=disabled\r
15 Received: from olra.theworths.org ([127.0.0.1])\r
16         by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
17         with ESMTP id l2AZvDVQt2YO for <notmuch@notmuchmail.org>;\r
18         Sat,  5 Apr 2014 10:31:32 -0700 (PDT)\r
19 Received: from qmta09.westchester.pa.mail.comcast.net\r
20         (qmta09.westchester.pa.mail.comcast.net [76.96.62.96])\r
21         by olra.theworths.org (Postfix) with ESMTP id 66B17431FB6\r
22         for <notmuch@notmuchmail.org>; Sat,  5 Apr 2014 10:31:26 -0700 (PDT)\r
23 Received: from omta13.westchester.pa.mail.comcast.net ([76.96.62.52])\r
24         by qmta09.westchester.pa.mail.comcast.net with comcast\r
25         id mFjN1n00517dt5G59HXR9K; Sat, 05 Apr 2014 17:31:25 +0000\r
26 Received: from odin.tremily.us ([24.18.63.50])\r
27         by omta13.westchester.pa.mail.comcast.net with comcast\r
28         id mHXQ1n00o152l3L3ZHXRQb; Sat, 05 Apr 2014 17:31:25 +0000\r
29 Received: from mjolnir.tremily.us (unknown [192.168.0.140])\r
30         by odin.tremily.us (Postfix) with ESMTPS id AFEE91103C14;\r
31         Sat,  5 Apr 2014 10:31:24 -0700 (PDT)\r
32 Received: (nullmailer pid 16915 invoked by uid 1000);\r
33         Sat, 05 Apr 2014 17:31:15 -0000\r
34 From: "W. Trevor King" <wking@tremily.us>\r
35 To: notmuch@notmuchmail.org\r
36 Subject: [PATCH 2/7] doc/mkdocdeps.py: Use "with" statement for the output\r
37  file\r
38 Date: Sat,  5 Apr 2014 10:31:06 -0700\r
39 Message-Id:\r
40  <543aee63407956e60f85dc11a2d25855e98c10c3.1396718720.git.wking@tremily.us>\r
41 X-Mailer: git-send-email 1.9.1.353.gc66d89d\r
42 In-Reply-To: <cover.1396718720.git.wking@tremily.us>\r
43 References: <cover.1396718720.git.wking@tremily.us>\r
44 In-Reply-To: <cover.1396718720.git.wking@tremily.us>\r
45 References: <cover.1396718720.git.wking@tremily.us>\r
46 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=comcast.net;\r
47         s=q20140121; t=1396719085;\r
48         bh=EUaDylg69IHiWfHMYQnINVTyWhPaW7ppXPGfzYThfBo=;\r
49         h=Received:Received:Received:Received:From:To:Subject:Date:\r
50         Message-Id;\r
51         b=bQ/ph/jzoJ9yErrGs2y7J9RWFjWbJsPf7/gQxVFjRXYBds2oVj3GlRbNYYNldQa7j\r
52         JfnTp1FB6MHtHQHzKRWg28KsNk2hORs3/m/7qQf2Y4b18UXWuzCFv990W/BBcJ5e2p\r
53         E1g2ZzvXvABUBPa9shUpIJQ9VkG/tSpzaGV67GzbqOiks2kZ9CyROyNY77Oksikpb/\r
54         oLMqw1PKPP5FJioYpOYvyHBA9umOpIAjcIkt0tcdPi3nYUFcbU9JM8fIj94ktpTGFc\r
55         hvzvuU4QlmyRgObhSED91QAxlc5Aw31KbCckh6xrzUG9cb+08iJeYWhtaQhMof6zaj\r
56         VJBT8K2AhksxA==\r
57 X-BeenThere: notmuch@notmuchmail.org\r
58 X-Mailman-Version: 2.1.13\r
59 Precedence: list\r
60 List-Id: "Use and development of the notmuch mail system."\r
61         <notmuch.notmuchmail.org>\r
62 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
63         <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
64 List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
65 List-Post: <mailto:notmuch@notmuchmail.org>\r
66 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
67 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
68         <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
69 X-List-Received-Date: Sat, 05 Apr 2014 17:31:38 -0000\r
70 \r
71 Before this patch, the open was unnecessarily early and relied on the\r
72 process cleanup to close.  Neither one of these was a real problem,\r
73 but PEP 343's context managers (which landed in Python 2.5) make\r
74 proper cleanup very easy.\r
75 \r
76 [1]: http://legacy.python.org/dev/peps/pep-0343/\r
77 ---\r
78  doc/mkdocdeps.py | 6 +++---\r
79  1 file changed, 3 insertions(+), 3 deletions(-)\r
80 \r
81 diff --git a/doc/mkdocdeps.py b/doc/mkdocdeps.py\r
82 index de1cbb8..b87fe3e 100644\r
83 --- a/doc/mkdocdeps.py\r
84 +++ b/doc/mkdocdeps.py\r
85 @@ -9,10 +9,10 @@ import conf\r
86  \r
87  roff_files = []\r
88  rst_files = []\r
89 -out=open(outfile,'w')\r
90  for page in conf.man_pages:\r
91      rst_files = rst_files + ["{0:s}/{1:s}.rst".format(srcdir,page[0])]\r
92      roff_files = roff_files + ["{0:s}/man/{1:s}.{2:d}".format(builddir,page[0],page[4])]\r
93  \r
94 -out.write ('MAN_ROFF_FILES := ' + ' \\\n\t'.join(roff_files)+'\n')\r
95 -out.write ('MAN_RST_FILES := ' + ' \\\n\t'.join(rst_files)+'\n')\r
96 +with open(outfile, 'w') as out:\r
97 +    out.write('MAN_ROFF_FILES := ' + ' \\\n\t'.join(roff_files) + '\n')\r
98 +    out.write('MAN_RST_FILES := ' + ' \\\n\t'.join(rst_files) + '\n')\r
99 -- \r
100 1.9.1.353.gc66d89d\r
101 \r