1 Return-Path: <dme@dme.org>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 32E10431FB6
\r
6 for <notmuch@notmuchmail.org>; Mon, 16 Jan 2012 10:39:54 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5
\r
12 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id VGKFLdmw6YkP for <notmuch@notmuchmail.org>;
\r
16 Mon, 16 Jan 2012 10:39:53 -0800 (PST)
\r
17 Received: from mail-wi0-f181.google.com (mail-wi0-f181.google.com
\r
18 [209.85.212.181]) (using TLSv1 with cipher RC4-SHA (128/128 bits))
\r
19 (No client certificate requested)
\r
20 by olra.theworths.org (Postfix) with ESMTPS id 9ABE0431FAF
\r
21 for <notmuch@notmuchmail.org>; Mon, 16 Jan 2012 10:39:53 -0800 (PST)
\r
22 Received: by mail-wi0-f181.google.com with SMTP id hr12so2719751wib.26
\r
23 for <notmuch@notmuchmail.org>; Mon, 16 Jan 2012 10:39:53 -0800 (PST)
\r
24 Received: by 10.180.99.199 with SMTP id es7mr12718058wib.10.1326739193264;
\r
25 Mon, 16 Jan 2012 10:39:53 -0800 (PST)
\r
26 Received: from hotblack-desiato.hh.sledj.net
\r
27 (host81-149-164-25.in-addr.btopenworld.com. [81.149.164.25])
\r
28 by mx.google.com with ESMTPS id q34sm23300086wbm.15.2012.01.16.10.39.51
\r
29 (version=TLSv1/SSLv3 cipher=OTHER);
\r
30 Mon, 16 Jan 2012 10:39:52 -0800 (PST)
\r
31 Received: by hotblack-desiato.hh.sledj.net (Postfix, from userid 30000)
\r
32 id 4F04FA0397; Mon, 16 Jan 2012 18:39:50 +0000 (GMT)
\r
33 To: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>
\r
34 Subject: Re: [PATCH 1/2] test: Add "test_expect_emacs_t" to assist with emacs
\r
36 In-Reply-To: <87hazv8rkx.fsf@gmail.com>
\r
37 References: <1326732453-23377-1-git-send-email-dme@dme.org>
\r
38 <87hazv8rkx.fsf@gmail.com>
\r
39 User-Agent: Notmuch/0.11+64~g42e8f66 (http://notmuchmail.org) Emacs/24.0.92.1
\r
40 (x86_64-pc-linux-gnu)
\r
41 From: David Edmondson <dme@dme.org>
\r
42 Date: Mon, 16 Jan 2012 18:39:50 +0000
\r
43 Message-ID: <cunaa5nsd8p.fsf@hotblack-desiato.hh.sledj.net>
\r
45 Content-Type: multipart/signed; boundary="=-=-=";
\r
46 micalg=pgp-sha1; protocol="application/pgp-signature"
\r
47 Cc: notmuch@notmuchmail.org
\r
48 X-BeenThere: notmuch@notmuchmail.org
\r
49 X-Mailman-Version: 2.1.13
\r
51 List-Id: "Use and development of the notmuch mail system."
\r
52 <notmuch.notmuchmail.org>
\r
53 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
54 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
55 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
56 List-Post: <mailto:notmuch@notmuchmail.org>
\r
57 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
58 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
59 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
60 X-List-Received-Date: Mon, 16 Jan 2012 18:39:54 -0000
\r
63 Content-Type: text/plain
\r
64 Content-Transfer-Encoding: quoted-printable
\r
66 On Mon, 16 Jan 2012 21:50:22 +0400, Dmitry Kurochkin <dmitry.kurochkin@gmai=
\r
68 > Isn't this function the same as something like "test_expect_equal $x
\r
71 Yes, except that it differs in how it reports differences.
\r
73 > IMO the function seems too complex for what it does (and basically that
\r
74 > is "compare $x with t"). Why do we need to implement it in such a way?
\r
76 > Also, the function has nothing to do with emacs (except for the fact
\r
77 > that 't' is commonly used in it).
\r
79 > I think a more useful approach would be to add a function which takes a
\r
80 > lisp expression, runs test_emacs and compares the result with "t" using
\r
81 > test_expect_equal or similar. This way you do not need to make an
\r
82 > explicit test_emacs call and avoid code duplication when checking the
\r
83 > result. test_emacs_expect_t should be a good name for it. What do you
\r
89 Content-Type: application/pgp-signature
\r
91 -----BEGIN PGP SIGNATURE-----
\r
92 Version: GnuPG v1.4.11 (GNU/Linux)
\r
94 iEYEARECAAYFAk8UbvYACgkQaezQq/BJZRa+vACghAvUUNfAOgDo7POl6NeaKqyC
\r
95 2IoAn14fk9qzXTDoJ3sMBk0FdWfH3Kj6
\r
97 -----END PGP SIGNATURE-----
\r