6b/28185a2f13192c63747a4992cbf4df4a186baf

   1 Return-Path: <ethan.glasser.camp@gmail.com>\r
   2 X-Original-To: notmuch@notmuchmail.org\r
   3 Delivered-To: notmuch@notmuchmail.org\r
   4 Received: from localhost (localhost [127.0.0.1])\r
   5         by olra.theworths.org (Postfix) with ESMTP id 7A594431FBC\r
   6         for <notmuch@notmuchmail.org>; Sat, 27 Oct 2012 10:39:08 -0700 (PDT)\r
   7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
   8 X-Spam-Flag: NO\r
   9 X-Spam-Score: -0.799\r
  10 X-Spam-Level: \r
  11 X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5\r
  12         tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,\r
  13         FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
  14 Received: from olra.theworths.org ([127.0.0.1])\r
  15         by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
  16         with ESMTP id NnCwQm6MT1Hq for <notmuch@notmuchmail.org>;\r
  17         Sat, 27 Oct 2012 10:39:08 -0700 (PDT)\r
  18 Received: from mail-vc0-f181.google.com (mail-vc0-f181.google.com\r
  19         [209.85.220.181]) (using TLSv1 with cipher RC4-SHA (128/128 bits))\r
  20         (No client certificate requested)\r
  21         by olra.theworths.org (Postfix) with ESMTPS id 10735431FAF\r
  22         for <notmuch@notmuchmail.org>; Sat, 27 Oct 2012 10:39:08 -0700 (PDT)\r
  23 Received: by mail-vc0-f181.google.com with SMTP id n11so4236943vch.26\r
  24         for <notmuch@notmuchmail.org>; Sat, 27 Oct 2012 10:39:07 -0700 (PDT)\r
  25 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;\r
  26         h=from:to:subject:in-reply-to:references:user-agent:date:message-id\r
  27         :mime-version:content-type;\r
  28         bh=DZg7TkyvLZKeAc8oufVXtPwWk+cHtC5wwBcXIkbt6JE=;\r
  29         b=OBXrOCpvZ1tvMOClNuiY0dTaTlYzvBIDab2qpq3hAiBCMFkETWVuq9WRsY2dUeNFUA\r
  30         eizfB/FTPCb0U065mE10sM1L+OHAfL22Y4JNqlFVsxIBDJqkItkama21lK9kwCGTc8ra\r
  31         Z9nQXcyDVrxEGhmMMmEjw29u/KKXESYkr3jbSpI5OKuDFKPnj+8vFT8uis6nn9amQhe8\r
  32         4eeoxMyKPApud6hqMjQ6tU/59qc/xDWAnYqP3X65HFx/lZeUxRgFO51ayltBX68Kez2Y\r
  33         CBWpyRWgmxy5egv997YyZZyN42Ps4vp0lC/YRodYsqnLy/aVQvUDT8FKZ9RFlL3ao2bI\r
  34         4iFA==\r
  35 Received: by 10.52.23.199 with SMTP id o7mr33951020vdf.129.1351359547468;\r
  36         Sat, 27 Oct 2012 10:39:07 -0700 (PDT)\r
  37 Received: from smtp.gmail.com (cpe-74-70-7-64.nycap.res.rr.com. [74.70.7.64])\r
  38         by mx.google.com with ESMTPS id\r
  39         l15sm2773841vdt.14.2012.10.27.10.39.05\r
  40         (version=TLSv1/SSLv3 cipher=OTHER);\r
  41         Sat, 27 Oct 2012 10:39:05 -0700 (PDT)\r
  42 From: Ethan Glasser-Camp <ethan.glasser.camp@gmail.com>\r
  43 To: Mark Walters <markwalters1009@gmail.com>, notmuch@notmuchmail.org\r
  44 Subject: Re: [PATCH 1/3] contrib: add notmuch-pick.el file itself\r
  45 In-Reply-To: <1351337200-18050-2-git-send-email-markwalters1009@gmail.com>\r
  46 References: <1351337200-18050-1-git-send-email-markwalters1009@gmail.com>\r
  47         <1351337200-18050-2-git-send-email-markwalters1009@gmail.com>\r
  48 User-Agent: Notmuch/0.14+45~g6ea9330 (http://notmuchmail.org) Emacs/23.4.1\r
  49         (x86_64-pc-linux-gnu)\r
  50 Date: Sat, 27 Oct 2012 13:39:04 -0400\r
  51 Message-ID: <87txtfhl1j.fsf@betacantrips.com>\r
  52 MIME-Version: 1.0\r
  53 Content-Type: text/plain; charset=us-ascii\r
  54 X-BeenThere: notmuch@notmuchmail.org\r
  55 X-Mailman-Version: 2.1.13\r
  56 Precedence: list\r
  57 List-Id: "Use and development of the notmuch mail system."\r
  58         <notmuch.notmuchmail.org>\r
  59 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
  60         <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
  61 List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
  62 List-Post: <mailto:notmuch@notmuchmail.org>\r
  63 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
  64 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
  65         <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
  66 X-List-Received-Date: Sat, 27 Oct 2012 17:39:08 -0000\r
  67 \r
  68 Mark Walters <markwalters1009@gmail.com> writes:\r
  69 \r
  70 > +(defvar notmuch-pick-json-parser nil\r
  71 > +  "Incremental JSON parser for the search process filter.")\r
  72 > +\r
  73 > +(defun notmuch-pick-process-filter (proc string)\r
  74 > +  "Process and filter the output of \"notmuch show\" (for pick)"\r
  75 > +  (let ((results-buf (process-buffer proc))\r
  76 > +        (parse-buf (process-get proc 'parse-buf))\r
  77 > +        (inhibit-read-only t)\r
  78 > +        done)\r
  79 > +    (if (not (buffer-live-p results-buf))\r
  80 > +        (delete-process proc)\r
  81 > +      (with-current-buffer parse-buf\r
  82 > +        ;; Insert new data\r
  83 > +        (save-excursion\r
  84 > +          (goto-char (point-max))\r
  85 > +          (insert string)))\r
  86 > +      (with-current-buffer results-buf\r
  87 > +     (save-excursion\r
  88 > +       (goto-char (point-max))\r
  89 > +       (while (not done)\r
  90 > +         (condition-case nil\r
  91 > +             (case notmuch-pick-process-state\r
  92 \r
  93 This looks awfully familiar. Not looking too close, but why can't this\r
  94 re-use the JSON parser from your other patch? Just not to rely on the\r
  95 other patch series?\r
  96 \r
  97 Still, let's get this pushed.\r
  98 \r
  99 Ethan\r