1 Return-Path: <m.walters@qmul.ac.uk>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 87319431FCF
\r
6 for <notmuch@notmuchmail.org>; Sun, 15 Jul 2012 11:14:51 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-1.098 tagged_above=-999 required=5
\r
12 tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001,
\r
13 NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled
\r
14 Received: from olra.theworths.org ([127.0.0.1])
\r
15 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
16 with ESMTP id M7fR1RXSanXx for <notmuch@notmuchmail.org>;
\r
17 Sun, 15 Jul 2012 11:14:50 -0700 (PDT)
\r
18 Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6])
\r
19 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
\r
20 (No client certificate requested)
\r
21 by olra.theworths.org (Postfix) with ESMTPS id 9CA44431FBC
\r
22 for <notmuch@notmuchmail.org>; Sun, 15 Jul 2012 11:14:50 -0700 (PDT)
\r
23 Received: from smtp.qmul.ac.uk ([138.37.6.40])
\r
24 by mail2.qmul.ac.uk with esmtp (Exim 4.71)
\r
25 (envelope-from <m.walters@qmul.ac.uk>)
\r
26 id 1SqTLD-0002Wd-Ad; Sun, 15 Jul 2012 19:14:47 +0100
\r
27 Received: from 94-192-233-223.zone6.bethere.co.uk ([94.192.233.223]
\r
29 by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.69)
\r
30 (envelope-from <m.walters@qmul.ac.uk>)
\r
31 id 1SqTLC-000331-Ul; Sun, 15 Jul 2012 19:14:47 +0100
\r
32 From: Mark Walters <markwalters1009@gmail.com>
\r
33 To: Austin Clements <amdragon@MIT.EDU>, notmuch@notmuchmail.org
\r
34 Subject: Re: [PATCH v3 0/8] emacs: JSON-based search cleanups
\r
35 In-Reply-To: <87ipdorjja.fsf@awakening.csail.mit.edu>
\r
36 References: <1342140319-19859-1-git-send-email-amdragon@mit.edu>
\r
37 <1342306940-7499-1-git-send-email-amdragon@mit.edu>
\r
38 <87a9z1at22.fsf@qmul.ac.uk>
\r
39 <87ipdorjja.fsf@awakening.csail.mit.edu>
\r
40 User-Agent: Notmuch/0.13.2+90~g84fa1ef (http://notmuchmail.org) Emacs/23.4.1
\r
41 (x86_64-pc-linux-gnu)
\r
42 Date: Sun, 15 Jul 2012 19:14:44 +0100
\r
43 Message-ID: <87y5mkuc17.fsf@qmul.ac.uk>
\r
45 Content-Type: text/plain; charset=us-ascii
\r
46 X-Sender-Host-Address: 94.192.233.223
\r
47 X-QM-SPAM-Info: Sender has good ham record. :)
\r
48 X-QM-Body-MD5: 7f81cbcee7c29ced1a24c8172869462e (of first 20000 bytes)
\r
49 X-SpamAssassin-Score: -1.8
\r
50 X-SpamAssassin-SpamBar: -
\r
51 X-SpamAssassin-Report: The QM spam filters have analysed this message to
\r
53 spam. We require at least 5.0 points to mark a message as spam.
\r
54 This message scored -1.8 points.
\r
55 Summary of the scoring:
\r
56 * -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at http://www.dnswl.org/,
\r
58 * [138.37.6.40 listed in list.dnswl.org]
\r
59 * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail
\r
60 provider * (markwalters1009[at]gmail.com)
\r
61 * -0.0 T_RP_MATCHES_RCVD Envelope sender domain matches handover relay
\r
63 * 0.5 AWL AWL: From: address is in the auto white-list
\r
64 X-QM-Scan-Virus: ClamAV says the message is clean
\r
65 X-BeenThere: notmuch@notmuchmail.org
\r
66 X-Mailman-Version: 2.1.13
\r
68 List-Id: "Use and development of the notmuch mail system."
\r
69 <notmuch.notmuchmail.org>
\r
70 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
71 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
72 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
73 List-Post: <mailto:notmuch@notmuchmail.org>
\r
74 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
75 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
76 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
77 X-List-Received-Date: Sun, 15 Jul 2012 18:14:51 -0000
\r
79 On Sun, 15 Jul 2012, Austin Clements <amdragon@MIT.EDU> wrote:
\r
80 > On Sun, 15 Jul 2012, Mark Walters <markwalters1009@gmail.com> wrote:
\r
81 >> On Sun, 15 Jul 2012, Austin Clements <amdragon@MIT.EDU> wrote:
\r
82 >>> This version swaps out the notmuch-search-do-results macro for a
\r
83 >>> higher-order function, notmuch-search-foreach-result. This requires
\r
84 >>> less squiting to understand and clearly distinguishes the arguments
\r
85 >>> passed in to the function from the arguments passed to the callback.
\r
86 >>> This version also updates the docstring for
\r
87 >>> notmuch-search-result-format to mention that multi-line result formats
\r
88 >>> work and how to enter them, and it adds a NEWS patch.
\r
92 >> I am afraid I have found a minor (but reproducible) bug in the line
\r
93 >> re-drawing even with single line results. Find a search result with a
\r
94 >> partially elided author field and put the cursor after the ellipsis in
\r
95 >> that line. Then update the tags. The result gets redrawn with ellipsis
\r
96 >> written out in full. Re-redrawing with the cursor after the author field
\r
97 >> redraws the line with the keeping the ellipsis written out in full,
\r
98 >> whereas re-redrawing the line with cursor before the author field gets
\r
99 >> it written with the correct ellipsis.
\r
103 > I can think of two ways to fix this. We could generate the author
\r
104 > elision overlays lazily (say, via jit-lock). This would have the added
\r
105 > benefit of eliminating what I think is the last quadratic factor in
\r
106 > building search buffers, but there are much easier ways to do that. Or,
\r
107 > I could scrap the insert-before-markers nonsense and manipulate point
\r
108 > directly in notmuch-search-update-result, with the caveat that the
\r
109 > little bit of support it had for doing sane things in some situations
\r
110 > involving save-excursions would be lost. Given that we never call
\r
111 > notmuch-search-update-result inside a save-excursion (precisely because
\r
112 > I couldn't reliably hit the narrow window of situations it could handle
\r
113 > when there were save-excursions involved), I'd lean toward the latter
\r
116 I think I don't really know enough emacs/lisp to be able to say anything
\r
117 sensible. I think manipulating point directly seems good because then I
\r
118 think we can make sure things work in the multiline case too.
\r
120 I haven't yet worked out whether multiline is an amusing "oh look it works"
\r
121 or genuinely useful thing. I am leaning towards the latter as do often
\r
122 work on laptops with quite small screens and think I would like to see
\r
123 more about a smaller number of results.
\r