1 Return-Path: <m.walters@qmul.ac.uk>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id ECFA6431FB6
\r
6 for <notmuch@notmuchmail.org>; Sat, 4 Feb 2012 04:30:53 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-1.098 tagged_above=-999 required=5
\r
12 tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001,
\r
13 NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled
\r
14 Received: from olra.theworths.org ([127.0.0.1])
\r
15 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
16 with ESMTP id c9nL3sDf5dai for <notmuch@notmuchmail.org>;
\r
17 Sat, 4 Feb 2012 04:30:53 -0800 (PST)
\r
18 Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6])
\r
19 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
\r
20 (No client certificate requested)
\r
21 by olra.theworths.org (Postfix) with ESMTPS id E778E431FAF
\r
22 for <notmuch@notmuchmail.org>; Sat, 4 Feb 2012 04:30:52 -0800 (PST)
\r
23 Received: from smtp.qmul.ac.uk ([138.37.6.40])
\r
24 by mail2.qmul.ac.uk with esmtp (Exim 4.71)
\r
25 (envelope-from <m.walters@qmul.ac.uk>)
\r
26 id 1RtelU-00071n-MG; Sat, 04 Feb 2012 12:30:49 +0000
\r
27 Received: from 94-192-233-223.zone6.bethere.co.uk ([94.192.233.223]
\r
29 by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.69)
\r
30 (envelope-from <m.walters@qmul.ac.uk>)
\r
31 id 1RtelU-0001Un-9w; Sat, 04 Feb 2012 12:30:48 +0000
\r
32 From: Mark Walters <markwalters1009@gmail.com>
\r
33 To: David Edmondson <dme@dme.org>, notmuch@notmuchmail.org
\r
34 Subject: Re: Bug: emacs 23.2 doesn't like ido-completing-read
\r
35 In-Reply-To: <87pqe14hjh.fsf@qmul.ac.uk>
\r
36 References: <871uqijdy4.fsf@qmul.ac.uk>
\r
37 <cun4nvdil63.fsf@hotblack-desiato.hh.sledj.net>
\r
38 <87pqe14hjh.fsf@qmul.ac.uk>
\r
39 User-Agent: Notmuch/0.11+129~gdd41085 (http://notmuchmail.org) Emacs/23.2.1
\r
41 Date: Sat, 04 Feb 2012 12:31:57 +0000
\r
42 Message-ID: <8762fmeq4i.fsf@qmul.ac.uk>
\r
44 Content-Type: text/plain; charset=us-ascii
\r
45 X-Sender-Host-Address: 94.192.233.223
\r
46 X-QM-SPAM-Info: Sender has good ham record. :)
\r
47 X-QM-Body-MD5: dffef0b803f22573b705bf879e47040a (of first 20000 bytes)
\r
48 X-SpamAssassin-Score: -1.8
\r
49 X-SpamAssassin-SpamBar: -
\r
50 X-SpamAssassin-Report: The QM spam filters have analysed this message to
\r
52 spam. We require at least 5.0 points to mark a message as spam.
\r
53 This message scored -1.8 points.
\r
54 Summary of the scoring:
\r
55 * -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at http://www.dnswl.org/,
\r
57 * [138.37.6.40 listed in list.dnswl.org]
\r
58 * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail
\r
59 provider * (markwalters1009[at]gmail.com)
\r
60 * -0.0 T_RP_MATCHES_RCVD Envelope sender domain matches handover relay
\r
62 * 0.5 AWL AWL: From: address is in the auto white-list
\r
63 X-QM-Scan-Virus: ClamAV says the message is clean
\r
64 X-BeenThere: notmuch@notmuchmail.org
\r
65 X-Mailman-Version: 2.1.13
\r
67 List-Id: "Use and development of the notmuch mail system."
\r
68 <notmuch.notmuchmail.org>
\r
69 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
70 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
71 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
72 List-Post: <mailto:notmuch@notmuchmail.org>
\r
73 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
74 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
75 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
76 X-List-Received-Date: Sat, 04 Feb 2012 12:30:54 -0000
\r
78 On Mon, 30 Jan 2012 10:21:38 +0000, Mark Walters <markwalters1009@gmail.com> wrote:
\r
79 > On Mon, 30 Jan 2012 09:39:32 +0000, David Edmondson <dme@dme.org> wrote:
\r
80 > > On Sun, 29 Jan 2012 23:17:55 +0000, Mark Walters <markwalters1009@gmail.com> wrote:
\r
81 > > > I have been experimenting with notmuch-always-prompt-for-sender on my
\r
82 > > > debian stable setup (emacs 23.2.1) and it doesn't like
\r
83 > > > ido-completing-read. It goes to the minibuffer and then it seems to be
\r
84 > > > impossible to exit the minibuffer.
\r
86 > > > I can find an emacs bug report #3274 and some discussion
\r
87 > > > http://comments.gmane.org/gmane.emacs.bugs/27856 which indicates that it
\r
88 > > > is a problem with ido initialisation. Unfortunately I can't get from there to a
\r
89 > > > solution (except upgrade emacs).
\r
91 > > I'm not sure that notmuch-mua.el should be using `ido-completing-read',
\r
92 > > and certainly not without `require'ing it.
\r
94 > > Is there a particular thing required that `completing-read' doesn't do?
\r
96 > Thanks for the suggestion: I can confirm that with ido-completing-read
\r
97 > replaced by completing-read it works nicely. The "ido" version shows the
\r
98 > possibilities for you which is nice, but this works fine.
\r
100 I hadn't realised before but this also goes wrong if you use the prefix
\r
101 argument to mail (eg ctrl-u m). The current code seems to mess up the
\r
102 mini-buffer and even closing the buffer does not get out of it.
\r
104 Changing ido-completing-read read to completing-read seems to fix the
\r
105 problem entirely. Since this will affect most debian stable users (*) I
\r
106 think we should fix it. The trivial patch below works for me but other solutions
\r
107 may be better as they could maintain the benefits of ido-completing-read
\r
108 (eg that it shows the possibilities).
\r
114 (*) Perhaps only those who have more than one email address.
\r
116 diff --git a/emacs/notmuch-mua.el b/emacs/notmuch-mua.el
\r
117 index 023645e..41f82c2 100644
\r
118 --- a/emacs/notmuch-mua.el
\r
119 +++ b/emacs/notmuch-mua.el
\r
120 @@ -191,7 +191,7 @@ the From: header is already filled in by notmuch."
\r
121 ;; Now prompt the user, either for an email address only or for a full identity.
\r
124 - (ido-completing-read (concat "Sender address for " name ": ") addresses
\r
125 + (completing-read (concat "Sender address for " name ": ") addresses
\r
126 nil nil nil 'notmuch-mua-sender-history (car addresses))))
\r
127 (concat name " <" address ">"))
\r
128 (ido-completing-read "Send mail From: " notmuch-identities
\r