1 Return-Path: <cworth@cworth.org>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 0BCD242119B
\r
6 for <notmuch@notmuchmail.org>; Wed, 29 Jun 2011 16:13:20 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=0.01 tagged_above=-999 required=5
\r
12 tests=[T_MIME_NO_TEXT=0.01] autolearn=disabled
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id BW+l+dnt4gY8 for <notmuch@notmuchmail.org>;
\r
16 Wed, 29 Jun 2011 16:13:19 -0700 (PDT)
\r
17 Received: from arlo.cworth.org (arlo.cworth.org [50.43.72.2])
\r
18 by olra.theworths.org (Postfix) with ESMTP id A3314421192
\r
19 for <notmuch@notmuchmail.org>; Wed, 29 Jun 2011 16:13:19 -0700 (PDT)
\r
20 Received: from yoom.home.cworth.org (localhost [127.0.0.1])
\r
21 by arlo.cworth.org (Postfix) with ESMTP id B2A5729A85E;
\r
22 Wed, 29 Jun 2011 16:13:18 -0700 (PDT)
\r
23 Received: by yoom.home.cworth.org (Postfix, from userid 1000)
\r
24 id A4D6A2541A8; Wed, 29 Jun 2011 16:13:18 -0700 (PDT)
\r
25 From: Carl Worth <cworth@cworth.org>
\r
26 To: Austin Clements <amdragon@MIT.EDU>, notmuch@notmuchmail.org
\r
27 Subject: Re: [PATCH] new: Improved workaround for mistaken new directories
\r
28 In-Reply-To: <1309388401-16437-1-git-send-email-amdragon@mit.edu>
\r
29 References: <1309388401-16437-1-git-send-email-amdragon@mit.edu>
\r
30 User-Agent: Notmuch/0.5 (http://notmuchmail.org) Emacs/23.3.1
\r
32 Date: Wed, 29 Jun 2011 16:13:05 -0700
\r
33 Message-ID: <87d3hw44fy.fsf@yoom.home.cworth.org>
\r
35 Content-Type: multipart/signed; boundary="=-=-=";
\r
36 micalg=pgp-sha1; protocol="application/pgp-signature"
\r
37 Cc: amdragon@mit.edu
\r
38 X-BeenThere: notmuch@notmuchmail.org
\r
39 X-Mailman-Version: 2.1.13
\r
41 List-Id: "Use and development of the notmuch mail system."
\r
42 <notmuch.notmuchmail.org>
\r
43 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
44 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
45 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
46 List-Post: <mailto:notmuch@notmuchmail.org>
\r
47 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
48 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
49 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
50 X-List-Received-Date: Wed, 29 Jun 2011 23:13:20 -0000
\r
53 Content-Transfer-Encoding: quoted-printable
\r
55 On Wed, 29 Jun 2011 19:00:01 -0400, Austin Clements <amdragon@MIT.EDU> wrot=
\r
57 > We work around this by setting the new directory's database mtime to
\r
58 > -1 before scanning anything in the new directory. This also obviates
\r
59 > the need for the workaround used in 8c39e8d6.
\r
61 Thanks. This is pushed.
\r
63 > + /* XXX This is a temporary workaround. If we don't update the
\r
64 > + * database mtime until after processing messages in this
\r
66 > + * A better solution would be for notmuch_database_get_directory
\r
67 > + * to indicate if it really created a new directory or not, either
\r
68 > + * by a new out-argument, or by recording this information and
\r
69 > + * providing an accessor.
\r
71 A much better "XXX" comment! It tells the potential reader of the future
\r
72 what to do to be able to remove the comment. Thanks so much.
\r
77 carl.d.worth@intel.com
\r
80 Content-Type: application/pgp-signature
\r
82 -----BEGIN PGP SIGNATURE-----
\r
83 Version: GnuPG v1.4.11 (GNU/Linux)
\r
85 iEYEARECAAYFAk4LsYEACgkQ6JDdNq8qSWgW2gCeJ3fMpL6YUU0egCkohBBp06mD
\r
86 rQsAnikdmdOH0hJNpi91z1uqfTbUbXGX
\r
88 -----END PGP SIGNATURE-----
\r