1 Return-Path: <jrollins@finestructure.net>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id CA2FB431FBC
\r
6 for <notmuch@notmuchmail.org>; Fri, 25 May 2012 08:48:08 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-2.29 tagged_above=-999 required=5
\r
12 tests=[RCVD_IN_DNSWL_MED=-2.3, T_MIME_NO_TEXT=0.01] autolearn=disabled
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id EvQ28VVDhvzs for <notmuch@notmuchmail.org>;
\r
16 Fri, 25 May 2012 08:48:08 -0700 (PDT)
\r
17 Received: from outgoing-mail.its.caltech.edu (outgoing-mail.its.caltech.edu
\r
19 by olra.theworths.org (Postfix) with ESMTP id 56002431FB6
\r
20 for <notmuch@notmuchmail.org>; Fri, 25 May 2012 08:48:08 -0700 (PDT)
\r
21 Received: from earth-doxen.imss.caltech.edu (localhost [127.0.0.1])
\r
22 by earth-doxen-postvirus (Postfix) with ESMTP id 0C1C166E017C;
\r
23 Fri, 25 May 2012 08:48:06 -0700 (PDT)
\r
24 X-Spam-Scanned: at Caltech-IMSS on earth-doxen by amavisd-new
\r
25 Received: from finestructure.net (unknown [76.89.192.57])
\r
26 (Authenticated sender: jrollins)
\r
27 by earth-doxen-submit (Postfix) with ESMTP id 1BB5766E0024;
\r
28 Fri, 25 May 2012 08:48:03 -0700 (PDT)
\r
29 Received: by finestructure.net (Postfix, from userid 1000)
\r
30 id 2495C1EA; Fri, 25 May 2012 08:48:02 -0700 (PDT)
\r
31 From: Jameson Graef Rollins <jrollins@finestructure.net>
\r
32 To: Austin Clements <amdragon@MIT.EDU>
\r
33 Subject: Re: [PATCH v4 1/7] cli: use typedef to deal with gmime 2.4/2.6
\r
35 In-Reply-To: <20120525144136.GB11804@mit.edu>
\r
36 References: <1337812843-14986-1-git-send-email-jrollins@finestructure.net>
\r
37 <1337812843-14986-2-git-send-email-jrollins@finestructure.net>
\r
38 <20120525144136.GB11804@mit.edu>
\r
39 User-Agent: Notmuch/0.13+24~g16915cd (http://notmuchmail.org) Emacs/23.4.1
\r
40 (x86_64-pc-linux-gnu)
\r
41 Date: Fri, 25 May 2012 08:47:59 -0700
\r
42 Message-ID: <87wr40s1n4.fsf@servo.finestructure.net>
\r
44 Content-Type: multipart/signed; boundary="=-=-=";
\r
45 micalg=pgp-sha256; protocol="application/pgp-signature"
\r
46 Cc: Notmuch Mail <notmuch@notmuchmail.org>
\r
47 X-BeenThere: notmuch@notmuchmail.org
\r
48 X-Mailman-Version: 2.1.13
\r
50 List-Id: "Use and development of the notmuch mail system."
\r
51 <notmuch.notmuchmail.org>
\r
52 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
53 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
54 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
55 List-Post: <mailto:notmuch@notmuchmail.org>
\r
56 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
57 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
58 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
59 X-List-Received-Date: Fri, 25 May 2012 15:48:08 -0000
\r
63 On Fri, May 25 2012, Austin Clements <amdragon@MIT.EDU> wrote:
\r
64 >> diff --git a/notmuch-client.h b/notmuch-client.h
\r
65 >> index 19b7f01..337409f 100644
\r
66 >> --- a/notmuch-client.h
\r
67 >> +++ b/notmuch-client.h
\r
68 >> @@ -36,6 +36,8 @@
\r
69 >> * these to check the version number. */
\r
70 >> #ifdef GMIME_MAJOR_VERSION
\r
71 >> #define GMIME_ATLEAST_26
\r
73 >> +typedef GMimeCipherContext GMimeCryptoContext;
\r
75 > I like the typedef idea, but I don't think we should overload
\r
76 > GMimeCryptoContext like this. If someone is reading through the GMime
\r
77 > 2.4 code and sees this, they're going to assume that it's a GMime
\r
78 > structure, go looking for it, find that it's only in 2.6 and be
\r
79 > baffled. Instead, how about providing a typedef to abstract *both*
\r
80 > cases? Something like
\r
82 > #ifdef GMIME_MAJOR_VERSION
\r
83 > #define GMIME_ATLEAST_26
\r
84 > typedef notmuch_crypto_context_t GMimeCipherContext;
\r
86 > typedef notmuch_crypto_context_t GMimeCryptoContext;
\r
89 Hey, Austin. I briefly thought about this, but it seemed kind of heavy
\r
90 handed given that I hope these ifdefs will go away in the
\r
91 not-too-distant future. Do we really have a lot of gmime 2.4 readers
\r
92 that would not have access to gmime 2.6 documentation? I'm pretty sure
\r
93 that I would personally end up looking at documentation for both
\r
96 But anyway, if this really is a concern, I guess it's not *that* much
\r
97 effort to support a new typedef indefinitely to alleviate any potential
\r
100 Any other opinions?
\r
105 Content-Type: application/pgp-signature
\r
107 -----BEGIN PGP SIGNATURE-----
\r
108 Version: GnuPG v1.4.12 (GNU/Linux)
\r
110 iQIcBAEBCAAGBQJPv6mvAAoJEO00zqvie6q81PkQAJ8N81j8voiwBwuTbnqx1pV5
\r
111 QunogNVwa6qtcvh+Np0heG6GRw5ABbjPRlouZZeAIsZQLgVY9RIUndAfHmvXXMsy
\r
112 ZhHtZaSYK7PyASFx1X76lYGXcApiobj6GDJr/aErfNHi2+jMmQQMF1iNoo77m7qk
\r
113 KC1MkkbTXTK+XdGyBynv2TtBQIIJGjifXdeYTtoYZfiPjBTZdwAgga8sSO0TADFd
\r
114 ti5cQrOggzgsH7bT1ucF4kLRIampr5TrP6NhV01k8ZgIS/O0QvoiOt5AbIoszerF
\r
115 xAWH3uD3o+Xy+GZeOJ3OkHJq3C0rfQX8M5NaYduMyXWpPJRS4+buiSeiTtphilBX
\r
116 lnNQLNq75PhjTvQnPyUnJ0eAySvV0ZKTW/M8DJn7CT30bbSwRaskY30ku+BnWCsn
\r
117 Rcsof/28o++n64CNkPGv9Wjuod0OrBM3nlUXPS1eQjHSS/wAQtwZOp4Maa5pHu5+
\r
118 gNUsBxAasljIqHQRsQPI0js8rfv7E5NZphJBmrXPN2/RpXx5b493MODN1mXdgjWY
\r
119 hdXw0bx3FrBHnE/XQHtedVKvpksYXvwg7uuJAmEVJGh0guk3fL0VvXyv2dP9eyQa
\r
120 n9Qx+GRhofHuvd5Mq2bIjGKrVV7pRITMO/We4et4/DmjVb7JvmaiVZbVSzaj60zV
\r
121 JgF+kN8T3wHorfObJRbX
\r
123 -----END PGP SIGNATURE-----
\r