1 Return-Path: <dmitry.kurochkin@gmail.com>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id DE210429E25
\r
6 for <notmuch@notmuchmail.org>; Thu, 12 Jan 2012 06:54:38 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5
\r
12 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,
\r
13 FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
\r
14 Received: from olra.theworths.org ([127.0.0.1])
\r
15 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
16 with ESMTP id YWl2oFtV5Qi1 for <notmuch@notmuchmail.org>;
\r
17 Thu, 12 Jan 2012 06:54:38 -0800 (PST)
\r
18 Received: from mail-ey0-f181.google.com (mail-ey0-f181.google.com
\r
19 [209.85.215.181]) (using TLSv1 with cipher RC4-SHA (128/128 bits))
\r
20 (No client certificate requested)
\r
21 by olra.theworths.org (Postfix) with ESMTPS id 09886431FB6
\r
22 for <notmuch@notmuchmail.org>; Thu, 12 Jan 2012 06:54:37 -0800 (PST)
\r
23 Received: by eaah10 with SMTP id h10so915298eaa.26
\r
24 for <notmuch@notmuchmail.org>; Thu, 12 Jan 2012 06:54:36 -0800 (PST)
\r
25 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;
\r
26 h=from:to:subject:in-reply-to:references:user-agent:date:message-id
\r
27 :mime-version:content-type;
\r
28 bh=3wqTYL7Yy3Fe3pFtEi5D9l0FCdpxBXmJJaZNFoICtsc=;
\r
29 b=M8cRppF19WkpN04gLSSG6hcSD85pjbEVS2dxRu16P9YuESlOrAAh14AeQZ3sy4aV3X
\r
30 y/1jRiLGio7/OMXHhH5eekhKrlHVgamPoaN7JHdVoL7oVmdHxFx2p5CRcJZag4LZOfrn
\r
31 DPGcRnRt8oi4cEhbSZltfWb/hNHw4ACvNFkg4=
\r
32 Received: by 10.204.153.199 with SMTP id l7mr1267642bkw.88.1326380076704;
\r
33 Thu, 12 Jan 2012 06:54:36 -0800 (PST)
\r
34 Received: from localhost ([91.144.186.21])
\r
35 by mx.google.com with ESMTPS id b9sm11206888bks.6.2012.01.12.06.54.35
\r
36 (version=TLSv1/SSLv3 cipher=OTHER);
\r
37 Thu, 12 Jan 2012 06:54:36 -0800 (PST)
\r
38 From: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>
\r
39 To: David Edmondson <dme@dme.org>, notmuch@notmuchmail.org
\r
40 Subject: Re: [PATCH] notmuch/emacs: Observe the charset of encoded parts,
\r
42 In-Reply-To: <cunr4z5kmmu.fsf@hotblack-desiato.hh.sledj.net>
\r
43 References: <1326279001-28427-1-git-send-email-dme@dme.org>
\r
44 <87k44ym6ka.fsf@gmail.com>
\r
45 <cun8vldm8q9.fsf@hotblack-desiato.hh.sledj.net>
\r
46 <878vldgg3b.fsf@gmail.com>
\r
47 <cunr4z5kmmu.fsf@hotblack-desiato.hh.sledj.net>
\r
48 User-Agent: Notmuch/0.10.2+135~gb811a3c (http://notmuchmail.org) Emacs/23.3.1
\r
49 (x86_64-pc-linux-gnu)
\r
50 Date: Thu, 12 Jan 2012 18:53:45 +0400
\r
51 Message-ID: <8762ghgefa.fsf@gmail.com>
\r
53 Content-Type: text/plain; charset=us-ascii
\r
54 X-BeenThere: notmuch@notmuchmail.org
\r
55 X-Mailman-Version: 2.1.13
\r
57 List-Id: "Use and development of the notmuch mail system."
\r
58 <notmuch.notmuchmail.org>
\r
59 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
60 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
61 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
62 List-Post: <mailto:notmuch@notmuchmail.org>
\r
63 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
64 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
65 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
66 X-List-Received-Date: Thu, 12 Jan 2012 14:54:39 -0000
\r
68 On Thu, 12 Jan 2012 14:42:49 +0000, David Edmondson <dme@dme.org> wrote:
\r
69 > On Thu, 12 Jan 2012 18:17:44 +0400, Dmitry Kurochkin <dmitry.kurochkin@gmail.com> wrote:
\r
70 > > I think there is a record of useful features and fixes that were not
\r
71 > > accepted to notmuch because of some implementation issues. And
\r
72 > > interested people were using them in private repos for years. (I do not
\r
73 > > say that it is always the right thing to do, or that it is the right
\r
74 > > thing in this particular case.)
\r
76 > I agree that this has happened. I think that it's a failure of the
\r
77 > project that it has become common, necessary and generally accepted.
\r
79 > > I would like to see the following changes:
\r
81 > > * Properly handle charset with parameters in Emacs UI. Currently it is
\r
82 > > broken by your patch in one place at least:
\r
83 > > `notmuch-show-handlers-for' would produce incorrect results for
\r
84 > > content-type string with parameters. In my patch [1] I did parse the
\r
85 > > charset at top level and then changed all usages of it accordingly.
\r
86 > > Making `notmuch-show-handlers-for' smarter about parameters may be
\r
87 > > sufficient, but I would like to see some more details on why adding
\r
88 > > parameters to content-type string does not break Emacs UI code in
\r
91 > Your patch modifies the output of 'notmuch show' such that it included
\r
92 > the full value of the content-type header, which means that it is
\r
93 > necessary to parse it more carefully in emacs to discover and (as
\r
94 > necessary) remove the parameters. The patch I posted doesn't do this,
\r
95 > preferring to pass the charset (if any) as a supplementary parameter and
\r
96 > leave the content-type as-is. This distinction means that the patch I
\r
97 > posted isn't broken in the way that you describe.
\r
100 Sorry, I should have better look at the code.
\r
102 > > * Add charset parameter for text/html parts only.
\r
104 > Version 2 of the patch does this.
\r
106 > > * Use `mail-header-parse-content-type' to parse content-type instead of
\r
107 > > contructing the list for `mm-make-handle' manually.
\r
109 > That's not required, see above.
\r
111 > > * Add a proper XXX comment to notmuch-show code.
\r
113 > I'm happy to do that.
\r
115 > > I cannot say I would be happy about this patch after these changes.
\r
117 > Can you say why? I agree that it is not a solution to all problems, but
\r
118 > it is a workable solution to a specific problem.
\r
121 At the very least, because I did not really review the code, as you
\r
122 probably understood from my poor comments :)
\r
124 I do not have a strong preference here. If others do, I prefer to leave
\r
125 it for them to decide.
\r
127 > > It would be a temporary hack anyway.
\r
129 > Agreed. Do you have any idea when you might be able to spend time on the
\r
132 I hope to work on this once Austin's notmuch show rewrite is done. It
\r
133 is progressing, but I do not have any estimations.
\r
projects / notmuch-archives.git / blob