1 Return-Path: <dmitry.kurochkin@gmail.com>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 537B5429E34
\r
6 for <notmuch@notmuchmail.org>; Tue, 31 Jan 2012 00:25:47 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5
\r
12 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,
\r
13 FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
\r
14 Received: from olra.theworths.org ([127.0.0.1])
\r
15 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
16 with ESMTP id PQi8AoQPDUnq for <notmuch@notmuchmail.org>;
\r
17 Tue, 31 Jan 2012 00:25:46 -0800 (PST)
\r
18 Received: from mail-bk0-f53.google.com (mail-bk0-f53.google.com
\r
19 [209.85.214.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits))
\r
20 (No client certificate requested)
\r
21 by olra.theworths.org (Postfix) with ESMTPS id 8605B431E64
\r
22 for <notmuch@notmuchmail.org>; Tue, 31 Jan 2012 00:25:46 -0800 (PST)
\r
23 Received: by bke11 with SMTP id 11so2276244bke.26
\r
24 for <notmuch@notmuchmail.org>; Tue, 31 Jan 2012 00:25:45 -0800 (PST)
\r
25 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;
\r
26 h=from:to:subject:in-reply-to:references:user-agent:date:message-id
\r
27 :mime-version:content-type;
\r
28 bh=oha9sH6fopClXRnD8kIgbDt1DvmCCZss5LxVp2+xnjg=;
\r
29 b=MrjcOWgeGhEqIG41njW1VGTgBy2XC2TafFZ8qX6VO8gfz8FOklok0PS7j/HtrKP2di
\r
30 /9qXmJkSHpr7JvVHR5fhz8pD5Ww0HObS70adpN0b11xCm335yZeURc+8zrUEbNBI9Fd2
\r
31 tfnihs92KLNV/QtXpNAndijPsHNUmVphsUqFo=
\r
32 Received: by 10.205.132.138 with SMTP id hu10mr9950153bkc.117.1327998345194;
\r
33 Tue, 31 Jan 2012 00:25:45 -0800 (PST)
\r
34 Received: from localhost ([91.144.186.21])
\r
35 by mx.google.com with ESMTPS id bw9sm43487518bkb.8.2012.01.31.00.25.42
\r
36 (version=TLSv1/SSLv3 cipher=OTHER);
\r
37 Tue, 31 Jan 2012 00:25:43 -0800 (PST)
\r
38 From: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>
\r
39 To: David Edmondson <dme@dme.org>, notmuch@notmuchmail.org
\r
40 Subject: Re: [PATCH 2/2] emacs: Don't move to the next thread unless the
\r
41 cursor is at the end of the buffer.
\r
42 In-Reply-To: <cunaa54b7sz.fsf@hotblack-desiato.hh.sledj.net>
\r
43 References: <1327996914-9644-1-git-send-email-dme@dme.org>
\r
44 <1327996914-9644-3-git-send-email-dme@dme.org>
\r
45 <87bopknvct.fsf@gmail.com>
\r
46 <cunaa54b7sz.fsf@hotblack-desiato.hh.sledj.net>
\r
47 User-Agent: Notmuch/0.11+139~gd9b7cab (http://notmuchmail.org) Emacs/23.3.1
\r
48 (x86_64-pc-linux-gnu)
\r
49 Date: Tue, 31 Jan 2012 12:24:27 +0400
\r
50 Message-ID: <877h08nutg.fsf@gmail.com>
\r
52 Content-Type: text/plain; charset=us-ascii
\r
53 X-BeenThere: notmuch@notmuchmail.org
\r
54 X-Mailman-Version: 2.1.13
\r
56 List-Id: "Use and development of the notmuch mail system."
\r
57 <notmuch.notmuchmail.org>
\r
58 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
59 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
60 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
61 List-Post: <mailto:notmuch@notmuchmail.org>
\r
62 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
63 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
64 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
65 X-List-Received-Date: Tue, 31 Jan 2012 08:25:47 -0000
\r
67 On Tue, 31 Jan 2012 08:22:20 +0000, David Edmondson <dme@dme.org> wrote:
\r
68 > On Tue, 31 Jan 2012 12:12:50 +0400, Dmitry Kurochkin <dmitry.kurochkin@gmail.com> wrote:
\r
69 > > On Tue, 31 Jan 2012 08:01:54 +0000, David Edmondson <dme@dme.org> wrote:
\r
70 > > > When using the spacebar to scroll through a thread, hitting 'space'
\r
71 > > > when the bottom of the last message is visible should take the cursor
\r
72 > > > to the end of the buffer rather than immediately archiving the thread
\r
73 > > > and moving to the next thread.
\r
76 > > I did not notice this change yet, so +0
\r
78 > > A style comment below.
\r
80 > > > emacs/notmuch-show.el | 5 +++++
\r
81 > > > 1 files changed, 5 insertions(+), 0 deletions(-)
\r
83 > > > diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
\r
84 > > > index ec72ff8..3f54de0 100644
\r
85 > > > --- a/emacs/notmuch-show.el
\r
86 > > > +++ b/emacs/notmuch-show.el
\r
87 > > > @@ -1319,6 +1319,11 @@ current window), advance to the next open message."
\r
88 > > > ;; This is not the last message - move to the next visible one.
\r
89 > > > (notmuch-show-next-open-message))
\r
91 > > > + ((not (= (point) (point-max)))
\r
92 > > > + ;; This is the last message, but the cursor is not at the end of
\r
93 > > > + ;; the buffer. Move it there.
\r
94 > > > + (goto-char (point-max)))
\r
96 > > Perhaps `unless' would be better here?
\r
98 > It's the CONDITION clause of `cond', so that wouldn't be appropriate.
\r
103 This is why I like big diff contexts...
\r
113 > > > ;; This is the last message - change the return value
\r
114 > > > (setq ret t)))
\r
118 > > > _______________________________________________
\r
119 > > > notmuch mailing list
\r
120 > > > notmuch@notmuchmail.org
\r
121 > > > http://notmuchmail.org/mailman/listinfo/notmuch
\r