1 Return-Path: <dmitry.kurochkin@gmail.com>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 941AB431E64
\r
6 for <notmuch@notmuchmail.org>; Mon, 30 Jan 2012 14:07:49 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5
\r
12 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,
\r
13 FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
\r
14 Received: from olra.theworths.org ([127.0.0.1])
\r
15 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
16 with ESMTP id bcFJjFIxyPu8 for <notmuch@notmuchmail.org>;
\r
17 Mon, 30 Jan 2012 14:07:49 -0800 (PST)
\r
18 Received: from mail-bk0-f53.google.com (mail-bk0-f53.google.com
\r
19 [209.85.214.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits))
\r
20 (No client certificate requested)
\r
21 by olra.theworths.org (Postfix) with ESMTPS id DA9A6431FBC
\r
22 for <notmuch@notmuchmail.org>; Mon, 30 Jan 2012 14:07:48 -0800 (PST)
\r
23 Received: by bke11 with SMTP id 11so1911694bke.26
\r
24 for <notmuch@notmuchmail.org>; Mon, 30 Jan 2012 14:07:47 -0800 (PST)
\r
25 Received-SPF: pass (google.com: domain of dmitry.kurochkin@gmail.com
\r
26 designates 10.204.157.25 as permitted sender)
\r
27 client-ip=10.204.157.25;
\r
28 Authentication-Results: mr.google.com; spf=pass (google.com: domain of
\r
29 dmitry.kurochkin@gmail.com designates 10.204.157.25 as
\r
30 permitted sender) smtp.mail=dmitry.kurochkin@gmail.com;
\r
31 dkim=pass header.i=dmitry.kurochkin@gmail.com
\r
32 Received: from mr.google.com ([10.204.157.25])
\r
33 by 10.204.157.25 with SMTP id z25mr10576111bkw.25.1327961267590
\r
34 (num_hops = 1); Mon, 30 Jan 2012 14:07:47 -0800 (PST)
\r
35 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;
\r
36 h=from:to:subject:date:message-id:x-mailer;
\r
37 bh=sSHzwFaGTzED7MrQFyVNTKWKc4t5LH0H+F8AtuNNCtU=;
\r
38 b=oWl0xQtPCSmhTkn7xIKSyk6jbqmRgO7411WimUN2WboxOaX8zzl3DL5OQ9V8q8LzTI
\r
39 J1pFXmaXj5QEAREqyc+VTOLgUtw6s6qMLzudQqSF94ODRQWdgvzfc9EMtGu6AjjVfCN6
\r
40 6yNYCMt4jABOW49vRJPPD5k/3F58xZ0m6aQK0=
\r
41 Received: by 10.204.157.25 with SMTP id z25mr9190633bkw.25.1327961267490;
\r
42 Mon, 30 Jan 2012 14:07:47 -0800 (PST)
\r
43 Received: from localhost ([91.144.186.21])
\r
44 by mx.google.com with ESMTPS id cg2sm40505272bkb.12.2012.01.30.14.07.46
\r
45 (version=TLSv1/SSLv3 cipher=OTHER);
\r
46 Mon, 30 Jan 2012 14:07:46 -0800 (PST)
\r
47 From: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>
\r
48 To: notmuch@notmuchmail.org
\r
49 Subject: [PATCH 1/2] test: remove "Generate some messages" test from raw
\r
50 Date: Tue, 31 Jan 2012 02:06:34 +0400
\r
51 Message-Id: <1327961195-4204-1-git-send-email-dmitry.kurochkin@gmail.com>
\r
52 X-Mailer: git-send-email 1.7.8.3
\r
53 X-BeenThere: notmuch@notmuchmail.org
\r
54 X-Mailman-Version: 2.1.13
\r
56 List-Id: "Use and development of the notmuch mail system."
\r
57 <notmuch.notmuchmail.org>
\r
58 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
59 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
60 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
61 List-Post: <mailto:notmuch@notmuchmail.org>
\r
62 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
63 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
64 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
65 X-List-Received-Date: Mon, 30 Jan 2012 22:07:49 -0000
\r
67 Before the change, the first subtest in raw format tests just
\r
68 generated messages and checked that they are added successfully. This
\r
69 is not really a raw format test, it is creating of environment
\r
70 required for other subtests to run. The patch removes the first
\r
71 subtest from raw and replaces it with bare add_message calls, similar
\r
72 to how it is done in other tests.
\r
74 TODO: we should check that test environment was created successfully.
\r
75 Currently, many tests do add_message(), notmuch new and other calls
\r
76 without checking the results. We should come up with a general
\r
77 solution for this, i.e. if any command during test initialization
\r
78 fails, all tests should be skipped with appropriate error message.
\r
80 test/raw | 7 ++-----
\r
81 1 files changed, 2 insertions(+), 5 deletions(-)
\r
83 diff --git a/test/raw b/test/raw
\r
84 index 0171e64..de0b867 100755
\r
88 test_description='notmuch show --format=raw'
\r
91 -test_begin_subtest "Generate some messages"
\r
94 -output=$(NOTMUCH_NEW)
\r
95 -test_expect_equal "$output" "Added 2 new messages to the database."
\r
99 test_begin_subtest "Attempt to show multiple raw messages"
\r
100 output=$(notmuch show --format=raw "*" 2>&1)
\r