1 Return-Path: <bremner@unb.ca>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id C64BF431FB6
\r
6 for <notmuch@notmuchmail.org>; Thu, 5 Apr 2012 04:59:44 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id Fv4pOl1JqDHM for <notmuch@notmuchmail.org>;
\r
16 Thu, 5 Apr 2012 04:59:44 -0700 (PDT)
\r
17 Received: from tesseract.cs.unb.ca (tesseract.cs.unb.ca [131.202.240.238])
\r
18 (using TLSv1 with cipher AES256-SHA (256/256 bits))
\r
19 (No client certificate requested)
\r
20 by olra.theworths.org (Postfix) with ESMTPS id 36F7F431FAE
\r
21 for <notmuch@notmuchmail.org>; Thu, 5 Apr 2012 04:59:44 -0700 (PDT)
\r
22 Received: from fctnnbsc30w-156034089108.dhcp-dynamic.fibreop.nb.bellaliant.net
\r
23 ([156.34.89.108] helo=zancas.localnet)
\r
24 by tesseract.cs.unb.ca with esmtpsa (TLS1.0:RSA_AES_256_CBC_SHA1:32)
\r
25 (Exim 4.72) (envelope-from <bremner@unb.ca>)
\r
26 id 1SFlLq-0000kH-PJ; Thu, 05 Apr 2012 08:59:43 -0300
\r
27 Received: from bremner by zancas.localnet with local (Exim 4.77)
\r
28 (envelope-from <bremner@unb.ca>)
\r
29 id 1SFlLk-00010x-M0; Thu, 05 Apr 2012 08:59:36 -0300
\r
30 From: David Bremner <david@tethera.net>
\r
31 To: Jani Nikula <jani@nikula.org>, notmuch@notmuchmail.org
\r
32 Subject: Re: [PATCH 2/8] hex-escape: be more strict about the format while
\r
34 In-Reply-To: <87hawyxusp.fsf@nikula.org>
\r
35 References: <cover.1333231401.git.jani@nikula.org>
\r
36 <81e543344ffe8e2761afd57a2268e8b362f4aef4.1333231401.git.jani@nikula.org>
\r
37 <87fwcitnuk.fsf@zancas.localnet>
\r
38 <87hawyxusp.fsf@nikula.org>User-Agent: Notmuch/0.12+70~g46e73fe
\r
39 (http://notmuchmail.org) Emacs/23.3.1 (x86_64-pc-linux-gnu)
\r
40 Date: Thu, 05 Apr 2012 08:59:36 -0300
\r
41 Message-ID: <87aa2qtmmv.fsf@zancas.localnet>
\r
43 Content-Type: text/plain; charset=us-ascii
\r
45 X-BeenThere: notmuch@notmuchmail.org
\r
46 X-Mailman-Version: 2.1.13
\r
48 List-Id: "Use and development of the notmuch mail system."
\r
49 <notmuch.notmuchmail.org>
\r
50 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
51 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
52 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
53 List-Post: <mailto:notmuch@notmuchmail.org>
\r
54 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
55 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
56 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
57 X-List-Received-Date: Thu, 05 Apr 2012 11:59:44 -0000
\r
59 Jani Nikula <jani@nikula.org> writes:
\r
61 > On Thu, 05 Apr 2012 08:33:23 -0300, David Bremner <david@tethera.net> wrote:
\r
64 >> > + if (!isxdigit ((unsigned char) p[1]) ||
\r
65 >> > + !isxdigit ((unsigned char) p[2]))
\r
67 >> What happens if there are not two characters after the escape? Is this
\r
68 >> relying on calling isxdigit on the null terminator?
\r
70 > It is, and technically there's nothing wrong with that. Would you prefer
\r
71 > explicit checks for '\0' in the if condition, for clarity? Or a comment
\r
74 I think a comment would do. Or the checks if you prefer.
\r