1 Return-Path: <amdragon@mit.edu>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 1A1B5429E45
\r
6 for <notmuch@notmuchmail.org>; Fri, 17 Feb 2012 19:32:33 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5
\r
12 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id oa7TMMj8Zx2e for <notmuch@notmuchmail.org>;
\r
16 Fri, 17 Feb 2012 19:32:31 -0800 (PST)
\r
17 Received: from dmz-mailsec-scanner-2.mit.edu (DMZ-MAILSEC-SCANNER-2.MIT.EDU
\r
19 by olra.theworths.org (Postfix) with ESMTP id 59C3E431FAE
\r
20 for <notmuch@notmuchmail.org>; Fri, 17 Feb 2012 19:32:31 -0800 (PST)
\r
21 X-AuditID: 1209190d-b7fbf6d0000008ba-29-4f3f1bcedf44
\r
22 Received: from mailhub-auth-3.mit.edu ( [18.9.21.43])
\r
23 by dmz-mailsec-scanner-2.mit.edu (Symantec Messaging Gateway) with SMTP
\r
24 id 20.F0.02234.ECB1F3F4; Fri, 17 Feb 2012 22:32:30 -0500 (EST)
\r
25 Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103])
\r
26 by mailhub-auth-3.mit.edu (8.13.8/8.9.2) with ESMTP id q1I3WU7I007962;
\r
27 Fri, 17 Feb 2012 22:32:30 -0500
\r
28 Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91])
\r
29 (authenticated bits=0)
\r
30 (User authenticated as amdragon@ATHENA.MIT.EDU)
\r
31 by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id q1I3WSOx018146
\r
32 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT);
\r
33 Fri, 17 Feb 2012 22:32:29 -0500 (EST)
\r
34 Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.77)
\r
35 (envelope-from <amdragon@mit.edu>)
\r
36 id 1Ryb0V-0004Cr-Cp; Fri, 17 Feb 2012 22:30:43 -0500
\r
37 Date: Fri, 17 Feb 2012 22:30:43 -0500
\r
38 From: Austin Clements <amdragon@MIT.EDU>
\r
39 To: Adam Wolfe Gordon <awg+notmuch@xvx.ca>
\r
40 Subject: Re: [PATCH v5.2 7/7] emacs: Use the new JSON reply format and
\r
41 message-cite-original
\r
42 Message-ID: <20120218033043.GJ5991@mit.edu>
\r
43 References: <1329361957-28493-1-git-send-email-awg+notmuch@xvx.ca>
\r
44 <1329361957-28493-8-git-send-email-awg+notmuch@xvx.ca>
\r
45 <20120217200017.GG5991@mit.edu>
\r
46 <CAMoJFUs5jnu7=5PtrNib9J6P_FnxD8bK2L+oQiBdgXPJXhvMJg@mail.gmail.com>
\r
48 Content-Type: text/plain; charset=iso-8859-1
\r
49 Content-Disposition: inline
\r
50 Content-Transfer-Encoding: 8bit
\r
52 <CAMoJFUs5jnu7=5PtrNib9J6P_FnxD8bK2L+oQiBdgXPJXhvMJg@mail.gmail.com>
\r
53 User-Agent: Mutt/1.5.21 (2010-09-15)
\r
54 X-Brightmail-Tracker:
\r
55 H4sIAAAAAAAAA+NgFprLKsWRmVeSWpSXmKPExsUixCmqrXtO2t7f4HWjrcWRPbPYLa7fnMns
\r
56 wOTxbNUtZo+mH4tZA5iiuGxSUnMyy1KL9O0SuDKeNF5gLJgoUrFh/RX2Bsb3/F2MnBwSAiYS
\r
57 fw5MYoGwxSQu3FvP1sXIxSEksI9RYuKeHewQzgZGiZOvH0NlTjJJNBy9AZVZwigx6cBsdpB+
\r
58 FgFVib+Nr1lBbDYBDYlt+5czgtgiAloSP9Z/BYszC0hLfPvdzARiCwvESXz7fgWsl1dAW+Lz
\r
59 zclQQ58wSpzed5INIiEocXLmExaIZh2JnVvvAMU5wAYt/8cBEZaXaN46mxnE5hQIlNi/sR1s
\r
60 r6iAisSUk9vYJjAKz0IyaRaSSbMQJs1CMmkBI8sqRtmU3Crd3MTMnOLUZN3i5MS8vNQiXSO9
\r
61 3MwSvdSU0k2M4FiQ5N3B+O6g0iFGAQ5GJR5exx47fyHWxLLiytxDjJIcTEqivP1S9v5CfEn5
\r
62 KZUZicUZ8UWlOanFhxglOJiVRHi97gCV86YkVlalFuXDpKQ5WJTEeVW13vkJCaQnlqRmp6YW
\r
63 pBbBZGU4OJQkeMWBMS8kWJSanlqRlplTgpBm4uAEGc4DNHwHyGLe4oLE3OLMdIj8KUZFKXFe
\r
64 ZpBmAZBERmkeXC8sVb1iFAd6RZj3A0g7DzDNwXW/AhrMBDSYVwjk6uKSRISUVAPjjceXkrZy
\r
65 R9id+rlhhZjr2n8nGUXrdfhnhEUf3cvt+qqU496sXFmXCeXN0bck1Fcwqjrk3Fv5Y1fu05Pv
\r
66 rZa9Yvr+d06d24S/3550WfwzeB0R63RdL/lxk5FKx+m4u9f+9rdO6ddRCku/7SfA4Bm4f2bi
\r
67 nV0hX5/3pu3KOij2VzJ3nnremZCHSizFGYmGWsxFxYkAL5PORTADAAA=
\r
68 Cc: notmuch@notmuchmail.org
\r
69 X-BeenThere: notmuch@notmuchmail.org
\r
70 X-Mailman-Version: 2.1.13
\r
72 List-Id: "Use and development of the notmuch mail system."
\r
73 <notmuch.notmuchmail.org>
\r
74 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
75 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
76 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
77 List-Post: <mailto:notmuch@notmuchmail.org>
\r
78 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
79 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
80 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
81 X-List-Received-Date: Sat, 18 Feb 2012 03:32:33 -0000
\r
83 Quoth Adam Wolfe Gordon on Feb 17 at 7:22 pm:
\r
84 > On Fri, Feb 17, 2012 at 13:00, Austin Clements <amdragon@mit.edu> wrote:
\r
85 > > One general comment that affects a lot of things in this patch: I
\r
86 > > think you should use the same JSON parsing settings that
\r
87 > > notmuch-query-get-threads uses. Besides consistency and more
\r
88 > > opportunities for code reuse, using lists instead of vectors for JSON
\r
89 > > arrays will simplify a lot of this code without any drawbacks.
\r
91 > I pretty much agree. The only reason I stuck with alists was, as you
\r
92 > mention below, to be compatible with certain mail functions. Given the
\r
93 > things you've pointed out, I think the small hassle of making those
\r
94 > work with plists is worthwhile, so I'll give it a go.
\r
96 > Clarification on a couple of things follow, otherwise I'll make all
\r
97 > these changes for the next version.
\r
99 > >> + (goto-char (point-max)))
\r
101 > >> + (let ((from (cdr (assq 'From original-headers)))
\r
102 > >> + (date (cdr (assq 'Date original-headers)))
\r
103 > >> + (start (point)))
\r
105 > >> + (insert "From: " from "\n")
\r
106 > >> + (insert "Date: " date "\n\n")
\r
108 > > Sorry; I'm having trouble following the diff. What are the inserts
\r
111 > The function message-cite-original cites an original message, which is
\r
112 > in the marked region. It assumes the headers of the original message
\r
113 > will be part of the marked region, but the only ones it actually uses
\r
114 > are From and Date.
\r
116 > This could probably use a comment in the code.
\r
118 Ah, okay. Is this how it generates the citation line?
\r
120 Could definitely do with a comment.
\r
124 > > It's unfortunate that message-cite-original depends on the mark.
\r
125 > > Since you're about to push the mark for the user anyway, maybe this
\r
126 > > should be a set-mark so that only one mark gets pushed?
\r
128 > Probably the right thing to do.
\r
130 > >> + (goto-char start)
\r
131 > >> + ;; Quote the original message according to the user's configured style.
\r
132 > >> + (message-cite-original))))
\r
134 > > message-cite-original-without-signature?
\r
136 > Perhaps it should be configurable (notmuch-reply-cite-function or
\r
137 > somesuch). I believe message-cite-original matches the behavior of the
\r
138 > old reply, which didn't strip signatures, but I don't have strong
\r
139 > feelings either way.
\r
141 We should probably stick with the original behavior, at least for now.
\r
143 I just noticed that message-cite-original calls mml-quote-region. How
\r
144 is it that we don't wind up double-quoting MML tags with this change?
\r