1 Return-Path: <aaronecay@gmail.com>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 3140C431FD0
\r
6 for <notmuch@notmuchmail.org>; Sat, 17 Dec 2011 07:36:32 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5
\r
12 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,
\r
13 FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
\r
14 Received: from olra.theworths.org ([127.0.0.1])
\r
15 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
16 with ESMTP id 4Vbiqvk6FWIS for <notmuch@notmuchmail.org>;
\r
17 Sat, 17 Dec 2011 07:36:31 -0800 (PST)
\r
18 Received: from mail-qw0-f53.google.com (mail-qw0-f53.google.com
\r
19 [209.85.216.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits))
\r
20 (No client certificate requested)
\r
21 by olra.theworths.org (Postfix) with ESMTPS id C635A431FB6
\r
22 for <notmuch@notmuchmail.org>; Sat, 17 Dec 2011 07:36:31 -0800 (PST)
\r
23 Received: by qadb15 with SMTP id b15so3033899qad.5
\r
24 for <notmuch@notmuchmail.org>; Sat, 17 Dec 2011 07:36:31 -0800 (PST)
\r
25 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;
\r
26 h=from:to:subject:date:message-id:x-mailer;
\r
27 bh=Av5hVVEBxjDIqVidRKNudpugZadQc9GcZ8usFaYAl+s=;
\r
28 b=iD2j+kA6WOFxUtvyiylyxZHZJAviuMz88OqAg60GXj/jbIiAgRzzgScmZnWSCdDiFC
\r
29 l6TLQccHSkPWfI89dSnniVcihb64Jw+6s9fix2UvFqBLeqv2vwPMeiUeGDgfaQbACz7S
\r
30 bUmKZ9c4BpJfCD0WhIOLPZlR0XhgFyZSM9dKc=
\r
31 Received: by 10.224.200.197 with SMTP id ex5mr17039147qab.88.1324136191188;
\r
32 Sat, 17 Dec 2011 07:36:31 -0800 (PST)
\r
33 Received: from localhost.localdomain (c-68-80-94-73.hsd1.pa.comcast.net.
\r
35 by mx.google.com with ESMTPS id eb5sm26946945qab.10.2011.12.17.07.36.30
\r
36 (version=TLSv1/SSLv3 cipher=OTHER);
\r
37 Sat, 17 Dec 2011 07:36:30 -0800 (PST)
\r
38 From: Aaron Ecay <aaronecay@gmail.com>
\r
39 To: notmuch@notmuchmail.org
\r
40 Subject: [PATCH] Give a path name to mktemp in Makefile.local
\r
41 Date: Sat, 17 Dec 2011 10:36:25 -0500
\r
42 Message-Id: <1324136185-4509-1-git-send-email-aaronecay@gmail.com>
\r
43 X-Mailer: git-send-email 1.7.8
\r
44 X-BeenThere: notmuch@notmuchmail.org
\r
45 X-Mailman-Version: 2.1.13
\r
47 List-Id: "Use and development of the notmuch mail system."
\r
48 <notmuch.notmuchmail.org>
\r
49 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
50 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
51 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
52 List-Post: <mailto:notmuch@notmuchmail.org>
\r
53 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
54 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
55 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
56 X-List-Received-Date: Sat, 17 Dec 2011 15:36:32 -0000
\r
58 On some systems (incl. OS X 10.6), mktemp expects an argument giving it
\r
59 the place to put the new temporary file.
\r
62 On my machine without this patch, make prints a message from mktemp
\r
63 about expecting an argument each time it is run. At some point, make
\r
64 got into a situation where it would print this message and exit cleanly,
\r
65 but not build any changed files. A "make clean" was necessary to kick
\r
66 it into working again.
\r
68 A disadvantage of this approach is that it drops an empty file into /tmp
\r
69 on every make run. It would be better to only create this file when
\r
70 doing "make debian-snapshot", but I am not sure how to do that (cleanly;
\r
71 my best idea is to put the build commands into a subshell and export an
\r
72 environment variable for the temp file). Any make/debian experts want
\r
75 Makefile.local | 2 +-
\r
76 1 files changed, 1 insertions(+), 1 deletions(-)
\r
78 diff --git a/Makefile.local b/Makefile.local
\r
79 index c94402b..6eb4b18 100644
\r
80 --- a/Makefile.local
\r
81 +++ b/Makefile.local
\r
82 @@ -139,7 +139,7 @@ pre-release:
\r
83 mv $(TAR_FILE) $(DEB_TAR_FILE) releases
\r
85 .PHONY: debian-snapshot
\r
86 -debian-snapshot: TMPFILE := $(shell mktemp)
\r
87 +debian-snapshot: TMPFILE := $(shell mktemp /tmp/notmuch.XXXXXX)
\r
89 make VERSION=$(VERSION) clean
\r
90 cp debian/changelog $(TMPFILE)
\r