1 Return-Path: <dme@dme.org>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id CB58E429E42
\r
6 for <notmuch@notmuchmail.org>; Wed, 4 Jan 2012 06:13:14 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5
\r
12 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id SkfP31OC+wkY for <notmuch@notmuchmail.org>;
\r
16 Wed, 4 Jan 2012 06:13:14 -0800 (PST)
\r
17 Received: from mail-we0-f181.google.com (mail-we0-f181.google.com
\r
18 [74.125.82.181]) (using TLSv1 with cipher RC4-SHA (128/128 bits))
\r
19 (No client certificate requested)
\r
20 by olra.theworths.org (Postfix) with ESMTPS id 16986429E3D
\r
21 for <notmuch@notmuchmail.org>; Wed, 4 Jan 2012 06:13:13 -0800 (PST)
\r
22 Received: by werm12 with SMTP id m12so10893899wer.26
\r
23 for <notmuch@notmuchmail.org>; Wed, 04 Jan 2012 06:13:12 -0800 (PST)
\r
24 Received: by 10.216.131.155 with SMTP id m27mr31547993wei.19.1325686392740;
\r
25 Wed, 04 Jan 2012 06:13:12 -0800 (PST)
\r
26 Received: from hotblack-desiato.hh.sledj.net
\r
27 (host81-149-164-25.in-addr.btopenworld.com. [81.149.164.25])
\r
28 by mx.google.com with ESMTPS id k33sm17587462wbo.5.2012.01.04.06.13.10
\r
29 (version=TLSv1/SSLv3 cipher=OTHER);
\r
30 Wed, 04 Jan 2012 06:13:11 -0800 (PST)
\r
31 Received: by hotblack-desiato.hh.sledj.net (Postfix, from userid 30000)
\r
32 id 7288BA0334; Wed, 4 Jan 2012 14:13:09 +0000 (GMT)
\r
33 To: Jani Nikula <jani@nikula.org>, notmuch@notmuchmail.org
\r
34 Subject: Re: [PATCH] emacs: call "notmuch tag" only once when archiving a
\r
36 In-Reply-To: <1325615346-8302-1-git-send-email-jani@nikula.org>
\r
37 References: <1325615346-8302-1-git-send-email-jani@nikula.org>
\r
38 User-Agent: Notmuch/0.10.2+151~gbf1dc2b (http://notmuchmail.org)
\r
39 Emacs/24.0.92.1 (x86_64-pc-linux-gnu)
\r
40 From: David Edmondson <dme@dme.org>
\r
41 Date: Wed, 04 Jan 2012 14:13:05 +0000
\r
42 Message-ID: <cunzke34kum.fsf@hotblack-desiato.hh.sledj.net>
\r
44 Content-Type: multipart/signed; boundary="=-=-=";
\r
45 micalg=pgp-sha1; protocol="application/pgp-signature"
\r
46 X-BeenThere: notmuch@notmuchmail.org
\r
47 X-Mailman-Version: 2.1.13
\r
49 List-Id: "Use and development of the notmuch mail system."
\r
50 <notmuch.notmuchmail.org>
\r
51 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
52 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
53 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
54 List-Post: <mailto:notmuch@notmuchmail.org>
\r
55 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
56 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
57 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
58 X-List-Received-Date: Wed, 04 Jan 2012 14:13:15 -0000
\r
61 Content-Type: text/plain
\r
63 This seems like a good idea.
\r
65 On Tue, 3 Jan 2012 20:29:06 +0200, Jani Nikula <jani@nikula.org> wrote:
\r
66 > On the downside, IIRC Xapian does not perform very well if the query
\r
67 > (in this case a lot of message-ids OR'd together) is very big. It is
\r
68 > unknown to me at which point this approach would become slower than
\r
69 > the original one by one tagging approach, if ever.
\r
71 Unless this limit is quite small (<1000), I'd be inclined not to worry
\r
74 > Also, this introduces a limitation to the number of messages that can
\r
75 > be archived at the same time (through ARG_MAX limiting the command
\r
76 > line). At least on Linux this seems more like a theoretical limitation
\r
79 What's the failure mode when this does happen?
\r
81 > + (let ((message-ids))
\r
83 No need for both sets of brackets:
\r
90 > + (let* ((current-tags (notmuch-show-get-tags))
\r
91 > + (new-tags (notmuch-show-del-tags-worker current-tags toremove)))
\r
92 > + (unless (equal current-tags new-tags)
\r
93 > + (add-to-list 'message-ids (notmuch-show-get-message-id))))
\r
94 > + until (not (notmuch-show-goto-message-next)))
\r
96 `loop' has the ability to accumulate results, which would probably be
\r
97 cleaner than `add-to-list'. See 'Accumulation Clauses' in the emacs cl
\r
101 Content-Type: application/pgp-signature
\r
103 -----BEGIN PGP SIGNATURE-----
\r
104 Version: GnuPG v1.4.11 (GNU/Linux)
\r
106 iEYEARECAAYFAk8EXnEACgkQaezQq/BJZRaFTwCfX+jZsleiDn+s29Lq+j7W5XI1
\r
107 QT0Ani1F9ARA+nTMUMU7EdxijlfVfw4Y
\r
109 -----END PGP SIGNATURE-----
\r