1 Return-Path: <tomi.ollila@iki.fi>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id BD7DC431FAF
\r
6 for <notmuch@notmuchmail.org>; Fri, 9 Aug 2013 01:19:24 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id Cy35r2EYo84G for <notmuch@notmuchmail.org>;
\r
16 Fri, 9 Aug 2013 01:19:12 -0700 (PDT)
\r
17 Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])
\r
18 by olra.theworths.org (Postfix) with ESMTP id BD2ED431FAE
\r
19 for <notmuch@notmuchmail.org>; Fri, 9 Aug 2013 01:19:12 -0700 (PDT)
\r
20 Received: from guru.guru-group.fi (localhost [IPv6:::1])
\r
21 by guru.guru-group.fi (Postfix) with ESMTP id 4E1A41000B2;
\r
22 Fri, 9 Aug 2013 11:19:02 +0300 (EEST)
\r
23 From: Tomi Ollila <tomi.ollila@iki.fi>
\r
24 To: Geoffrey Ferrari <geoffrey.ferrari@oriel.oxon.org>,
\r
25 notmuch@notmuchmail.org
\r
26 Subject: Re: [PATCH] emacs: bugfix notmuch-mua-reply when signature is present
\r
28 <1375961732-14327-1-git-send-email-geoffrey.ferrari@oriel.oxon.org>
\r
30 <1375961732-14327-1-git-send-email-geoffrey.ferrari@oriel.oxon.org>
\r
31 User-Agent: Notmuch/0.16 (http://notmuchmail.org) Emacs/24.3.1
\r
32 (x86_64-unknown-linux-gnu)
\r
33 X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
\r
34 $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
\r
35 !)g;OY^,BjTbr)Np:%c_o'jj,Z
\r
36 Date: Fri, 09 Aug 2013 11:19:02 +0300
\r
37 Message-ID: <m238qjqnt5.fsf@guru.guru-group.fi>
\r
39 Content-Type: text/plain
\r
40 X-BeenThere: notmuch@notmuchmail.org
\r
41 X-Mailman-Version: 2.1.13
\r
43 List-Id: "Use and development of the notmuch mail system."
\r
44 <notmuch.notmuchmail.org>
\r
45 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
46 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
47 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
48 List-Post: <mailto:notmuch@notmuchmail.org>
\r
49 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
50 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
51 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
52 X-List-Received-Date: Fri, 09 Aug 2013 08:19:24 -0000
\r
54 On Thu, Aug 08 2013, Geoffrey Ferrari <geoffrey.ferrari@oriel.oxon.org> wrote:
\r
56 > From: "Geoffrey H. Ferrari" <geoffrey.ferrari@oriel.oxon.org>
\r
58 > When composing a reply, notmuch-mua-reply tries to be smart and cite
\r
59 > the original message by inserting it before the user signature, if
\r
60 > one is present. However, the existing method of backward searching
\r
61 > from the end of the buffer to find the signature separator and then
\r
62 > moving one line up results in the original message being cited in
\r
63 > the message headers. That's because at this point the message looks
\r
64 > like this (with | representing point after searching for the
\r
65 > signature separator):
\r
70 > --text follows this line--
\r
72 > My fancy signature
\r
74 > With this patch, a newline is opened instead, so that the orignal
\r
75 > message is cited above the signature but still in the message text.
\r
78 This probably fixes #1 in id:8762auwgfl.fsf@steelpick.2x.cz
\r
80 ( http://mid.gmane.org/8762auwgfl.fsf@steelpick.2x.cz )
\r
82 ... I just noticed I have no clue how to set message signature to test
\r
90 > emacs/notmuch-mua.el | 2 +-
\r
91 > 1 file changed, 1 insertion(+), 1 deletion(-)
\r
93 > diff --git a/emacs/notmuch-mua.el b/emacs/notmuch-mua.el
\r
94 > index 2baae5f..86f164d 100644
\r
95 > --- a/emacs/notmuch-mua.el
\r
96 > +++ b/emacs/notmuch-mua.el
\r
97 > @@ -194,7 +194,7 @@ list."
\r
98 > ;; if one is present
\r
99 > (goto-char (point-max))
\r
100 > (if (re-search-backward message-signature-separator nil t)
\r
101 > - (forward-line -1)
\r
103 > (goto-char (point-max)))
\r
105 > (let ((from (plist-get original-headers :From))
\r
109 > _______________________________________________
\r
110 > notmuch mailing list
\r
111 > notmuch@notmuchmail.org
\r
112 > http://notmuchmail.org/mailman/listinfo/notmuch
\r