Re: [PATCH] Fix typo in Message.maildir_flags_to_tags
[notmuch-archives.git] / 60 / 73cff4c05bb97d050726e377853e4d8baeda9a
1 Return-Path: <jrollins@finestructure.net>\r
2 X-Original-To: notmuch@notmuchmail.org\r
3 Delivered-To: notmuch@notmuchmail.org\r
4 Received: from localhost (localhost [127.0.0.1])\r
5         by olra.theworths.org (Postfix) with ESMTP id D1EC7431FD0\r
6         for <notmuch@notmuchmail.org>; Fri,  5 Aug 2011 14:04:45 -0700 (PDT)\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
8 X-Spam-Flag: NO\r
9 X-Spam-Score: -2.29\r
10 X-Spam-Level: \r
11 X-Spam-Status: No, score=-2.29 tagged_above=-999 required=5\r
12         tests=[RCVD_IN_DNSWL_MED=-2.3, T_MIME_NO_TEXT=0.01] autolearn=disabled\r
13 Received: from olra.theworths.org ([127.0.0.1])\r
14         by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
15         with ESMTP id CATYcoZ1X+HN for <notmuch@notmuchmail.org>;\r
16         Fri,  5 Aug 2011 14:04:45 -0700 (PDT)\r
17 Received: from outgoing-mail.its.caltech.edu (outgoing-mail.its.caltech.edu\r
18         [131.215.239.19])\r
19         by olra.theworths.org (Postfix) with ESMTP id 499C5431FB6\r
20         for <notmuch@notmuchmail.org>; Fri,  5 Aug 2011 14:04:45 -0700 (PDT)\r
21 Received: from earth-doxen.imss.caltech.edu (localhost [127.0.0.1])\r
22         by earth-doxen-postvirus (Postfix) with ESMTP id 27EA666E0270;\r
23         Fri,  5 Aug 2011 14:00:33 -0700 (PDT)\r
24 X-Spam-Scanned: at Caltech-IMSS on earth-doxen by amavisd-new\r
25 Received: from finestructure.net (gwave-176.ligo.caltech.edu\r
26  [131.215.114.176])     (Authenticated sender: jrollins)        by earth-doxen-submit\r
27  (Postfix) with ESMTP id 789B566E014A;  Fri,  5 Aug 2011 14:00:26 -0700 (PDT)\r
28 Received: by finestructure.net (Postfix, from userid 1000)\r
29         id 455692F5; Fri,  5 Aug 2011 14:00:26 -0700 (PDT)\r
30 From: Jameson Graef Rollins <jrollins@finestructure.net>\r
31 To: Daniel Schoepe <daniel.schoepe@googlemail.com>,\r
32         Austin Clements <amdragon@MIT.EDU>\r
33 Subject: Re: [PATCH] emacs: Tab completion for notmuch-search and\r
34         notmuch-search-filter\r
35 In-Reply-To: <87sjpfj3a3.fsf@gilead.invalid>\r
36 References: <1307189970-728-1-git-send-email-daniel.schoepe@googlemail.com>\r
37         <BANLkTimudbqYy8JhGHu67WsOS04mCm0hfA@mail.gmail.com>\r
38         <87mxhxjrry.fsf@gilead.invalid> <20110604215523.GF29861@mit.edu>\r
39         <87hb85jjgx.fsf@gilead.invalid> <87lixevs2e.fsf@gilead.invalid>\r
40         <87sjpfj3a3.fsf@gilead.invalid>\r
41 User-Agent: Notmuch/0.7-41-g8dcabc9 (http://notmuchmail.org) Emacs/23.3.1\r
42         (x86_64-pc-linux-gnu)\r
43 Date: Fri, 05 Aug 2011 14:00:20 -0700\r
44 Message-ID: <87liv7r2u3.fsf@servo.factory.finestructure.net>\r
45 MIME-Version: 1.0\r
46 Content-Type: multipart/signed; boundary="=-=-=";\r
47         micalg=pgp-sha256; protocol="application/pgp-signature"\r
48 Cc: notmuch@notmuchmail.org\r
49 X-BeenThere: notmuch@notmuchmail.org\r
50 X-Mailman-Version: 2.1.13\r
51 Precedence: list\r
52 List-Id: "Use and development of the notmuch mail system."\r
53         <notmuch.notmuchmail.org>\r
54 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
55         <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
56 List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
57 List-Post: <mailto:notmuch@notmuchmail.org>\r
58 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
59 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
60         <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
61 X-List-Received-Date: Fri, 05 Aug 2011 21:04:46 -0000\r
62 \r
63 --=-=-=\r
64 Content-Transfer-Encoding: quoted-printable\r
65 \r
66 On Fri, 05 Aug 2011 17:17:56 +0200, Daniel Schoepe <daniel.schoepe@googlema=\r
67 il.com> wrote:\r
68 > On Mon, 06 Jun 2011 18:32:41 +0200, Daniel Schoepe <daniel.schoepe@google=\r
69 mail.com> wrote:\r
70 > I've been using this patch for the past two months now and it has been\r
71 > working fine. Are there any more suggestions or criticisms about this?\r
72 \r
73 Hey, Daniel.  This is a really great patch.  I've been looking for this\r
74 functionality for a while.  Thanks for implementing it.\r
75 \r
76 Following this email I am sending a slightly-tweaked and signed-off\r
77 version of this patch that includes a couple of minor tweaks (diff\r
78 below).  The first tweak removes an errant white space, and the other\r
79 modifies the tag-retrieval command to use the "search --output=3Dtags"\r
80 command instead of the "search-tags" command which was recently\r
81 deprecated.\r
82 \r
83 jamie.\r
84 \r
85 diff --git a/emacs/notmuch.el b/emacs/notmuch.el\r
86 index e9b0ef8..053f0be 100644\r
87 =2D-- a/emacs/notmuch.el\r
88 +++ b/emacs/notmuch.el\r
89 @@ -882,12 +882,12 @@ characters as well as `_.+-'.\r
90 =20\r
91  PROMPT is the string to prompt with."\r
92    (lexical-let\r
93 =2D      ((completions=20\r
94 +      ((completions\r
95         (append (list "folder:" "thread:" "id:" "date:" "from:" "to:"\r
96                       "subject:" "attachment:")\r
97                 (mapcar (lambda (tag)\r
98                           (concat "tag:" tag))\r
99 =2D                       (process-lines "notmuch" "search-tags")))))\r
100 +                       (process-lines "notmuch" "search" "--output=3Dtags"=\r
101  "*")))))\r
102      (let ((keymap (copy-keymap minibuffer-local-map))\r
103           (minibuffer-completion-table\r
104            (completion-table-dynamic\r
105 \r
106 --=-=-=\r
107 Content-Type: application/pgp-signature\r
108 \r
109 -----BEGIN PGP SIGNATURE-----\r
110 Version: GnuPG v1.4.11 (GNU/Linux)\r
111 \r
112 iQIcBAEBCAAGBQJOPFnkAAoJEO00zqvie6q8UicP/375DYcR8hr4lIQAT50rrQ5M\r
113 BhJMTRznUR1sHDwnF30hkxknc0BnzDKRm+tt4QO2uEGJ0LSJjO0D4oFLqarlxl0O\r
114 9vsQxujhYC2DXlBXGjBwNoa0qGKiq+biB1ximJPer8dEA4S3TdruGIKqzrFHwR4Z\r
115 jvj/QMBdu52L/+CnnDJF37Pu36RX83FhOC8GMEYPdwS5RB+bNw90Zo6wfNg6Nz9F\r
116 ELf+BcuSLWkCkZXbR1qlqHDlwzgpOhd+yJX4aFKW2a3Vvtss4Q8rFtSJx7agm+eP\r
117 +Vg9lCvZu4koVl5Nb3pT+06my1kNRPYkhNQXEm2J7wkZubhrT+iHPWhT0vkgBWIf\r
118 sqdjRymBgtIWrM5P9wMWqoYEoI1HqjEy3R7MjzCixzRaaKO7/jIQdv+Aax+62JCK\r
119 +S+7Sl31Y0Zg5JzCrRJ9dIuf+qb6GwvJm9uDsZUx0Et47fjHr8hwLgyAf9J8uoQC\r
120 5tTKB21WD6MdmiyknLCpVH+5rGaWtdSpyrrFMIsJtkqtpzXT4FzlNy7nBYkl012S\r
121 9oGF02hjh6MmzDp2ISdOB8oeAggKr1VXEm6ZdGJUpXhyNnuVV1MdWPWwuK+LvT/w\r
122 6EGoYXvOyzyrvz1ekuxk8EEy64EnfizOytXGiQNfyo+DWPG1fSMJLutKDv908KXj\r
123 JxUZU8Q8i3paa9DCOTV1\r
124 =IHk0\r
125 -----END PGP SIGNATURE-----\r
126 --=-=-=--\r