1 Return-Path: <m.walters@qmul.ac.uk>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 78BCE429E41
\r
6 for <notmuch@notmuchmail.org>; Tue, 4 Nov 2014 01:15:25 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-1.098 tagged_above=-999 required=5
\r
12 tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001,
\r
13 NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled
\r
14 Received: from olra.theworths.org ([127.0.0.1])
\r
15 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
16 with ESMTP id UEusnN6X7nqL for <notmuch@notmuchmail.org>;
\r
17 Tue, 4 Nov 2014 01:15:21 -0800 (PST)
\r
18 Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6])
\r
19 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
\r
20 (No client certificate requested)
\r
21 by olra.theworths.org (Postfix) with ESMTPS id A4864429E40
\r
22 for <notmuch@notmuchmail.org>; Tue, 4 Nov 2014 01:15:21 -0800 (PST)
\r
23 Received: from smtp.qmul.ac.uk ([138.37.6.40])
\r
24 by mail2.qmul.ac.uk with esmtp (Exim 4.71)
\r
25 (envelope-from <m.walters@qmul.ac.uk>)
\r
26 id 1XlaCZ-0007k8-Bj; Tue, 04 Nov 2014 09:15:19 +0000
\r
27 Received: from 5751dfa2.skybroadband.com ([87.81.223.162] helo=localhost)
\r
28 by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.71)
\r
29 (envelope-from <m.walters@qmul.ac.uk>)
\r
30 id 1XlaCZ-0005JQ-0X; Tue, 04 Nov 2014 09:14:59 +0000
\r
31 From: Mark Walters <markwalters1009@gmail.com>
\r
32 To: Jani Nikula <jani@nikula.org>, Michal Sojka <sojkam1@fel.cvut.cz>
\r
33 Subject: Re: [RFC PATCH 0/2] cli: split 'notmuch address' from 'notmuch
\r
35 In-Reply-To: <cover.1414839970.git.jani@nikula.org>
\r
36 References: <87egtn2s4z.fsf@steelpick.2x.cz>
\r
37 <cover.1414839970.git.jani@nikula.org>
\r
38 User-Agent: Notmuch/0.18.1+86~gef5e66a (http://notmuchmail.org) Emacs/23.4.1
\r
39 (x86_64-pc-linux-gnu)
\r
40 Date: Tue, 04 Nov 2014 09:14:58 +0000
\r
41 Message-ID: <87r3xj2up9.fsf@qmul.ac.uk>
\r
43 Content-Type: text/plain; charset=us-ascii
\r
44 X-Sender-Host-Address: 87.81.223.162
\r
45 X-QM-Geographic: According to ripencc,
\r
46 this message was delivered by a machine in Britain (UK) (GB).
\r
47 X-QM-SPAM-Info: Sender has good ham record. :)
\r
48 X-QM-Body-MD5: e99114c32f0de8f8d0c575c1d5234595 (of first 20000 bytes)
\r
49 X-SpamAssassin-Score: -0.1
\r
50 X-SpamAssassin-SpamBar: /
\r
51 X-SpamAssassin-Report: The QM spam filters have analysed this message to
\r
53 spam. We require at least 5.0 points to mark a message as spam.
\r
54 This message scored -0.1 points.
\r
55 Summary of the scoring:
\r
56 * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail
\r
57 provider * (markwalters1009[at]gmail.com)
\r
58 * -0.1 AWL AWL: From: address is in the auto white-list
\r
59 X-QM-Scan-Virus: ClamAV says the message is clean
\r
60 Cc: notmuch@notmuchmail.org
\r
61 X-BeenThere: notmuch@notmuchmail.org
\r
62 X-Mailman-Version: 2.1.13
\r
64 List-Id: "Use and development of the notmuch mail system."
\r
65 <notmuch.notmuchmail.org>
\r
66 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
67 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
68 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
69 List-Post: <mailto:notmuch@notmuchmail.org>
\r
70 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
71 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
72 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
73 X-List-Received-Date: Tue, 04 Nov 2014 09:15:25 -0000
\r
76 On Sat, 01 Nov 2014, Jani Nikula <jani@nikula.org> wrote:
\r
77 > On Sat, 01 Nov 2014, Michal Sojka <sojkam1@fel.cvut.cz> wrote:
\r
78 >> On Sat, Nov 01 2014, Jani Nikula wrote:
\r
79 >>> On Fri, 31 Oct 2014, Michal Sojka <sojkam1@fel.cvut.cz> wrote:
\r
80 >>>> This option allows to configure the criterion for duplicate address
\r
81 >>>> filtering. Without this option, all unique combinations of name and
\r
82 >>>> address parts are printed. This option allows to filter the output
\r
83 >>>> more, for example to only contain unique address parts.
\r
85 >>> This patch finally makes me think we should have a separate 'notmuch
\r
86 >>> address' command for all of this. We are starting to have two orthogonal
\r
87 >>> sets of 'notmuch search' options, one set for search and another for
\r
88 >>> addresses. I regret not following the series and then making the
\r
89 >>> observation so late.
\r
91 >> To some extent it is true. The question is whether it would make sense
\r
92 >> for 'notmuch address' to have options like --offset and --limit.
\r
95 >> I can prepare a new patchset implementing 'notmuch address' over the
\r
96 >> weekend. It would be necessary to revert the last (or two) already
\r
97 >> merged patch. What do others think?
\r
99 > Here's a couple of draft patches to make the search/address command
\r
100 > split happen with minimal changes.
\r
102 > In my opinion the problem is primarily in the user interface;
\r
103 > notmuch-search man page is growing intimidating to the user. I also
\r
104 > think splitting the implementation completely would lead to too much
\r
105 > code duplication, as there is plenty of common code. The idea here is to
\r
106 > split the user interface for address searching now when we haven't made
\r
107 > a release with the functionality, and we can more easily change the code
\r
108 > behind the interface going forward. Plus we can more comfortably add
\r
109 > address management commands to 'notmuch address' than 'notmuch search'
\r
110 > as the need arises.
\r
112 > I do have to say in the end I'm also fine with having everything in the
\r
113 > notmuch search command if there's opposition to having two very similar,
\r
114 > even if diverging, commands.
\r
116 I like this change and have reviewed the large follow-up series. Would
\r
117 this make it easy to support the generic notmuch options after the
\r
118 command? In particular I often type/think notmuch search --help rather than
\r
119 notmuch --help search.
\r
135 > cli: add support for hierarchical command line option arrays
\r
136 > cli: add notmuch address command
\r
138 > command-line-arguments.c | 11 ++--
\r
139 > command-line-arguments.h | 1 +
\r
140 > notmuch-client.h | 3 ++
\r
141 > notmuch-search.c | 128 ++++++++++++++++++++++++++++++-----------------
\r
143 > 5 files changed, 95 insertions(+), 50 deletions(-)
\r
148 > _______________________________________________
\r
149 > notmuch mailing list
\r
150 > notmuch@notmuchmail.org
\r
151 > http://notmuchmail.org/mailman/listinfo/notmuch
\r