1 Return-Path: <glasse@cs.rpi.edu>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id B4842431FBC
\r
6 for <notmuch@notmuchmail.org>; Fri, 27 Jan 2012 10:19:43 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-0.54 tagged_above=-999 required=5
\r
12 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,
\r
13 RCVD_IN_BL_SPAMCOP_NET=1.246, RCVD_IN_DNSWL_MED=-2.3,
\r
14 RCVD_IN_SORBS_WEB=0.614] autolearn=disabled
\r
15 Received: from olra.theworths.org ([127.0.0.1])
\r
16 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
17 with ESMTP id 6z0MXmApR69f for <notmuch@notmuchmail.org>;
\r
18 Fri, 27 Jan 2012 10:19:43 -0800 (PST)
\r
19 Received: from cliffclavin.cs.rpi.edu (cliffclavin.cs.rpi.edu
\r
20 [128.113.126.25]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
\r
21 (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS
\r
22 id F3795431FAE for <notmuch@notmuchmail.org>; Fri, 27 Jan 2012 10:19:42 -0800
\r
24 X-Hash: SCtCte|aa3172f9bebf027dc1fd1da71bbc9c65535d1721|2496b17db9ee623b88d706c775242a92
\r
25 X-Countries: Cameroon, United States
\r
26 X-SMTP-From: accepted <glasse@cs.rpi.edu> [195.24.209.21] [195.24.209.21]
\r
27 ([10.0.13.172]) {Cameroon}
\r
28 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=cs.rpi.edu; h=
\r
29 message-id:date:from:mime-version:to:cc:subject:references
\r
30 :in-reply-to:content-type:content-transfer-encoding; s=default;
\r
31 i=glasse@cs.rpi.edu; t=1327688376; x=1328293176; l=1165; bh=VUA
\r
32 ICcnNUkSNKWMPCmp7o7v4dxM=; b=kXAVGN6iepKzgPGFQ2+EWsRWIWdmAIgvbAk
\r
33 saeQnnd5/MPagAzi9EFi5rIbemMC2x+VmAaRTVmLn/k4sVet4J6trP8QfqVRp6IK
\r
34 VPqUmo8BAa4c5Qb+fjFDHRlTZy+q7XjAKkwZgIK1W2rQQyqP554oS9dV8Qtd7HHe
\r
36 DomainKey-Signature: a=rsa-sha1; c=nofws; d=cs.rpi.edu; h=message-id
\r
37 :date:from:mime-version:to:cc:subject:references:in-reply-to
\r
38 :content-type:content-transfer-encoding; q=dns; s=default; b=KIR
\r
39 k5/TAfDi2Uhy2wlscof6WOQWEkk5z0viAL7e1srXgjVoDJeh9PCCmBhFCb81MP6k
\r
40 xsp05pDXSKcLgKJsMOczBxaK+oOH+qQ/8uHFafwBqWt57Ymlbw4EOvDmN132AfzL
\r
41 uT9agG4IMz3p1AFSkF6689hioe6ZOuVWqTjbUReY=
\r
42 X-Spam-Info: -2.7; ALL_TRUSTED,AWL,BAYES_00
\r
43 X-Spam-Scanned-By: cliffclavin.cs.rpi.edu using SpamAssassin 3.2.5 (hard limit
\r
45 Authentication-Results: cliffclavin.cs.rpi.edu;
\r
46 DKIM=neutral (none) header.from=glasse@cs.rpi.edu;
\r
48 Mechanism '?all' matched) smtp.mail=glasse@cs.rpi.edu
\r
49 X-Auth-Passed: cliffclavin.cs.rpi.edu:q0RIJ6qf057776 Auth:glasse
\r
50 X-Virus-Scanned-By: cliffclavin.cs.rpi.edu
\r
51 Received: from [10.0.13.172] ([195.24.209.21]) (authenticated bits=0)
\r
52 by cliffclavin.cs.rpi.edu (8.14.3/8.14.3) with ESMTP id q0RIJ6qf057776
\r
53 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);
\r
54 Fri, 27 Jan 2012 13:19:31 -0500 (EST)
\r
55 (envelope-from glasse@cs.rpi.edu)
\r
56 Message-ID: <4F22EA91.4020006@cs.rpi.edu>
\r
57 Date: Fri, 27 Jan 2012 13:18:57 -0500
\r
58 From: Ethan Glasser-Camp <glasse@cs.rpi.edu>
\r
59 User-Agent: Mozilla/5.0 (X11; Linux i686;
\r
60 rv:8.0) Gecko/20111124 Thunderbird/8.0
\r
62 To: Tomi Ollila <tomi.ollila@iki.fi>
\r
63 Subject: Re: [PATCH 1/2] moved _notmuch_get_list () and _notmuch_set_list
\r
65 References: <8762g0sj6f.fsf@praet.org>
\r
66 <1327572718-13411-1-git-send-email-tomi.ollila@iki.fi>
\r
67 <87sjj2ipjh.fsf@nikula.org> <m2d3a5juj0.fsf@guru.guru-group.fi>
\r
68 In-Reply-To: <m2d3a5juj0.fsf@guru.guru-group.fi>
\r
69 Content-Type: text/plain; charset=ISO-8859-1; format=flowed
\r
70 Content-Transfer-Encoding: 7bit
\r
71 X-Scanned-By: MIMEDefang 2.67 on 128.113.126.25
\r
72 Cc: notmuch@notmuchmail.org
\r
73 X-BeenThere: notmuch@notmuchmail.org
\r
74 X-Mailman-Version: 2.1.13
\r
76 List-Id: "Use and development of the notmuch mail system."
\r
77 <notmuch.notmuchmail.org>
\r
78 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
79 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
80 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
81 List-Post: <mailto:notmuch@notmuchmail.org>
\r
82 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
83 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
84 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
85 X-List-Received-Date: Fri, 27 Jan 2012 18:19:43 -0000
\r
87 On 01/27/2012 05:42 AM, Tomi Ollila wrote:
\r
88 > On Thu, 26 Jan 2012 13:03:46 +0000, Jani Nikula<jani@nikula.org> wrote:
\r
89 >> On Thu, 26 Jan 2012 12:11:57 +0200, Tomi Ollila<tomi.ollila@iki.fi> wrote:
\r
90 >>> Moved _notmuch_get_list () and _notmuch_set_list () to a location
\r
91 >>> in notmuch-config.c so that new functions that will be located
\r
92 >>> before the old location of those functions can also use these.
\r
95 >> You mean something along the lines of: "Move _notmuch_get_list () and
\r
96 >> _notmuch_set_list () earlier in the file to avoid forward declarations
\r
97 >> in further work. No functional changes."
\r
99 >> I'm sure native speakers can bikeshed that further. ;)
\r
100 > Ok, they haven't. I'n resubmit this alone with better commit
\r
101 > message -- I look the other after I have better time.
\r
103 As a native speaker, your new version is acceptable but I found "in
\r
104 further work" a little odd. (Depending on what you meant, I'd say "in
\r
105 upcoming patches".) The thing I found most confusing about the comment
\r
106 is that the functions aren't called _notmuch_get_list or
\r
107 _notmuch_set_list (instead they are _config_get_list and _config_set_list.)
\r