5e/01a1c4c1b61a58fe1c73442438d863659112c5

   1 Return-Path: <dmitry.kurochkin@gmail.com>\r
   2 X-Original-To: notmuch@notmuchmail.org\r
   3 Delivered-To: notmuch@notmuchmail.org\r
   4 Received: from localhost (localhost [127.0.0.1])\r
   5         by olra.theworths.org (Postfix) with ESMTP id A9079431FD0\r
   6         for <notmuch@notmuchmail.org>; Sun, 25 Dec 2011 15:36:25 -0800 (PST)\r
   7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
   8 X-Spam-Flag: NO\r
   9 X-Spam-Score: -0.799\r
  10 X-Spam-Level: \r
  11 X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5\r
  12         tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,\r
  13         FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
  14 Received: from olra.theworths.org ([127.0.0.1])\r
  15         by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
  16         with ESMTP id zeYeuXMykhuu for <notmuch@notmuchmail.org>;\r
  17         Sun, 25 Dec 2011 15:36:25 -0800 (PST)\r
  18 Received: from mail-wi0-f181.google.com (mail-wi0-f181.google.com\r
  19         [209.85.212.181]) (using TLSv1 with cipher RC4-SHA (128/128 bits))\r
  20         (No client certificate requested)\r
  21         by olra.theworths.org (Postfix) with ESMTPS id 15819431FB6\r
  22         for <notmuch@notmuchmail.org>; Sun, 25 Dec 2011 15:36:24 -0800 (PST)\r
  23 Received: by wibhq2 with SMTP id hq2so5050734wib.26\r
  24         for <notmuch@notmuchmail.org>; Sun, 25 Dec 2011 15:36:23 -0800 (PST)\r
  25 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;\r
  26         h=from:to:subject:in-reply-to:references:user-agent:date:message-id\r
  27         :mime-version:content-type;\r
  28         bh=Wur80pmWiZakLJUPXTyK3q0lXMboQMJ5oupFU2WW8ig=;\r
  29         b=cL5wH8Cbmfp/FPWgtcblpfQkPAeSVSTERdUMLE1nvHs9/gtB+kEphOMhqb7MDJSj57\r
  30         eJ0Q3y86YlhcDGW7uqlmQj/QousaOV7afNKUY95Wy60hhKUHiaRL5oX/ZKaDuzwHP8oQ\r
  31         z56w4uc+PIFckb/GNti39zFXCHEDBulPRrsfs=\r
  32 Received: by 10.180.85.4 with SMTP id d4mr49124650wiz.0.1324856183618;\r
  33         Sun, 25 Dec 2011 15:36:23 -0800 (PST)\r
  34 Received: from localhost ([91.144.186.21]) by mx.google.com with ESMTPS id\r
  35         en20sm52270246wid.10.2011.12.25.15.36.17\r
  36         (version=TLSv1/SSLv3 cipher=OTHER);\r
  37         Sun, 25 Dec 2011 15:36:18 -0800 (PST)\r
  38 From: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>\r
  39 To: Austin Clements <amdragon@MIT.EDU>, notmuch@notmuchmail.org\r
  40 Subject: Re: [PATCH v5 0/4] First step of 'show' rewrite\r
  41 In-Reply-To: <1324752766-29315-1-git-send-email-amdragon@mit.edu>\r
  42 References: <1324698348-27620-1-git-send-email-amdragon@mit.edu>\r
  43         <1324752766-29315-1-git-send-email-amdragon@mit.edu>\r
  44 User-Agent: Notmuch/0.10.2+116~g4c449d4 (http://notmuchmail.org) Emacs/23.3.1\r
  45         (x86_64-pc-linux-gnu)\r
  46 Date: Mon, 26 Dec 2011 03:35:32 +0400\r
  47 Message-ID: <87sjk81ayj.fsf@gmail.com>\r
  48 MIME-Version: 1.0\r
  49 Content-Type: text/plain; charset=us-ascii\r
  50 X-BeenThere: notmuch@notmuchmail.org\r
  51 X-Mailman-Version: 2.1.13\r
  52 Precedence: list\r
  53 List-Id: "Use and development of the notmuch mail system."\r
  54         <notmuch.notmuchmail.org>\r
  55 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
  56         <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
  57 List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
  58 List-Post: <mailto:notmuch@notmuchmail.org>\r
  59 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
  60 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
  61         <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
  62 X-List-Received-Date: Sun, 25 Dec 2011 23:36:25 -0000\r
  63 \r
  64 All looks good to me.  Let's push it.\r
  65 \r
  66 I have some minor comments, but they are all more of a style preference\r
  67 (e.g. sig_validity vs signature_validity, using conditional operator (x\r
  68 ? y : z) where possible).\r
  69 \r
  70 Regards,\r
  71   Dmitry\r