1 Return-Path: <dmitry.kurochkin@gmail.com>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id BA0E4429E42
\r
6 for <notmuch@notmuchmail.org>; Wed, 15 Feb 2012 15:27:26 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5
\r
12 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,
\r
13 FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
\r
14 Received: from olra.theworths.org ([127.0.0.1])
\r
15 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
16 with ESMTP id QcS-lYSpUVRY for <notmuch@notmuchmail.org>;
\r
17 Wed, 15 Feb 2012 15:27:23 -0800 (PST)
\r
18 Received: from mail-bk0-f53.google.com (mail-bk0-f53.google.com
\r
19 [209.85.214.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits))
\r
20 (No client certificate requested)
\r
21 by olra.theworths.org (Postfix) with ESMTPS id 17B4B431E62
\r
22 for <notmuch@notmuchmail.org>; Wed, 15 Feb 2012 15:27:22 -0800 (PST)
\r
23 Received: by bkcit16 with SMTP id it16so1589642bkc.26
\r
24 for <notmuch@notmuchmail.org>; Wed, 15 Feb 2012 15:27:20 -0800 (PST)
\r
25 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;
\r
26 h=from:to:subject:in-reply-to:references:user-agent:date:message-id
\r
27 :mime-version:content-type;
\r
28 bh=v8yMQBJXLgNSC79DkRZNJovacLh1u9B7lw/Dt+HsPJY=;
\r
29 b=mih0N9cSS453wQRXfy4ZFdHSEhydCih/T553vdRJ0KtmJYVRw1nYiOk5ZanctiNKq7
\r
30 9S+5lfvKYqjdr8MWKMtRpB7UgwrKll/sMln5DUTHGzRlqVn22h7bLv4EWsKn7tIPo+/+
\r
31 V4enhjVUlFwj75Xe0jfgBTw3MzjwVYbglFjLM=
\r
32 Received: by 10.205.127.147 with SMTP id ha19mr67794bkc.64.1329348440319;
\r
33 Wed, 15 Feb 2012 15:27:20 -0800 (PST)
\r
34 Received: from localhost ([91.144.186.21])
\r
35 by mx.google.com with ESMTPS id t17sm9317297bke.6.2012.02.15.15.27.19
\r
36 (version=TLSv1/SSLv3 cipher=OTHER);
\r
37 Wed, 15 Feb 2012 15:27:19 -0800 (PST)
\r
38 From: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>
\r
39 To: Michal Sojka <sojka@os.inf.tu-dresden.de>, notmuch@notmuchmail.org
\r
40 Subject: Re: [PATCH v2] emacs: Fix display of highlighted line in
\r
42 In-Reply-To: <87ehtvheig.fsf@steelpick.2x.cz>
\r
43 References: <87mx8lpd5o.fsf@nikula.org>
\r
44 <1329239387-6300-1-git-send-email-sojka@os.inf.tu-dresden.de>
\r
45 <87wr7ngand.fsf@gmail.com> <87ehtvheig.fsf@steelpick.2x.cz>
\r
46 User-Agent: Notmuch/0.11.1+188~ga5674c2 (http://notmuchmail.org) Emacs/23.3.1
\r
47 (x86_64-pc-linux-gnu)
\r
48 Date: Thu, 16 Feb 2012 03:25:59 +0400
\r
49 Message-ID: <87ty2rfzlk.fsf@gmail.com>
\r
51 Content-Type: text/plain; charset=us-ascii
\r
52 X-BeenThere: notmuch@notmuchmail.org
\r
53 X-Mailman-Version: 2.1.13
\r
55 List-Id: "Use and development of the notmuch mail system."
\r
56 <notmuch.notmuchmail.org>
\r
57 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
58 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
59 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
60 List-Post: <mailto:notmuch@notmuchmail.org>
\r
61 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
62 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
63 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
64 X-List-Received-Date: Wed, 15 Feb 2012 23:27:26 -0000
\r
66 On Thu, 16 Feb 2012 00:18:31 +0100, Michal Sojka <sojka@os.inf.tu-dresden.de> wrote:
\r
67 > On Wed, 15 Feb 2012, Dmitry Kurochkin wrote:
\r
70 > > On Tue, 14 Feb 2012 18:09:47 +0100, Michal Sojka <sojka@os.inf.tu-dresden.de> wrote:
\r
71 > > > When notmuch-search-line-faces is used to set background color in search
\r
72 > > > results, the highlight of the current line is not always displayed
\r
73 > > > correctly. This patch fixes that by increasing the priority property of
\r
74 > > > the highlight overlay.
\r
77 > > How about changing `notmuch-search-color-line' to use text properties
\r
78 > > instead of overlays? Then hl-line overlay would take priority over it
\r
79 > > without these changes.
\r
81 > > See [1] by David Edmondson on why text properties are better in
\r
82 > > general. I plan to use text properties here to simplify updating the
\r
83 > > face when tags are changed.
\r
85 > Hmm, I always wondered why notmuch uses overlays even if Elisp manual
\r
86 > says they don't scale. I remember that I wanted to replace that long
\r
87 > time ago, but there was some problem, which I forgot. Maybe it was the
\r
88 > invisibility David mentions. I guess there is some invisible text in
\r
89 > search output, isn't it?
\r
92 Yes. Also other faces (e.g. date, subject) are used in search. If we
\r
93 used properties in `notmuch-search-color-line', we would have to merge
\r
94 with other properties. So I take my proposal back.
\r