1 Return-Path: <aaronecay@gmail.com>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 42D74431FD0
\r
6 for <notmuch@notmuchmail.org>; Sat, 17 Dec 2011 07:47:55 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5
\r
12 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,
\r
13 FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
\r
14 Received: from olra.theworths.org ([127.0.0.1])
\r
15 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
16 with ESMTP id Et9VHlFXjDtD for <notmuch@notmuchmail.org>;
\r
17 Sat, 17 Dec 2011 07:47:54 -0800 (PST)
\r
18 Received: from mail-qw0-f46.google.com (mail-qw0-f46.google.com
\r
19 [209.85.216.46]) (using TLSv1 with cipher RC4-SHA (128/128 bits))
\r
20 (No client certificate requested)
\r
21 by olra.theworths.org (Postfix) with ESMTPS id 45681431FB6
\r
22 for <notmuch@notmuchmail.org>; Sat, 17 Dec 2011 07:47:54 -0800 (PST)
\r
23 Received: by qadc12 with SMTP id c12so1849870qad.5
\r
24 for <notmuch@notmuchmail.org>; Sat, 17 Dec 2011 07:47:53 -0800 (PST)
\r
25 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;
\r
26 h=from:to:subject:date:message-id:x-mailer;
\r
27 bh=z5zB12GkL9l/m6qPvlAucSvE8vF9+MTxaYlqD4R7p08=;
\r
28 b=hMtF6QqT+fJoJrrp5ShJyMB6v0/6tfHM+CAWoalWE+P8l29h6iNLzXzIKPniIzaw7L
\r
29 yNo/nhVfEoYA1cJ+7VFulh/IcoyFTBAkjNUH9YrNjFxW7L3n9ixAFAcuzkUYiApQIRG/
\r
30 K9cTY2FKy2M7w7OKB3rWfF8hmZFpNa20Mj8uk=
\r
31 Received: by 10.224.211.66 with SMTP id gn2mr17497303qab.14.1324136873630;
\r
32 Sat, 17 Dec 2011 07:47:53 -0800 (PST)
\r
33 Received: from localhost.localdomain (c-68-80-94-73.hsd1.pa.comcast.net.
\r
35 by mx.google.com with ESMTPS id r10sm27010545qaz.7.2011.12.17.07.47.52
\r
36 (version=TLSv1/SSLv3 cipher=OTHER);
\r
37 Sat, 17 Dec 2011 07:47:52 -0800 (PST)
\r
38 From: Aaron Ecay <aaronecay@gmail.com>
\r
39 To: notmuch@notmuchmail.org
\r
40 Subject: [PATCH] [emacs] Don't quote lambda forms
\r
41 Date: Sat, 17 Dec 2011 10:47:48 -0500
\r
42 Message-Id: <1324136868-6662-1-git-send-email-aaronecay@gmail.com>
\r
43 X-Mailer: git-send-email 1.7.8
\r
44 X-BeenThere: notmuch@notmuchmail.org
\r
45 X-Mailman-Version: 2.1.13
\r
47 List-Id: "Use and development of the notmuch mail system."
\r
48 <notmuch.notmuchmail.org>
\r
49 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
50 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
51 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
52 List-Post: <mailto:notmuch@notmuchmail.org>
\r
53 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
54 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
55 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
56 X-List-Received-Date: Sat, 17 Dec 2011 15:47:55 -0000
\r
58 This generates byte-compiler warnings on (at least) current trunk
\r
59 versions of Emacs. The quote is not necessary; lambda forms are
\r
62 emacs/notmuch-crypto.el | 4 +-
\r
63 emacs/notmuch-hello.el | 64 +++++++++++++++++++++---------------------
\r
64 emacs/notmuch-maildir-fcc.el | 12 ++++----
\r
65 emacs/notmuch-message.el | 8 ++--
\r
66 emacs/notmuch-show.el | 20 ++++++------
\r
67 emacs/notmuch.el | 20 ++++++------
\r
68 6 files changed, 64 insertions(+), 64 deletions(-)
\r
70 diff --git a/emacs/notmuch-crypto.el b/emacs/notmuch-crypto.el
\r
71 index 44fccae..8974af1 100644
\r
72 --- a/emacs/notmuch-crypto.el
\r
73 +++ b/emacs/notmuch-crypto.el
\r
74 @@ -63,7 +63,7 @@ mode."
\r
77 (define-button-type 'notmuch-crypto-status-button-type
\r
78 - 'action '(lambda (button) (message (button-get button 'help-echo)))
\r
79 + 'action (lambda (button) (message (button-get button 'help-echo)))
\r
81 'help-echo "Set notmuch-crypto-process-mime to process cryptographic mime parts.")
\r
83 @@ -72,7 +72,7 @@ mode."
\r
85 (label "Signature not processed")
\r
86 (face 'notmuch-crypto-signature-unknown)
\r
87 - (button-action '(lambda (button) (message (button-get button 'help-echo)))))
\r
88 + (button-action (lambda (button) (message (button-get button 'help-echo)))))
\r
90 ((string= status "good")
\r
91 (let ((fingerprint (concat "0x" (plist-get sigstatus :fingerprint))))
\r
92 diff --git a/emacs/notmuch-hello.el b/emacs/notmuch-hello.el
\r
93 index 0582cae..d0dcf97 100644
\r
94 --- a/emacs/notmuch-hello.el
\r
95 +++ b/emacs/notmuch-hello.el
\r
96 @@ -331,8 +331,8 @@ should be. Returns a cons cell `(tags-per-line width)'."
\r
97 (defvar notmuch-hello-mode-map
\r
98 (let ((map (make-sparse-keymap)))
\r
99 (set-keymap-parent map widget-keymap)
\r
100 - (define-key map "v" '(lambda () "Display the notmuch version" (interactive)
\r
101 - (message "notmuch version %s" (notmuch-version))))
\r
102 + (define-key map "v" (lambda () "Display the notmuch version" (interactive)
\r
103 + (message "notmuch version %s" (notmuch-version))))
\r
104 (define-key map "?" 'notmuch-help)
\r
105 (define-key map "q" 'notmuch-kill-this-buffer)
\r
106 (define-key map "=" 'notmuch-hello-update)
\r
107 @@ -502,36 +502,36 @@ Complete list of currently available key bindings:
\r
108 (widget-insert "\n\n")
\r
109 (let ((start (point))
\r
111 - (mapc '(lambda (search)
\r
112 - (let ((widget-symbol (intern (format "notmuch-hello-search-%d" nth))))
\r
113 - (set widget-symbol
\r
114 - (widget-create 'editable-field
\r
115 - ;; Don't let the search boxes be
\r
116 - ;; less than 8 characters wide.
\r
118 - (- (window-width)
\r
119 - ;; Leave some space
\r
120 - ;; at the start and
\r
123 - (* 2 notmuch-hello-indent)
\r
124 - ;; 1 for the space
\r
126 - ;; `[save]' button. 6
\r
127 - ;; for the `[save]'
\r
130 - :action (lambda (widget &rest ignore)
\r
131 - (notmuch-hello-search (widget-value widget)))
\r
133 - (widget-insert " ")
\r
134 - (widget-create 'push-button
\r
135 - :notify (lambda (widget &rest ignore)
\r
136 - (notmuch-hello-add-saved-search widget))
\r
137 - :notmuch-saved-search-widget widget-symbol
\r
139 - (widget-insert "\n")
\r
140 - (setq nth (1+ nth)))
\r
141 + (mapc (lambda (search)
\r
142 + (let ((widget-symbol (intern (format "notmuch-hello-search-%d" nth))))
\r
143 + (set widget-symbol
\r
144 + (widget-create 'editable-field
\r
145 + ;; Don't let the search boxes be
\r
146 + ;; less than 8 characters wide.
\r
148 + (- (window-width)
\r
149 + ;; Leave some space
\r
150 + ;; at the start and
\r
153 + (* 2 notmuch-hello-indent)
\r
154 + ;; 1 for the space
\r
156 + ;; `[save]' button. 6
\r
157 + ;; for the `[save]'
\r
160 + :action (lambda (widget &rest ignore)
\r
161 + (notmuch-hello-search (widget-value widget)))
\r
163 + (widget-insert " ")
\r
164 + (widget-create 'push-button
\r
165 + :notify (lambda (widget &rest ignore)
\r
166 + (notmuch-hello-add-saved-search widget))
\r
167 + :notmuch-saved-search-widget widget-symbol
\r
169 + (widget-insert "\n")
\r
170 + (setq nth (1+ nth)))
\r
171 notmuch-hello-recent-searches)
\r
172 (indent-rigidly start (point) notmuch-hello-indent)))
\r
174 diff --git a/emacs/notmuch-maildir-fcc.el b/emacs/notmuch-maildir-fcc.el
\r
175 index e678868..6fbf82d 100644
\r
176 --- a/emacs/notmuch-maildir-fcc.el
\r
177 +++ b/emacs/notmuch-maildir-fcc.el
\r
178 @@ -65,8 +65,8 @@ yet when sending a mail."
\r
179 ;; Set up the message-fcc-handler to move mails to the maildir in Fcc
\r
180 ;; The parameter is set to mark messages as "seen"
\r
181 (setq message-fcc-handler-function
\r
182 - '(lambda (destdir)
\r
183 - (notmuch-maildir-fcc-write-buffer-to-maildir destdir t)))
\r
184 + (lambda (destdir)
\r
185 + (notmuch-maildir-fcc-write-buffer-to-maildir destdir t)))
\r
186 ;; add a hook to actually insert the Fcc header when sending
\r
187 (add-hook 'message-header-setup-hook 'notmuch-fcc-header-setup))
\r
189 @@ -131,10 +131,10 @@ will NOT be removed or replaced."
\r
191 (defun notmuch-maildir-fcc-host-fixer (hostname)
\r
192 (replace-regexp-in-string "/\\|:"
\r
194 - (cond ((string-equal s "/") "\\057")
\r
195 - ((string-equal s ":") "\\072")
\r
198 + (cond ((string-equal s "/") "\\057")
\r
199 + ((string-equal s ":") "\\072")
\r
204 diff --git a/emacs/notmuch-message.el b/emacs/notmuch-message.el
\r
205 index aefd3fb..08e5b17 100644
\r
206 --- a/emacs/notmuch-message.el
\r
207 +++ b/emacs/notmuch-message.el
\r
208 @@ -39,10 +39,10 @@ the \"inbox\" and \"todo\", you would set
\r
209 (when (and notmuch-message-replied-tags rep)
\r
210 ;; add a "+" to any tag that is doesn't already begin with a "+"
\r
212 - (let ((tags (mapcar '(lambda (str)
\r
213 - (if (not (string-match "^[+-]" str))
\r
216 + (let ((tags (mapcar (lambda (str)
\r
217 + (if (not (string-match "^[+-]" str))
\r
220 notmuch-message-replied-tags)))
\r
221 (apply 'notmuch-tag (concat "id:" (car (car rep))) tags)))))
\r
223 diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
\r
224 index d7fbbca..bbad094 100644
\r
225 --- a/emacs/notmuch-show.el
\r
226 +++ b/emacs/notmuch-show.el
\r
227 @@ -265,12 +265,12 @@ message at DEPTH in the current thread."
\r
228 (defun notmuch-show-insert-headers (headers)
\r
229 "Insert the headers of the current message."
\r
230 (let ((start (point)))
\r
231 - (mapc '(lambda (header)
\r
232 - (let* ((header-symbol (intern (concat ":" header)))
\r
233 - (header-value (plist-get headers header-symbol)))
\r
234 - (if (and header-value
\r
235 - (not (string-equal "" header-value)))
\r
236 - (notmuch-show-insert-header header header-value))))
\r
237 + (mapc (lambda (header)
\r
238 + (let* ((header-symbol (intern (concat ":" header)))
\r
239 + (header-value (plist-get headers header-symbol)))
\r
240 + (if (and header-value
\r
241 + (not (string-equal "" header-value)))
\r
242 + (notmuch-show-insert-header header header-value))))
\r
243 notmuch-message-headers)
\r
246 @@ -344,7 +344,7 @@ current buffer, if possible."
\r
249 (defun notmuch-show-multipart/*-to-list (part)
\r
250 - (mapcar '(lambda (inner-part) (plist-get inner-part :content-type))
\r
251 + (mapcar (lambda (inner-part) (plist-get inner-part :content-type))
\r
252 (plist-get part :content)))
\r
254 (defun notmuch-show-multipart/alternative-choose (types)
\r
255 @@ -667,7 +667,7 @@ current buffer, if possible."
\r
257 (defun notmuch-show-insert-body (msg body depth)
\r
258 "Insert the body BODY at depth DEPTH in the current thread."
\r
259 - (mapc '(lambda (part) (notmuch-show-insert-bodypart msg part depth)) body))
\r
260 + (mapc (lambda (part) (notmuch-show-insert-bodypart msg part depth)) body))
\r
262 (defun notmuch-show-make-symbol (type)
\r
263 (make-symbol (concat "notmuch-show-" type)))
\r
264 @@ -785,11 +785,11 @@ current buffer, if possible."
\r
266 (defun notmuch-show-insert-thread (thread depth)
\r
267 "Insert the thread THREAD at depth DEPTH in the current forest."
\r
268 - (mapc '(lambda (tree) (notmuch-show-insert-tree tree depth)) thread))
\r
269 + (mapc (lambda (tree) (notmuch-show-insert-tree tree depth)) thread))
\r
271 (defun notmuch-show-insert-forest (forest)
\r
272 "Insert the forest of threads FOREST."
\r
273 - (mapc '(lambda (thread) (notmuch-show-insert-thread thread 0)) forest))
\r
274 + (mapc (lambda (thread) (notmuch-show-insert-thread thread 0)) forest))
\r
276 (defvar notmuch-show-thread-id nil)
\r
277 (make-variable-buffer-local 'notmuch-show-thread-id)
\r
278 diff --git a/emacs/notmuch.el b/emacs/notmuch.el
\r
279 index 8936149..6bf4a08 100644
\r
280 --- a/emacs/notmuch.el
\r
281 +++ b/emacs/notmuch.el
\r
282 @@ -662,16 +662,16 @@ foreground and blue background."
\r
283 ;; Create the overlay only if the message has tags which match one
\r
284 ;; of those specified in `notmuch-search-line-faces'.
\r
286 - (mapc '(lambda (elem)
\r
287 - (let ((tag (car elem))
\r
288 - (attributes (cdr elem)))
\r
289 - (when (member tag line-tag-list)
\r
290 - (when (not overlay)
\r
291 - (setq overlay (make-overlay start end)))
\r
292 - ;; Merge the specified properties with any already
\r
293 - ;; applied from an earlier match.
\r
294 - (overlay-put overlay 'face
\r
295 - (append (overlay-get overlay 'face) attributes)))))
\r
296 + (mapc (lambda (elem)
\r
297 + (let ((tag (car elem))
\r
298 + (attributes (cdr elem)))
\r
299 + (when (member tag line-tag-list)
\r
300 + (when (not overlay)
\r
301 + (setq overlay (make-overlay start end)))
\r
302 + ;; Merge the specified properties with any already
\r
303 + ;; applied from an earlier match.
\r
304 + (overlay-put overlay 'face
\r
305 + (append (overlay-get overlay 'face) attributes)))))
\r
306 notmuch-search-line-faces)))
\r
308 (defun notmuch-search-author-propertize (authors)
\r
projects / notmuch-archives.git / blob