1 Return-Path: <jani@nikula.org>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 33CEA431FBC
\r
6 for <notmuch@notmuchmail.org>; Fri, 1 Nov 2013 16:20:07 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-0.699 tagged_above=-999 required=5
\r
12 tests=[HTML_MESSAGE=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id l8r6uJ6xJl7P for <notmuch@notmuchmail.org>;
\r
16 Fri, 1 Nov 2013 16:20:01 -0700 (PDT)
\r
17 Received: from mail-vb0-f47.google.com (mail-vb0-f47.google.com
\r
18 [209.85.212.47]) (using TLSv1 with cipher RC4-SHA (128/128 bits))
\r
19 (No client certificate requested)
\r
20 by olra.theworths.org (Postfix) with ESMTPS id 44AF0431FAF
\r
21 for <notmuch@notmuchmail.org>; Fri, 1 Nov 2013 16:20:01 -0700 (PDT)
\r
22 Received: by mail-vb0-f47.google.com with SMTP id m10so105785vbh.34
\r
23 for <notmuch@notmuchmail.org>; Fri, 01 Nov 2013 16:20:00 -0700 (PDT)
\r
24 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
\r
25 d=1e100.net; s=20130820;
\r
26 h=x-gm-message-state:mime-version:in-reply-to:references:date
\r
27 :message-id:subject:from:to:cc:content-type;
\r
28 bh=raP2CEcFwp3CkjnM/qO1ihboDBd6YREHtlSzbvF5NpI=;
\r
29 b=PjyXd3lZDl6hVElO/dm7FPm4Tyz3eZlMV3mw6CEOEAfhDRVU0ckUVE+jgBDC3LuSBa
\r
30 ncTBJRTPzLQ4NxWprtHpXoagV0RsMDWqQj0CouAeUhs8QeOIgROAmkIk0UeF7CitjLa+
\r
31 FvZLg/irE41vffnKxYwdT1ZBN+CllAHcN9cGNgDq/pJruXO2rV7OCHhGzEMyy8Shq32S
\r
32 oXDdD91Fwvx2LMd0OBriHIJyOb5/lEEYk4JtxyY8obUHNUoqWhQRj28CtvWldDuZfjx3
\r
33 Pxsm8KXh4SdD73YFyQj4OicydxlUYopue5wEDCn36pcHXd1IyPeRFtzHUE5kmkNsF6Ig
\r
36 ALoCoQkVOR3JI9L7A7udbBuWf8nC6hskSfBjfoZ5doAF3wO6/wOYJzNgCuCnLSnP+HqnCBkMg86Q
\r
38 X-Received: by 10.52.103.100 with SMTP id fv4mr704912vdb.55.1383347998643;
\r
39 Fri, 01 Nov 2013 16:19:58 -0700 (PDT)
\r
40 Received: by 10.58.96.20 with HTTP; Fri, 1 Nov 2013 16:19:58 -0700 (PDT)
\r
41 Received: by 10.58.96.20 with HTTP; Fri, 1 Nov 2013 16:19:58 -0700 (PDT)
\r
42 In-Reply-To: <1383347716-5375-1-git-send-email-david@tethera.net>
\r
44 <2a58adbdc1257f16579692544b4bcbadca3d3045.1383315568.git.jani@nikula.org>
\r
45 <1383347716-5375-1-git-send-email-david@tethera.net>
\r
46 Date: Sat, 2 Nov 2013 01:19:58 +0200
\r
48 <CAB+hUn8+PB+Y3C1bZediJCL4DvPx+shyCyCndaFEnxOSHHi9sA@mail.gmail.com>
\r
49 Subject: Re: [PATCH] lib: update documentation of callback functions for
\r
50 database_compact and database_upgrade.
\r
51 From: Jani Nikula <jani@nikula.org>
\r
52 To: David Bremner <david@tethera.net>
\r
53 Content-Type: multipart/alternative; boundary=047d7bacba9a0f6fd804ea25ce96
\r
54 Cc: Notmuch Mail <notmuch@notmuchmail.org>, David Bremner <bremner@debian.org>
\r
55 X-BeenThere: notmuch@notmuchmail.org
\r
56 X-Mailman-Version: 2.1.13
\r
58 List-Id: "Use and development of the notmuch mail system."
\r
59 <notmuch.notmuchmail.org>
\r
60 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
61 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
62 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
63 List-Post: <mailto:notmuch@notmuchmail.org>
\r
64 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
65 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
66 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
67 X-List-Received-Date: Fri, 01 Nov 2013 23:20:07 -0000
\r
69 --047d7bacba9a0f6fd804ea25ce96
\r
70 Content-Type: text/plain; charset=UTF-8
\r
72 The point was, we can do this *now* without soname bumps, because we
\r
73 haven't released this yet.
\r
74 On Nov 2, 2013 1:16 AM, <david@tethera.net> wrote:
\r
76 > From: David Bremner <bremner@debian.org>
\r
78 > Compact was missing callback documentation entirely, and upgrade did not
\r
80 > closure parameter.
\r
82 > This patch depends on
\r
85 > id:2a58adbdc1257f16579692544b4bcbadca3d3045.1383315568.git.jani@nikula.org
\r
87 > BTW, I didn't completely understand the remark about SONAME bumps;
\r
88 > since we're providing new symbols, it doesn't really matter what the
\r
91 > lib/notmuch.h | 6 +++++-
\r
92 > 1 file changed, 5 insertions(+), 1 deletion(-)
\r
94 > diff --git a/lib/notmuch.h b/lib/notmuch.h
\r
95 > index cd301a4..82fd599 100644
\r
96 > --- a/lib/notmuch.h
\r
97 > +++ b/lib/notmuch.h
\r
98 > @@ -227,6 +227,9 @@ typedef void (*notmuch_compact_status_cb_t)(const char
\r
99 > *message, void *closure);
\r
100 > * The database will be opened with NOTMUCH_DATABASE_MODE_READ_WRITE
\r
101 > * during the compaction process to ensure no writes are made.
\r
103 > + * If the optional callback function 'status_cb' is non-NULL, it will
\r
104 > + * be called with diagnostic and informational messages. The argument
\r
105 > + * 'closure' is passed verbatim to any callback invoked.
\r
108 > notmuch_database_compact (const char* path,
\r
109 > @@ -270,7 +273,8 @@ notmuch_database_needs_upgrade (notmuch_database_t
\r
111 > * provide progress indication to the user. If non-NULL it will be
\r
112 > * called periodically with 'progress' as a floating-point value in
\r
113 > * the range of [0.0 .. 1.0] indicating the progress made so far in
\r
114 > - * the upgrade process.
\r
115 > + * the upgrade process. The argument 'closure' is passed verbatim to
\r
116 > + * any callback invoked.
\r
119 > notmuch_database_upgrade (notmuch_database_t *database,
\r
123 > _______________________________________________
\r
124 > notmuch mailing list
\r
125 > notmuch@notmuchmail.org
\r
126 > http://notmuchmail.org/mailman/listinfo/notmuch
\r
129 --047d7bacba9a0f6fd804ea25ce96
\r
130 Content-Type: text/html; charset=UTF-8
\r
131 Content-Transfer-Encoding: quoted-printable
\r
133 <p dir=3D"ltr">The point was, we can do this *now* without soname bumps, be=
\r
134 cause we haven't released this yet.<br>
\r
136 <div class=3D"gmail_quote">On Nov 2, 2013 1:16 AM, <<a href=3D"mailto:d=
\r
137 avid@tethera.net">david@tethera.net</a>> wrote:<br type=3D"attribution">=
\r
138 <blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1p=
\r
139 x #ccc solid;padding-left:1ex">
\r
140 From: David Bremner <<a href=3D"mailto:bremner@debian.org">bremner@debia=
\r
143 Compact was missing callback documentation entirely, and upgrade did not di=
\r
145 closure parameter.<br>
\r
147 This patch depends on<br>
\r
149 =C2=A0 =C2=A0 =C2=A0<a href=3D"mailto:id%3A2a58adbdc1257f16579692544b4bcbad=
\r
150 ca3d3045.1383315568.git.jani@nikula.org">id:2a58adbdc1257f16579692544b4bcba=
\r
151 dca3d3045.1383315568.git.jani@nikula.org</a><br>
\r
153 BTW, I didn't completely understand the remark about SONAME bumps;<br>
\r
154 since we're providing new symbols, it doesn't really matter what th=
\r
158 =C2=A0lib/notmuch.h | 6 +++++-<br>
\r
159 =C2=A01 file changed, 5 insertions(+), 1 deletion(-)<br>
\r
161 diff --git a/lib/notmuch.h b/lib/notmuch.h<br>
\r
162 index cd301a4..82fd599 100644<br>
\r
163 --- a/lib/notmuch.h<br>
\r
164 +++ b/lib/notmuch.h<br>
\r
165 @@ -227,6 +227,9 @@ typedef void (*notmuch_compact_status_cb_t)(const char =
\r
166 *message, void *closure);<br>
\r
167 =C2=A0 * The database will be opened with NOTMUCH_DATABASE_MODE_READ_WRITE<=
\r
169 =C2=A0 * during the compaction process to ensure no writes are made.<br>
\r
171 + * If the optional callback function 'status_cb' is non-NULL, it w=
\r
173 + * be called with diagnostic and informational messages. The argument<br>
\r
174 + * 'closure' is passed verbatim to any callback invoked.<br>
\r
176 =C2=A0notmuch_status_t<br>
\r
177 =C2=A0notmuch_database_compact (const char* path,<br>
\r
178 @@ -270,7 +273,8 @@ notmuch_database_needs_upgrade (notmuch_database_t *dat=
\r
180 =C2=A0 * provide progress indication to the user. If non-NULL it will be<br=
\r
182 =C2=A0 * called periodically with 'progress' as a floating-point va=
\r
184 =C2=A0 * the range of [0.0 .. 1.0] indicating the progress made so far in<b=
\r
186 - * the upgrade process.<br>
\r
187 + * the upgrade process. =C2=A0The argument 'closure' is passed ver=
\r
189 + * any callback invoked.<br>
\r
191 =C2=A0notmuch_status_t<br>
\r
192 =C2=A0notmuch_database_upgrade (notmuch_database_t *database,<br>
\r
196 _______________________________________________<br>
\r
197 notmuch mailing list<br>
\r
198 <a href=3D"mailto:notmuch@notmuchmail.org">notmuch@notmuchmail.org</a><br>
\r
199 <a href=3D"http://notmuchmail.org/mailman/listinfo/notmuch" target=3D"_blan=
\r
200 k">http://notmuchmail.org/mailman/listinfo/notmuch</a><br>
\r
201 </blockquote></div>
\r
203 --047d7bacba9a0f6fd804ea25ce96--
\r