1 Return-Path: <dmitry.kurochkin@gmail.com>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 7E090431FD0
\r
6 for <notmuch@notmuchmail.org>; Wed, 21 Dec 2011 13:55:07 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5
\r
12 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,
\r
13 FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
\r
14 Received: from olra.theworths.org ([127.0.0.1])
\r
15 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
16 with ESMTP id duJsdLOqoJSd for <notmuch@notmuchmail.org>;
\r
17 Wed, 21 Dec 2011 13:55:06 -0800 (PST)
\r
18 Received: from mail-ww0-f45.google.com (mail-ww0-f45.google.com
\r
19 [74.125.82.45]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client
\r
20 certificate requested) by olra.theworths.org (Postfix) with ESMTPS id
\r
21 A9703431FB6 for <notmuch@notmuchmail.org>; Wed, 21 Dec 2011 13:55:06 -0800
\r
23 Received: by wgbds13 with SMTP id ds13so12229044wgb.2
\r
24 for <notmuch@notmuchmail.org>; Wed, 21 Dec 2011 13:55:05 -0800 (PST)
\r
25 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;
\r
26 h=from:to:subject:in-reply-to:references:user-agent:date:message-id
\r
27 :mime-version:content-type;
\r
28 bh=RFUTtbzEt2yx6ogxiUB9XxNCI4cHX0MDbkk/7W+O7PU=;
\r
29 b=YQYxZBJ1zbTHY2kgO5IPTc1gqMcmRPE4PjDBCrMLVIA64rxcFKrMgq8MEB79V8bykW
\r
30 43LDT6FvpXULwp02onAiG4Wf0LLu5VWtX9e1j80CG8WG+k5og/piRfI05mmWyKrmL98w
\r
31 zlQifkPfHxfzMN9xaSYvV9g89JC0Gm2aLTl/c=
\r
32 Received: by 10.227.208.133 with SMTP id gc5mr7860916wbb.25.1324504505410;
\r
33 Wed, 21 Dec 2011 13:55:05 -0800 (PST)
\r
34 Received: from localhost ([91.144.186.21])
\r
35 by mx.google.com with ESMTPS id di5sm16841618wib.3.2011.12.21.13.55.04
\r
36 (version=TLSv1/SSLv3 cipher=OTHER);
\r
37 Wed, 21 Dec 2011 13:55:04 -0800 (PST)
\r
38 From: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>
\r
39 To: Thomas Jost <schnouki@schnouki.net>, notmuch@notmuchmail.org
\r
40 Subject: Re: [PATCH 2/2] test: add test for `notmuch-hello-refresh-hook'
\r
41 In-Reply-To: <87ipl9k33a.fsf@schnouki.net>
\r
42 References: <1324491506-1134-1-git-send-email-dmitry.kurochkin@gmail.com>
\r
43 <1324491506-1134-2-git-send-email-dmitry.kurochkin@gmail.com>
\r
44 <87ipl9k33a.fsf@schnouki.net>
\r
45 User-Agent: Notmuch/0.10.2+116~ga89e197 (http://notmuchmail.org) Emacs/23.3.1
\r
46 (x86_64-pc-linux-gnu)
\r
47 Date: Thu, 22 Dec 2011 01:54:21 +0400
\r
48 Message-ID: <87d3bh7fqq.fsf@gmail.com>
\r
50 Content-Type: text/plain; charset=us-ascii
\r
51 X-BeenThere: notmuch@notmuchmail.org
\r
52 X-Mailman-Version: 2.1.13
\r
54 List-Id: "Use and development of the notmuch mail system."
\r
55 <notmuch.notmuchmail.org>
\r
56 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
57 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
58 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
59 List-Post: <mailto:notmuch@notmuchmail.org>
\r
60 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
61 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
62 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
63 X-List-Received-Date: Wed, 21 Dec 2011 21:55:07 -0000
\r
65 On Wed, 21 Dec 2011 22:49:13 +0100, Thomas Jost <schnouki@schnouki.net> wrote:
\r
66 > On Wed, 21 Dec 2011 22:18:26 +0400, Dmitry Kurochkin <dmitry.kurochkin@gmail.com> wrote:
\r
67 > > Test that `notmuch-hello-refresh-hook' is called once when
\r
68 > > `notmuch-hello' is called and twice when calling
\r
69 > > `notmuch-hello-update' after that.
\r
71 > > The tests are very similar to tests for `notmuch-hello-mode-hook'.
\r
73 > Quite nice, better than what I sent earlier [1] :)
\r
75 > However I'm not sure that notmuch-hello.el is the right place for this
\r
76 > kind of stuff; notmuch-lib.el may be better (so that it can also be used
\r
80 These patches do not touch notmuch-hello.el. The functions are added to
\r
89 > [1] id:"1324473189-8622-1-git-send-email-schnouki@schnouki.net"
\r
93 > > test/emacs | 19 +++++++++++++++++++
\r
94 > > test/test-lib.el | 1 +
\r
95 > > 2 files changed, 20 insertions(+), 0 deletions(-)
\r
97 > > diff --git a/test/emacs b/test/emacs
\r
98 > > index dffad0f..ca82445 100755
\r
99 > > --- a/test/emacs
\r
100 > > +++ b/test/emacs
\r
101 > > @@ -495,4 +495,23 @@ counter=$(test_emacs \
\r
103 > > test_expect_equal "$counter" 1
\r
105 > > +test_begin_subtest "notmuch-hello-refresh hook is called"
\r
106 > > +counter=$(test_emacs \
\r
107 > > + '(let ((notmuch-hello-refresh-hook-counter 0))
\r
108 > > + (kill-buffer "*notmuch-hello*")
\r
109 > > + (notmuch-hello)
\r
110 > > + notmuch-hello-refresh-hook-counter)'
\r
112 > > +test_expect_equal "$counter" 1
\r
114 > > +test_begin_subtest "notmuch-hello-refresh hook is called on updates"
\r
115 > > +counter=$(test_emacs \
\r
116 > > + '(let ((notmuch-hello-refresh-hook-counter 0))
\r
117 > > + (kill-buffer "*notmuch-hello*")
\r
118 > > + (notmuch-hello)
\r
119 > > + (notmuch-hello-update)
\r
120 > > + notmuch-hello-refresh-hook-counter)'
\r
122 > > +test_expect_equal "$counter" 2
\r
125 > > diff --git a/test/test-lib.el b/test/test-lib.el
\r
126 > > index 83b8a65..3b817c3 100644
\r
127 > > --- a/test/test-lib.el
\r
128 > > +++ b/test/test-lib.el
\r
129 > > @@ -75,3 +75,4 @@ nothing."
\r
130 > > (add-hook hook (apply-partially 'hook-counter hook)))
\r
132 > > (add-hook-counter 'notmuch-hello-mode-hook)
\r
133 > > +(add-hook-counter 'notmuch-hello-refresh-hook)
\r
137 > > _______________________________________________
\r
138 > > notmuch mailing list
\r
139 > > notmuch@notmuchmail.org
\r
140 > > http://notmuchmail.org/mailman/listinfo/notmuch
\r