1 Return-Path: <polatel@gmail.com>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 13ED5431FBC
\r
6 for <notmuch@notmuchmail.org>; Wed, 13 Jan 2010 05:11:48 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=0.323 tagged_above=-999 required=5 tests=[AWL=-0.297,
\r
12 BAYES_50=0.001, RCVD_IN_SORBS_WEB=0.619] autolearn=no
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id nPqamiVpGnGw for <notmuch@notmuchmail.org>;
\r
16 Wed, 13 Jan 2010 05:11:47 -0800 (PST)
\r
17 Received: from mail-ew0-f220.google.com (mail-ew0-f220.google.com
\r
19 by olra.theworths.org (Postfix) with ESMTP id 6F896431FAE
\r
20 for <notmuch@notmuchmail.org>; Wed, 13 Jan 2010 05:11:47 -0800 (PST)
\r
21 Received: by ewy20 with SMTP id 20so3790087ewy.0
\r
22 for <notmuch@notmuchmail.org>; Wed, 13 Jan 2010 05:11:46 -0800 (PST)
\r
23 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;
\r
24 h=domainkey-signature:received:received:sender:date:from:to:cc
\r
25 :subject:message-id:references:mime-version:content-type
\r
26 :content-disposition:in-reply-to:user-agent;
\r
27 bh=xQYpPRlBGs360YF8YIWWOq5GYtauUj1BRiF4ZNT717k=;
\r
28 b=rgLTeli+kK4S4f/zCs9pkq93bD6LdlfWcD+HFMEgQMLMzTIImF0N+0tl2yJRPWpTLK
\r
29 Sosm7rR6gX5RmgIV4DOnK6fPTyL6OjhGeJVD8+mHxRcP5jBZ6dDUAnpeQGyXlnvDsgwu
\r
30 LYHVTFJGf+Bz03w9c4aduaPdv0VV7iXa4ksdo=
\r
31 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma;
\r
32 h=sender:date:from:to:cc:subject:message-id:references:mime-version
\r
33 :content-type:content-disposition:in-reply-to:user-agent;
\r
34 b=bpVwfpX+JQCeOAT5JqK1LbyjiNWCERP9EpjmAjopdSunU4KSEai18IkvASeQDqH02P
\r
35 cg/4gBqw3G9hRsgs+ElvEk+mUB3Xv3T2bgeDmDHY10eqZzUC5DgRipe8CARm3+9wDH2D
\r
36 fUVOEEaeawNBY6zcvlHQl5IuUFiEsM1oSSQhw=
\r
37 Received: by 10.213.109.146 with SMTP id j18mr1138573ebp.32.1263388306368;
\r
38 Wed, 13 Jan 2010 05:11:46 -0800 (PST)
\r
39 Received: from harikalardiyari ([78.179.54.193])
\r
40 by mx.google.com with ESMTPS id 7sm5102520eyg.9.2010.01.13.05.11.44
\r
41 (version=TLSv1/SSLv3 cipher=RC4-MD5);
\r
42 Wed, 13 Jan 2010 05:11:44 -0800 (PST)
\r
43 Sender: Ali Polatel <polatel@gmail.com>
\r
44 Date: Wed, 13 Jan 2010 15:11:27 +0200
\r
45 From: Ali Polatel <alip@exherbo.org>
\r
46 To: Fernando Carrijo <fcarrijo@yahoo.com.br>
\r
47 Message-ID: <20100113131127.GA14681@harikalardiyari>
\r
49 <cd1ed7d2c2ea5a9f7da351b5916253708b65feb5.1263377759.git.alip@exherbo.org>
\r
50 <874omq6up2.fsf@yahoo.com.br>
\r
52 Content-Type: multipart/signed; micalg=pgp-sha1;
\r
53 protocol="application/pgp-signature"; boundary="M9NhX3UHpAaciwkO"
\r
54 Content-Disposition: inline
\r
55 In-Reply-To: <874omq6up2.fsf@yahoo.com.br>
\r
56 User-Agent: Mutt/1.5.20 (2009-06-14)
\r
57 Cc: notmuch@notmuchmail.org
\r
58 Subject: Re: [notmuch] [RFC/PATCH] Add search-files command
\r
59 X-BeenThere: notmuch@notmuchmail.org
\r
60 X-Mailman-Version: 2.1.13
\r
62 List-Id: "Use and development of the notmuch mail system."
\r
63 <notmuch.notmuchmail.org>
\r
64 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
65 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
66 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
67 List-Post: <mailto:notmuch@notmuchmail.org>
\r
68 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
69 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
70 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
71 X-List-Received-Date: Wed, 13 Jan 2010 13:11:48 -0000
\r
75 Content-Type: text/plain; charset=iso-8859-9
\r
76 Content-Disposition: inline
\r
77 Content-Transfer-Encoding: quoted-printable
\r
79 Fernando Carrijo yazm=FD=FE:
\r
84 > On Wed, 13 Jan 2010 12:24:22 +0200, Ali Polatel <alip@exherbo.org> wrote:
\r
86 > > diff --git a/notmuch-search-files.c b/notmuch-search-files.c
\r
87 > > new file mode 100644
\r
88 > > index 0000000..b48783a
\r
90 > > +++ b/notmuch-search-files.c
\r
91 > > @@ -0,0 +1,107 @@
\r
92 > > +/* notmuch - Not much of an email program, (just index and search)
\r
94 > > + * Copyright =A9 2009 Carl Worth
\r
96 > I almost certainly should not be speaking in the name of Carl, but a
\r
97 > few weeks ago he replied with the following words to a message which
\r
98 > somehow raised the discussion of copyright holding in notmuch source
\r
101 > "Please feel free to retain your own copyright. I certainly don't
\r
102 > deserve anything being assigned to me."
\r
104 > The message-id of his reply is: 873a34tf8b.fsf@yoom.home.cworth.org,
\r
105 > just in the case you want to check the context in which it occurred.
\r
108 Thanks, I don't really care about who owns the copyright as long as it's
\r
109 open source but I'll change it if that's what Carl wishes.
\r
112 > > + if (*query_str =3D=3D '\0') {
\r
113 > > + fprintf (stderr, "Error: notmuch search-files requires at least one s=
\r
116 > Could we break this line so that it did not go beyond the column limit
\r
117 > set by the coding conventions? Maybe we should go one step further and
\r
118 > import the file CODING_STYLE from cairo into notmuch's repository.
\r
121 Sure, I didn't know much about the coding style and as you said there's
\r
122 no document about it in notmuch's repository.
\r
127 > > + query =3D notmuch_query_create (notmuch, query_str);
\r
128 > > + if (query =3D=3D NULL) {
\r
129 > > + fprintf (stderr, "Out of memory\n");
\r
133 > > + notmuch_query_set_sort (query, sort);
\r
135 > > + do_search_files (query);
\r
137 > > + notmuch_query_destroy (query);
\r
138 > > + notmuch_database_close (notmuch);
\r
140 > It is not something of major importance, but I realized that the
\r
141 > function notmuch_config_close is only being called when notmuch is
\r
142 > executed with no arguments. As we know, the kernel shall close all
\r
143 > open file descriptors upon program termination, but wouldn't it be
\r
144 > better if we did it explicitly? Or did I overlook something?
\r
147 Nope, it's good coding practise to free all resources before exit, I
\r
148 didn't do it for config because neither the search command does it.
\r
149 I'll send an updated patch soonish and I'll also send a separate patch
\r
150 for notmuch-search.c as well.
\r
153 > Fernando Carrijo.
\r
161 Content-Type: application/pgp-signature
\r
162 Content-Disposition: inline
\r
164 -----BEGIN PGP SIGNATURE-----
\r
165 Version: GnuPG v2.0.14 (GNU/Linux)
\r
167 iEYEABECAAYFAktNxn8ACgkQQU4yORhF8iASsgCfcCzyBvQxJOTkalZjq8BKDEjm
\r
168 iuoAnilccpg0Yw56QEmLZVvmqODkMDGC
\r
170 -----END PGP SIGNATURE-----
\r
172 --M9NhX3UHpAaciwkO--
\r