1 Return-Path: <m.walters@qmul.ac.uk>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 09634429E59
\r
6 for <notmuch@notmuchmail.org>; Sat, 1 Jun 2013 14:45:42 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-1.098 tagged_above=-999 required=5
\r
12 tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001,
\r
13 NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled
\r
14 Received: from olra.theworths.org ([127.0.0.1])
\r
15 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
16 with ESMTP id APBTparPkFGM for <notmuch@notmuchmail.org>;
\r
17 Sat, 1 Jun 2013 14:45:34 -0700 (PDT)
\r
18 Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6])
\r
19 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
\r
20 (No client certificate requested)
\r
21 by olra.theworths.org (Postfix) with ESMTPS id B72CC431FDE
\r
22 for <notmuch@notmuchmail.org>; Sat, 1 Jun 2013 14:45:33 -0700 (PDT)
\r
23 Received: from smtp.qmul.ac.uk ([138.37.6.40])
\r
24 by mail2.qmul.ac.uk with esmtp (Exim 4.71)
\r
25 (envelope-from <m.walters@qmul.ac.uk>)
\r
26 id 1Uitc9-0003Pv-Dv; Sat, 01 Jun 2013 22:45:29 +0100
\r
27 Received: from 93-97-24-31.zone5.bethere.co.uk ([93.97.24.31] helo=localhost)
\r
28 by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.71)
\r
29 (envelope-from <m.walters@qmul.ac.uk>)
\r
30 id 1Uitc9-0004On-48; Sat, 01 Jun 2013 22:45:29 +0100
\r
31 From: Mark Walters <markwalters1009@gmail.com>
\r
32 To: David Bremner <david@tethera.net>, notmuch@notmuchmail.org
\r
33 Subject: Re: [PATCH 2/2] contrib: pick: thread tagging (including archiving)
\r
35 In-Reply-To: <87zjv91uki.fsf@zancas.localnet>
\r
36 References: <1354970914-18342-1-git-send-email-markwalters1009@gmail.com>
\r
37 <1354970914-18342-3-git-send-email-markwalters1009@gmail.com>
\r
38 <87zjv91uki.fsf@zancas.localnet>
\r
39 User-Agent: Notmuch/0.14+255~gff3cc55 (http://notmuchmail.org) Emacs/23.4.1
\r
40 (x86_64-pc-linux-gnu)
\r
41 Date: Sat, 01 Jun 2013 22:45:27 +0100
\r
42 Message-ID: <87r4gly07c.fsf@qmul.ac.uk>
\r
44 Content-Type: text/plain; charset=us-ascii
\r
45 X-Sender-Host-Address: 93.97.24.31
\r
46 X-QM-SPAM-Info: Sender has good ham record. :)
\r
47 X-QM-Body-MD5: cc5973d852c514d45253f4140caf3088 (of first 20000 bytes)
\r
48 X-SpamAssassin-Score: -0.1
\r
49 X-SpamAssassin-SpamBar: /
\r
50 X-SpamAssassin-Report: The QM spam filters have analysed this message to
\r
52 spam. We require at least 5.0 points to mark a message as spam.
\r
53 This message scored -0.1 points.
\r
54 Summary of the scoring:
\r
55 * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail
\r
56 provider * (markwalters1009[at]gmail.com)
\r
57 * -0.1 AWL AWL: From: address is in the auto white-list
\r
58 X-QM-Scan-Virus: ClamAV says the message is clean
\r
59 X-BeenThere: notmuch@notmuchmail.org
\r
60 X-Mailman-Version: 2.1.13
\r
62 List-Id: "Use and development of the notmuch mail system."
\r
63 <notmuch.notmuchmail.org>
\r
64 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
65 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
66 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
67 List-Post: <mailto:notmuch@notmuchmail.org>
\r
68 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
69 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
70 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
71 X-List-Received-Date: Sat, 01 Jun 2013 21:45:42 -0000
\r
74 Thanks for the review. A couple of comments below:
\r
76 On Sat, 01 Jun 2013, David Bremner <david@tethera.net> wrote:
\r
77 > Mark Walters <markwalters1009@gmail.com> writes:
\r
79 >> Previously pick had no actions based on the entire thread: this adds
\r
80 >> some. Note in this version '*' is bound to `tag thread' which is not
\r
81 >> consistent with search or show. However it still might be the most
\r
82 >> natural thing (as it is similar to running * in the show pane).
\r
84 > Hmm. not sure about this. But since nobody complained in six months,
\r
85 > let's go with it unless they wake up.
\r
89 >> + (setq tag-changes (funcall 'notmuch-tag
\r
90 >> (notmuch-pick-get-messages-ids-thread-search) tag-changes))
\r
92 > Why "(funcall 'notmuch-tag ...) instead of a "(notmuch-tag ...)" here?
\r
93 > Personally I'd use let instead of setq here, but ymmv.
\r
95 I agree with both of these but this is almost identical code to that in
\r
96 notmuch-show-tag-all.
\r
98 >> +Archive each message currently shown by applying the tag changes
\r
99 >> +in `notmuch-archive-tags' to each (remove the \"inbox\" tag by
\r
100 >> +default). If a prefix argument is given, the messages will be
\r
101 >> +\"unarchived\", i.e. the tag changes in `notmuch-archive-tags'
\r
102 >> +will be reversed.
\r
104 > It seems to me the default value for notmuch-archive-tags should not be
\r
105 > hard-coded into this docstring, especially since notmuch-archive-tags
\r
106 > turns into a link in the help text.
\r
108 I am happy either way on this one but again this is the same as
\r
109 notmuch-show-archive-thread.
\r
111 I think it's probably best to keep show and pick the same where they are
\r
112 similar but I can change the above if you disagree.
\r