1 Return-Path: <jrollins@finestructure.net>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 6D832431FD0
\r
6 for <notmuch@notmuchmail.org>; Fri, 23 Dec 2011 23:55:39 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-2.29 tagged_above=-999 required=5
\r
12 tests=[RCVD_IN_DNSWL_MED=-2.3, T_MIME_NO_TEXT=0.01] autolearn=disabled
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id x+zAA60Pew2x for <notmuch@notmuchmail.org>;
\r
16 Fri, 23 Dec 2011 23:55:39 -0800 (PST)
\r
17 Received: from outgoing-mail.its.caltech.edu (outgoing-mail.its.caltech.edu
\r
19 by olra.theworths.org (Postfix) with ESMTP id EEF32431FB6
\r
20 for <notmuch@notmuchmail.org>; Fri, 23 Dec 2011 23:55:38 -0800 (PST)
\r
21 Received: from earth-doxen.imss.caltech.edu (localhost [127.0.0.1])
\r
22 by earth-doxen-postvirus (Postfix) with ESMTP id 6276166E0026;
\r
23 Fri, 23 Dec 2011 23:55:38 -0800 (PST)
\r
24 X-Spam-Scanned: at Caltech-IMSS on earth-doxen by amavisd-new
\r
25 Received: from finestructure.net (unknown [208.106.33.208])
\r
26 (Authenticated sender: jrollins)
\r
27 by earth-doxen-submit (Postfix) with ESMTP id 6DA7166E009C;
\r
28 Fri, 23 Dec 2011 23:55:35 -0800 (PST)
\r
29 Received: by finestructure.net (Postfix, from userid 1000)
\r
30 id 7C65F1692; Fri, 23 Dec 2011 23:55:34 -0800 (PST)
\r
31 From: Jameson Graef Rollins <jrollins@finestructure.net>
\r
32 To: Austin Clements <amdragon@MIT.EDU>, notmuch@notmuchmail.org
\r
33 Subject: Re: [PATCH v4 2/4] Introduce a generic tree-like abstraction for MIME
\r
35 In-Reply-To: <1324698348-27620-3-git-send-email-amdragon@mit.edu>
\r
36 References: <1323460468-4030-1-git-send-email-amdragon@mit.edu>
\r
37 <1324698348-27620-1-git-send-email-amdragon@mit.edu>
\r
38 <1324698348-27620-3-git-send-email-amdragon@mit.edu>
\r
39 User-Agent: Notmuch/0.10.2+127~g6689686 (http://notmuchmail.org) Emacs/23.3.1
\r
40 (x86_64-pc-linux-gnu)
\r
41 Date: Fri, 23 Dec 2011 23:55:34 -0800
\r
42 Message-ID: <87y5u2jte1.fsf@servo.finestructure.net>
\r
44 Content-Type: multipart/signed; boundary="=-=-=";
\r
45 micalg=pgp-sha256; protocol="application/pgp-signature"
\r
46 X-BeenThere: notmuch@notmuchmail.org
\r
47 X-Mailman-Version: 2.1.13
\r
49 List-Id: "Use and development of the notmuch mail system."
\r
50 <notmuch.notmuchmail.org>
\r
51 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
52 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
53 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
54 List-Post: <mailto:notmuch@notmuchmail.org>
\r
55 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
56 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
57 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
58 X-List-Received-Date: Sat, 24 Dec 2011 07:55:39 -0000
\r
62 On Fri, 23 Dec 2011 22:45:46 -0500, Austin Clements <amdragon@MIT.EDU> wrote:
\r
63 > + /* True if decryption of this part was attempted. */
\r
64 > + notmuch_bool_t decrypt_attempted;
\r
65 > + /* True if decryption of this part's child succeeded. In this
\r
66 > + * case, the decrypted part is substituted for the second child of
\r
67 > + * this part (which would usually be the encrypted data). */
\r
68 > + notmuch_bool_t decrypt_success;
\r
70 > + /* True if signature verification on this part was attempted. */
\r
71 > + notmuch_bool_t sig_attempted;
\r
73 I think these new variables make sense, and reflect the correct
\r
74 semantics, as you already mentioned.
\r
76 I do, however, think the later variable should be called
\r
77 "verify_attempted" (or "verification_", or "ver_"?), instead of
\r
78 "sig_attempted", since verification is the complementary action on a
\r
79 signed part, just as decryption is for an encrypted one.
\r
80 "sig_attempted" somehow implies to me that one is trying to make a
\r
81 signature, not verify an existing one.
\r
86 Content-Type: application/pgp-signature
\r
88 -----BEGIN PGP SIGNATURE-----
\r
89 Version: GnuPG v1.4.11 (GNU/Linux)
\r
91 iQIcBAEBCAAGBQJO9YV2AAoJEO00zqvie6q8E1YP/igtKzcsiKYkfKXr7hlzqDhW
\r
92 vPsdpWLCsdZSRgBu0/4g1stj1GM8zHhi0JEEp/85+t0ZINncDvLeSN2U8+LiODgO
\r
93 IOZ5mP4oFGnRyh3IrIDstNgXfzhyYifMfkoDM78y46K8PXdMXcl34wJxwOM59NCE
\r
94 EzhfRrsFr0KoQ+uxQofDg/OzCP8ZMv1UqtK3ZfwVS7nzwh9pJJ8JU4L+LWFlgufJ
\r
95 aUAaIfmShCUyoCDBph9tMIp9wsnfz69p3gcZhY2U2pqZ6/FACKH9WwF08Ae6AEfD
\r
96 4RsbjQFppbOuKtXeqEzyRzw6ZNKRhxuUUXqRIRj2Uh9+Hbss59jRVS+uVE4jEq4S
\r
97 wdqf/Q1Brs4L25v9rNM2muRv/Qot4JUZTOCFTHQcDEOWqY3W/AS/FmJWq4w5ALSb
\r
98 DgTo+6LR8gquhp6gqwDXJZG0tXmZtyF+uXZLa+9cwJprGlDRfsvoWZcuwFHEbt9p
\r
99 9klMgWTfYb2ejUFDTNkqrXro+hcrAJCkp2BSVlRQLgBSqWbG/T9hzuWHjx5Gspc3
\r
100 b0nslB9TM1Sd2A+PMCGWJiHL+lkORCzBMnFOboLIZWV920MiKA1JacsxQ7ZOlRLK
\r
101 5bfhxmJblLzachQMon52mk3hfB883KbbqwWV8MWrcAoYJfR8KDYqFFleHEL+hFIK
\r
102 FNmBBf9TUKit4K4NYEwv
\r
104 -----END PGP SIGNATURE-----
\r