1 Return-Path: <jan@ryngle.com>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id EAD61431FBC
\r
6 for <notmuch@notmuchmail.org>; Wed, 25 Nov 2009 13:25:07 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
8 Received: from olra.theworths.org ([127.0.0.1])
\r
9 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
10 with ESMTP id jH785kRr43dc for <notmuch@notmuchmail.org>;
\r
11 Wed, 25 Nov 2009 13:25:07 -0800 (PST)
\r
12 Received: from mail-ew0-f213.google.com (mail-ew0-f213.google.com
\r
14 by olra.theworths.org (Postfix) with ESMTP id 27AAE431FAE
\r
15 for <notmuch@notmuchmail.org>; Wed, 25 Nov 2009 13:25:07 -0800 (PST)
\r
16 Received: by ewy5 with SMTP id 5so146164ewy.30
\r
17 for <notmuch@notmuchmail.org>; Wed, 25 Nov 2009 13:25:06 -0800 (PST)
\r
18 Received: by 10.213.37.199 with SMTP id y7mr8312550ebd.36.1259184305580;
\r
19 Wed, 25 Nov 2009 13:25:05 -0800 (PST)
\r
20 Received: from x61s.janakj ([213.192.30.141])
\r
21 by mx.google.com with ESMTPS id 10sm237233eyz.23.2009.11.25.13.25.03
\r
22 (version=TLSv1/SSLv3 cipher=RC4-MD5);
\r
23 Wed, 25 Nov 2009 13:25:03 -0800 (PST)
\r
24 Received: by x61s.janakj (Postfix, from userid 1000)
\r
25 id 84B56440655; Wed, 25 Nov 2009 22:25:01 +0100 (CET)
\r
26 Date: Wed, 25 Nov 2009 22:25:01 +0100
\r
27 From: Jan Janak <jan@ryngle.com>
\r
28 To: Bart Trojanowski <bart@jukie.net>
\r
29 Message-ID: <20091125212501.GF25119@ryngle.com>
\r
30 References: <1259100630-13673-5-git-send-email-jan@ryngle.com>
\r
31 <1259174251-27298-1-git-send-email-jan@ryngle.com>
\r
32 <20091125195520.GG29312@jukie.net>
\r
34 Content-Type: text/plain; charset=us-ascii
\r
35 Content-Disposition: inline
\r
36 In-Reply-To: <20091125195520.GG29312@jukie.net>
\r
37 User-Agent: Mutt/1.5.18 (2008-05-17)
\r
38 Cc: notmuch@notmuchmail.org
\r
39 Subject: Re: [notmuch] [PATCH] notmuch-new: Option to disable tags from
\r
40 the configuration file.
\r
41 X-BeenThere: notmuch@notmuchmail.org
\r
42 X-Mailman-Version: 2.1.12
\r
44 List-Id: "Use and development of the notmuch mail system."
\r
45 <notmuch.notmuchmail.org>
\r
46 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
47 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
48 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
49 List-Post: <mailto:notmuch@notmuchmail.org>
\r
50 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
51 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
52 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
53 X-List-Received-Date: Wed, 25 Nov 2009 21:25:08 -0000
\r
57 On 25-11 14:55, Bart Trojanowski wrote:
\r
60 > I think your use of STRNCMP_LITERAL here is wrong...
\r
62 > > + } else if (STRNCMP_LITERAL (argv[i], "--no-config-tags") == 0) {
\r
63 > > + add_config_tags = 0;
\r
65 > it will happily match "--no-config-tags-xxxxxxxxxxxxxxxxxxx".
\r
67 Ahh, I actually stole the code from the part which parses the --verbose
\r
68 command line option. And I didn't check it. That one suffers from the same
\r
69 problem, so I'll just fix them both in one patch.
\r
71 > Can I also suggest including --no-config-tags in the 'notmuch help'
\r
76 > Besides that I am very happy with this patch series.
\r