1 Return-Path: <amdragon@mit.edu>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 5F17F429E25
\r
6 for <notmuch@notmuchmail.org>; Mon, 11 Jul 2011 17:03:57 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5
\r
12 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id eMIZDMQ7Vub1 for <notmuch@notmuchmail.org>;
\r
16 Mon, 11 Jul 2011 17:03:56 -0700 (PDT)
\r
17 Received: from dmz-mailsec-scanner-3.mit.edu (DMZ-MAILSEC-SCANNER-3.MIT.EDU
\r
19 by olra.theworths.org (Postfix) with ESMTP id D931F431FD0
\r
20 for <notmuch@notmuchmail.org>; Mon, 11 Jul 2011 17:03:56 -0700 (PDT)
\r
21 X-AuditID: 1209190e-b7c39ae000000a8c-d7-4e1b8f3d36af
\r
22 Received: from mailhub-auth-4.mit.edu ( [18.7.62.39])
\r
23 by dmz-mailsec-scanner-3.mit.edu (Symantec Messaging Gateway) with SMTP
\r
24 id 7E.6C.02700.D3F8B1E4; Mon, 11 Jul 2011 20:03:09 -0400 (EDT)
\r
25 Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103])
\r
26 by mailhub-auth-4.mit.edu (8.13.8/8.9.2) with ESMTP id p6C03uDj022207;
\r
27 Mon, 11 Jul 2011 20:03:56 -0400
\r
28 Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91])
\r
29 (authenticated bits=0)
\r
30 (User authenticated as amdragon@ATHENA.MIT.EDU)
\r
31 by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id p6C03sno000197
\r
32 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT);
\r
33 Mon, 11 Jul 2011 20:03:55 -0400 (EDT)
\r
34 Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.72)
\r
35 (envelope-from <amdragon@mit.edu>)
\r
36 id 1QgQS0-0003Iu-Fp; Mon, 11 Jul 2011 20:03:44 -0400
\r
37 Date: Mon, 11 Jul 2011 20:03:44 -0400
\r
38 From: Austin Clements <amdragon@MIT.EDU>
\r
39 To: Louis Rilling <l.rilling@av7.net>
\r
40 Subject: Re: [PATCH 2/2] tags_to_maildir_flags: Don't rename if no flags
\r
42 Message-ID: <20110712000344.GD25558@mit.edu>
\r
43 References: <87d3hzgemi.fsf@yoom.home.cworth.org>
\r
44 <1310394978-11883-3-git-send-email-l.rilling@av7.net>
\r
45 <20110711200712.GB25558@mit.edu>
\r
46 <20110711223805.GC3583@localdomain>
\r
48 Content-Type: text/plain; charset=us-ascii
\r
49 Content-Disposition: inline
\r
50 In-Reply-To: <20110711223805.GC3583@localdomain>
\r
51 User-Agent: Mutt/1.5.20 (2009-06-14)
\r
52 X-Brightmail-Tracker:
\r
53 H4sIAAAAAAAAA+NgFmpmleLIzCtJLcpLzFFi42IRYrdT17Xtl/YzePuA3+J8yysWi+s3ZzI7
\r
54 MHncXbeO3ePZqlvMAUxRXDYpqTmZZalF+nYJXBnLlu1hKejhrph0fTNzA+MVji5GTg4JAROJ
\r
55 z1PesULYYhIX7q1n62Lk4hAS2McocfXCVhYIZwOjxJ+fh9hAqoQETjJJTN9cCZFYwiix69Ny
\r
56 ZpAEi4CqxPc/+xhBbDYBDYlt+5eD2SJA8Z3tR9lBbGYBaYlvv5uZQGxhgUCJQzN2gtm8AjoS
\r
57 39t+MUIM3cQo8Wx5LyNEQlDi5MwnLBDNWhI3/r0EauAAG7T8HweIySlgILH2thtIhaiAisS1
\r
58 /e1sExiFZiFpnoWkeRZC8wJG5lWMsim5Vbq5iZk5xanJusXJiXl5qUW6xnq5mSV6qSmlmxhB
\r
59 Yc0pybeD8etBpUOMAhyMSjy8q6Sl/YRYE8uKK3MPMUpyMCmJ8v7qAgrxJeWnVGYkFmfEF5Xm
\r
60 pBYfYpTgYFYS4Q2pBcrxpiRWVqUW5cOkpDlYlMR5o7z/+woJpCeWpGanphakFsFkZTg4lCR4
\r
61 z/cBNQoWpaanVqRl5pQgpJk4OEGG8wANP98LMry4IDG3ODMdIn+KUVFKnDcSpFkAJJFRmgfX
\r
62 C0s7rxjFgV4R5r0CUsUDTFlw3a+ABjMBDX4tLQkyuCQRISXVwFjzyDnT9OSFd/11h785X/tX
\r
63 wLDpxq6XHV//ekyTm1OVpfNV6kalhOW83MCP3FY3ujQiNK8bZPQ9W555mrPd31I8WTHv0f51
\r
64 j0SvHGA/2H3ddfpdl5cnNq/Zd36957ktU6uOhEZuafh7SSHgyRfuhEgTVUEFa+t9XgsX2lhy
\r
65 9peffKYd5CN4QFaJpTgj0VCLuag4EQDHuCeZFgMAAA==
\r
66 Cc: notmuch@notmuchmail.org
\r
67 X-BeenThere: notmuch@notmuchmail.org
\r
68 X-Mailman-Version: 2.1.13
\r
70 List-Id: "Use and development of the notmuch mail system."
\r
71 <notmuch.notmuchmail.org>
\r
72 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
73 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
74 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
75 List-Post: <mailto:notmuch@notmuchmail.org>
\r
76 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
77 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
78 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
79 X-List-Received-Date: Tue, 12 Jul 2011 00:03:57 -0000
\r
81 Quoth Louis Rilling on Jul 12 at 12:38 am:
\r
82 > On 11/07/11 16:07 -0400, Austin Clements wrote:
\r
83 > > I worry that this may compound the confusion caused by mutt's handling
\r
84 > > of the new flag, but I suppose people aren't likely to manipulate any
\r
85 > > of the other maildir-synchronized flags without also marking the
\r
86 > > message as seen.
\r
88 > Even if they don't mark the message as seen, any flag changed would
\r
89 > move the message to cur/. The only buggy behavior would be from
\r
90 > mutt, with the bug you mentioned about mutt putting messages with
\r
91 > flags back to new/.
\r
93 Yes. I was thinking of someone tagging a message as, say, flagged,
\r
94 while it's still tagged unread. Then it would change from new to old
\r
95 in mutt. OTOH, adding some other non-synchronized tag wouldn't change
\r
96 it from new to old. I don't think there is a "correct" solution; your
\r
97 approach is probably the best compromise.
\r
99 > > The convention in notmuch is to use notmuch_bool_t, TRUE, and FALSE
\r
100 > > (though, admittedly, I don't know why; avoiding C99-isms?)
\r
102 > And bool is already used at another place in message.cc:
\r
104 > struct maildir_flag_tag {
\r
110 > IIUC it should be changed to notmuch_bool_t too.
\r
112 Yes, I suppose it should (something slipped by cworth's eagle-eyed
\r
113 reviews!). Though that appears to be the sole use of bool in all of
\r