1 Return-Path: <schnouki@schnouki.net>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 5C388431FD0
\r
6 for <notmuch@notmuchmail.org>; Wed, 21 Dec 2011 14:09:28 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-0.1 tagged_above=-999 required=5
\r
12 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1]
\r
14 Received: from olra.theworths.org ([127.0.0.1])
\r
15 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
16 with ESMTP id BgXiv88of+B7 for <notmuch@notmuchmail.org>;
\r
17 Wed, 21 Dec 2011 14:09:26 -0800 (PST)
\r
18 Received: from ks3536.kimsufi.com (schnouki.net [87.98.217.222])
\r
19 by olra.theworths.org (Postfix) with ESMTP id 47EC7431FB6
\r
20 for <notmuch@notmuchmail.org>; Wed, 21 Dec 2011 14:09:26 -0800 (PST)
\r
21 Received: from odin.local (nancy.schnouki.net [78.238.0.45])
\r
22 by ks3536.kimsufi.com (Postfix) with ESMTPSA id 42CB16A0026;
\r
23 Wed, 21 Dec 2011 23:09:25 +0100 (CET)
\r
24 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=schnouki.net;
\r
25 s=key-schnouki; t=1324505365;
\r
26 bh=wLADKDmxCzm0S5TF0vh8HP72caTnl7ZGxm+Z+jAPaQk=;
\r
27 h=From:To:Subject:In-Reply-To:References:Date:Message-ID:
\r
28 MIME-Version:Content-Type;
\r
29 b=JdPV2DVPM/bb6Bc8UA1fEK3cUJDgxO2zSj73ZSYPrVa0WxPzy/e3DRz2x5SESXLqF
\r
30 WmWwOVWC7izx0+JaqRjxZ79NB8qx7RAnTlZfPMJNillyG1uDDpfppZRu5khiRBKUPc
\r
31 u9TdxmAqJmA7aZhonEck63kO1SaEbOSdkBTxgl7Y=
\r
32 From: Thomas Jost <schnouki@schnouki.net>
\r
33 To: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>, notmuch@notmuchmail.org
\r
34 Subject: Re: [PATCH 2/2] test: add test for `notmuch-hello-refresh-hook'
\r
35 In-Reply-To: <87d3bh7fqq.fsf@gmail.com>
\r
36 References: <1324491506-1134-1-git-send-email-dmitry.kurochkin@gmail.com>
\r
37 <1324491506-1134-2-git-send-email-dmitry.kurochkin@gmail.com>
\r
38 <87ipl9k33a.fsf@schnouki.net> <87d3bh7fqq.fsf@gmail.com>
\r
39 User-Agent: Notmuch/0.10.2+131~gde16f21 (http://notmuchmail.org)
\r
40 Emacs/24.0.92.1 (x86_64-unknown-linux-gnu)
\r
41 Date: Wed, 21 Dec 2011 23:09:24 +0100
\r
42 Message-ID: <87d3bhk25n.fsf@schnouki.net>
\r
44 Content-Type: multipart/signed; boundary="=-=-=";
\r
45 micalg=pgp-sha1; protocol="application/pgp-signature"
\r
46 X-BeenThere: notmuch@notmuchmail.org
\r
47 X-Mailman-Version: 2.1.13
\r
49 List-Id: "Use and development of the notmuch mail system."
\r
50 <notmuch.notmuchmail.org>
\r
51 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
52 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
53 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
54 List-Post: <mailto:notmuch@notmuchmail.org>
\r
55 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
56 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
57 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
58 X-List-Received-Date: Wed, 21 Dec 2011 22:09:28 -0000
\r
61 Content-Type: text/plain
\r
62 Content-Transfer-Encoding: quoted-printable
\r
64 On Thu, 22 Dec 2011 01:54:21 +0400, Dmitry Kurochkin <dmitry.kurochkin@gmai=
\r
66 > On Wed, 21 Dec 2011 22:49:13 +0100, Thomas Jost <schnouki@schnouki.net> w=
\r
68 > > On Wed, 21 Dec 2011 22:18:26 +0400, Dmitry Kurochkin <dmitry.kurochkin@=
\r
70 > > > Test that `notmuch-hello-refresh-hook' is called once when
\r
71 > > > `notmuch-hello' is called and twice when calling
\r
72 > > > `notmuch-hello-update' after that.
\r
74 > > > The tests are very similar to tests for `notmuch-hello-mode-hook'.
\r
76 > > Quite nice, better than what I sent earlier [1] :)
\r
78 > > However I'm not sure that notmuch-hello.el is the right place for this
\r
79 > > kind of stuff; notmuch-lib.el may be better (so that it can also be used
\r
83 > These patches do not touch notmuch-hello.el. The functions are added to
\r
86 Wow. So apparently 22:49 is too late for me to read correctly.
\r
88 Full ACK for me then!
\r
100 > > [1] id:"1324473189-8622-1-git-send-email-schnouki@schnouki.net"
\r
104 > > > test/emacs | 19 +++++++++++++++++++
\r
105 > > > test/test-lib.el | 1 +
\r
106 > > > 2 files changed, 20 insertions(+), 0 deletions(-)
\r
108 > > > diff --git a/test/emacs b/test/emacs
\r
109 > > > index dffad0f..ca82445 100755
\r
110 > > > --- a/test/emacs
\r
111 > > > +++ b/test/emacs
\r
112 > > > @@ -495,4 +495,23 @@ counter=3D$(test_emacs \
\r
114 > > > test_expect_equal "$counter" 1
\r
116 > > > +test_begin_subtest "notmuch-hello-refresh hook is called"
\r
117 > > > +counter=3D$(test_emacs \
\r
118 > > > + '(let ((notmuch-hello-refresh-hook-counter 0))
\r
119 > > > + (kill-buffer "*notmuch-hello*")
\r
120 > > > + (notmuch-hello)
\r
121 > > > + notmuch-hello-refresh-hook-counter)'
\r
123 > > > +test_expect_equal "$counter" 1
\r
125 > > > +test_begin_subtest "notmuch-hello-refresh hook is called on updates"
\r
126 > > > +counter=3D$(test_emacs \
\r
127 > > > + '(let ((notmuch-hello-refresh-hook-counter 0))
\r
128 > > > + (kill-buffer "*notmuch-hello*")
\r
129 > > > + (notmuch-hello)
\r
130 > > > + (notmuch-hello-update)
\r
131 > > > + notmuch-hello-refresh-hook-counter)'
\r
133 > > > +test_expect_equal "$counter" 2
\r
136 > > > diff --git a/test/test-lib.el b/test/test-lib.el
\r
137 > > > index 83b8a65..3b817c3 100644
\r
138 > > > --- a/test/test-lib.el
\r
139 > > > +++ b/test/test-lib.el
\r
140 > > > @@ -75,3 +75,4 @@ nothing."
\r
141 > > > (add-hook hook (apply-partially 'hook-counter hook)))
\r
143 > > > (add-hook-counter 'notmuch-hello-mode-hook)
\r
144 > > > +(add-hook-counter 'notmuch-hello-refresh-hook)
\r
148 > > > _______________________________________________
\r
149 > > > notmuch mailing list
\r
150 > > > notmuch@notmuchmail.org
\r
151 > > > http://notmuchmail.org/mailman/listinfo/notmuch
\r
154 > > Thomas/Schnouki
\r
160 Content-Type: application/pgp-signature
\r
162 -----BEGIN PGP SIGNATURE-----
\r
163 Version: GnuPG v1.4.11 (GNU/Linux)
\r
165 iQEcBAEBAgAGBQJO8lkUAAoJEMPdciX+bh5IXSoH/16eKZ0qCedaZgLI3uzx5ygi
\r
166 /LJpaeilpMPDQLtHilQuKs6sUsMGPeD4af2TTY2219zT7x/2iYiO/TJz3qwRNTj3
\r
167 tdwUOQ01w1hIUpAyv3h4eLcB4Ty1YotonkFIz9Xtx0a7nUGm2WGWVJnYvslkvXkn
\r
168 dJWHgIL8xtiqk8OhKitVfJ6l1HUU8PMIKOk0G6SHD0f90c3F1PnbQECv/iXmNs+I
\r
169 BW73v4tQQKTON2BEX2narwS8eI0nhRS9GO9OGHGktBsMNzUaCf1qoh2iyY/cI0Pm
\r
170 uodmV/WuBav97/L4AGITjLLnCyhSsPGbpGRASxhXGXXjUWQiO2KSl2mQzcMiIlU=
\r
172 -----END PGP SIGNATURE-----
\r