1 Return-Path: <jani@nikula.org>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id F3C65431E64
\r
6 for <notmuch@notmuchmail.org>; Mon, 30 Jan 2012 08:01:18 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-0.699 tagged_above=-999 required=5
\r
12 tests=[HTML_MESSAGE=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id LW6auxftsU0l for <notmuch@notmuchmail.org>;
\r
16 Mon, 30 Jan 2012 08:01:18 -0800 (PST)
\r
17 Received: from mail-pz0-f53.google.com (mail-pz0-f53.google.com
\r
18 [209.85.210.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits))
\r
19 (No client certificate requested)
\r
20 by olra.theworths.org (Postfix) with ESMTPS id 28CE5431FBC
\r
21 for <notmuch@notmuchmail.org>; Mon, 30 Jan 2012 08:01:18 -0800 (PST)
\r
22 Received: by dadv6 with SMTP id v6so4707384dad.26
\r
23 for <notmuch@notmuchmail.org>; Mon, 30 Jan 2012 08:01:16 -0800 (PST)
\r
25 Received: by 10.68.74.72 with SMTP id r8mr42556447pbv.8.1327939275958; Mon, 30
\r
26 Jan 2012 08:01:15 -0800 (PST)
\r
27 Received: by 10.68.236.137 with HTTP; Mon, 30 Jan 2012 08:01:15 -0800 (PST)
\r
28 Received: by 10.68.236.137 with HTTP; Mon, 30 Jan 2012 08:01:15 -0800 (PST)
\r
29 In-Reply-To: <m2ehuhdzls.fsf@guru.guru-group.fi>
\r
30 References: <1327708018-1107-1-git-send-email-david@tethera.net>
\r
31 <m2ehuhdzls.fsf@guru.guru-group.fi>
\r
32 Date: Mon, 30 Jan 2012 18:01:15 +0200
\r
34 <CAB+hUn-o8JyWPqS+1e37m171cR04=LNOCBxFLyUiRK1vWjbe3g@mail.gmail.com>
\r
35 Subject: Re: [PATCH] STYLE: Initial draft of coding style document
\r
36 From: Jani Nikula <jani@nikula.org>
\r
37 To: Tomi Ollila <tomi.ollila@iki.fi>
\r
38 Content-Type: multipart/alternative; boundary=f46d040f9ca2d3a82204b7c0f4fc
\r
39 Cc: notmuch@notmuchmail.org, David Bremner <bremner@debian.org>
\r
40 X-BeenThere: notmuch@notmuchmail.org
\r
41 X-Mailman-Version: 2.1.13
\r
43 List-Id: "Use and development of the notmuch mail system."
\r
44 <notmuch.notmuchmail.org>
\r
45 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
46 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
47 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
48 List-Post: <mailto:notmuch@notmuchmail.org>
\r
49 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
50 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
51 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
52 X-List-Received-Date: Mon, 30 Jan 2012 16:01:19 -0000
\r
54 --f46d040f9ca2d3a82204b7c0f4fc
\r
55 Content-Type: text/plain; charset=UTF-8
\r
57 On Jan 30, 2012 4:38 PM, "Tomi Ollila" <tomi.ollila@iki.fi> wrote:
\r
59 > On Fri, 27 Jan 2012 19:46:58 -0400, David Bremner <david@tethera.net>
\r
61 > > From: David Bremner <bremner@debian.org>
\r
66 > > +* Indent is 4 spaces with mixed tabs/spaces and a tab width of 8.
\r
67 > > + Tabs should be only at the beginning of the line.
\r
69 > So, after initial indentation (with tabs) there should not be further
\r
70 > tabs? We'll be using the former instead of the latter in these 2 below?
\r
72 I'd prefer tabs for aligning comments at the end of lines.
\r
75 > /* excerpt from command-line-arguments.h -- indentation without tabs */
\r
77 > enum notmuch_opt_type {
\r
78 > NOTMUCH_OPT_END = 0,
\r
79 > NOTMUCH_OPT_BOOLEAN, /* --verbose */
\r
80 > NOTMUCH_OPT_INT, /* --frob=8 */
\r
81 > NOTMUCH_OPT_KEYWORD, /* --format=raw|json|text */
\r
82 > NOTMUCH_OPT_STRING, /* --file=/tmp/gnarf.txt */
\r
83 > NOTMUCH_OPT_POSITION /* notmuch dump pos_arg */
\r
86 > /* excerpt from command-line-arguments.h -- indentation with tabs */
\r
88 > enum notmuch_opt_type {
\r
89 > NOTMUCH_OPT_END = 0,
\r
90 > NOTMUCH_OPT_BOOLEAN, /* --verbose */
\r
91 > NOTMUCH_OPT_INT, /* --frob=8 */
\r
92 > NOTMUCH_OPT_KEYWORD, /* --format=raw|json|text */
\r
93 > NOTMUCH_OPT_STRING, /* --file=/tmp/gnarf.txt */
\r
94 > NOTMUCH_OPT_POSITION /* notmuch dump pos_arg */
\r
102 > _______________________________________________
\r
103 > notmuch mailing list
\r
104 > notmuch@notmuchmail.org
\r
105 > http://notmuchmail.org/mailman/listinfo/notmuch
\r
107 --f46d040f9ca2d3a82204b7c0f4fc
\r
108 Content-Type: text/html; charset=UTF-8
\r
109 Content-Transfer-Encoding: quoted-printable
\r
112 On Jan 30, 2012 4:38 PM, "Tomi Ollila" <<a href=3D"mailto:tomi=
\r
113 .ollila@iki.fi">tomi.ollila@iki.fi</a>> wrote:<br>
\r
115 > On Fri, 27 Jan 2012 19:46:58 -0400, David Bremner <<a href=3D"mailt=
\r
116 o:david@tethera.net">david@tethera.net</a>> wrote:<br>
\r
117 > > From: David Bremner <<a href=3D"mailto:bremner@debian.org">bre=
\r
118 mner@debian.org</a>><br>
\r
123 > > +* Indent is 4 spaces with mixed tabs/spaces and a tab width of 8=
\r
125 > > + =C2=A0Tabs should be only at the beginning of the line.<br>
\r
127 > So, after initial indentation (with tabs) there should not be further<=
\r
129 > tabs? We'll be using the former instead of the latter in these 2 b=
\r
131 <p>I'd prefer tabs for aligning comments at the end of lines.</p>
\r
133 > /* excerpt from command-line-arguments.h -- indentation without tabs *=
\r
136 > enum notmuch_opt_type {<br>
\r
137 > =C2=A0 =C2=A0NOTMUCH_OPT_END =3D 0,<br>
\r
138 > =C2=A0 =C2=A0NOTMUCH_OPT_BOOLEAN, =C2=A0 =C2=A0 =C2=A0 =C2=A0/* --verb=
\r
139 ose =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0*/<br>
\r
140 > =C2=A0 =C2=A0NOTMUCH_OPT_INT, =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
\r
141 =A0/* --frob=3D8 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 */<br>
\r
142 > =C2=A0 =C2=A0NOTMUCH_OPT_KEYWORD, =C2=A0 =C2=A0 =C2=A0 =C2=A0/* --form=
\r
143 at=3Draw|json|text */<br>
\r
144 > =C2=A0 =C2=A0NOTMUCH_OPT_STRING, =C2=A0 =C2=A0 =C2=A0 =C2=A0 /* --file=
\r
145 =3D/tmp/gnarf.txt =C2=A0*/<br>
\r
146 > =C2=A0 =C2=A0NOTMUCH_OPT_POSITION =C2=A0 =C2=A0 =C2=A0 =C2=A0/* notmuc=
\r
147 h dump pos_arg =C2=A0 */<br>
\r
150 > /* excerpt from command-line-arguments.h -- indentation with tabs */<b=
\r
153 > enum notmuch_opt_type {<br>
\r
154 > =C2=A0 =C2=A0NOTMUCH_OPT_END =3D 0,<br>
\r
155 > =C2=A0 =C2=A0NOTMUCH_OPT_BOOLEAN, =C2=A0 =C2=A0 =C2=A0 =C2=A0/* --verb=
\r
156 ose =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0*/<br>
\r
157 > =C2=A0 =C2=A0NOTMUCH_OPT_INT, =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
\r
158 =A0/* --frob=3D8 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 */<br>
\r
159 > =C2=A0 =C2=A0NOTMUCH_OPT_KEYWORD, =C2=A0 =C2=A0 =C2=A0 =C2=A0/* --form=
\r
160 at=3Draw|json|text */<br>
\r
161 > =C2=A0 =C2=A0NOTMUCH_OPT_STRING, =C2=A0 =C2=A0 =C2=A0 =C2=A0 /* --file=
\r
162 =3D/tmp/gnarf.txt =C2=A0*/<br>
\r
163 > =C2=A0 =C2=A0NOTMUCH_OPT_POSITION =C2=A0 =C2=A0 =C2=A0 =C2=A0/* notmuc=
\r
164 h dump pos_arg =C2=A0 */<br>
\r
172 > _______________________________________________<br>
\r
173 > notmuch mailing list<br>
\r
174 > <a href=3D"mailto:notmuch@notmuchmail.org">notmuch@notmuchmail.org</a>=
\r
176 > <a href=3D"http://notmuchmail.org/mailman/listinfo/notmuch">http://not=
\r
177 muchmail.org/mailman/listinfo/notmuch</a><br>
\r
180 --f46d040f9ca2d3a82204b7c0f4fc--
\r