1 Return-Path: <bremner@tethera.net>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 11564429E25
\r
6 for <notmuch@notmuchmail.org>; Sun, 2 Jun 2013 05:16:40 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-2.3 tagged_above=-999 required=5
\r
12 tests=[RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id 35zpnU-uHUll for <notmuch@notmuchmail.org>;
\r
16 Sun, 2 Jun 2013 05:16:32 -0700 (PDT)
\r
17 Received: from tempo.its.unb.ca (tempo.its.unb.ca [131.202.1.21])
\r
18 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
\r
19 (No client certificate requested)
\r
20 by olra.theworths.org (Postfix) with ESMTPS id DCD08431E64
\r
21 for <notmuch@notmuchmail.org>; Sun, 2 Jun 2013 05:16:31 -0700 (PDT)
\r
22 Received: from tesseract.cs.unb.ca (tesseract.cs.unb.ca [131.202.240.238])
\r
23 by tempo.its.unb.ca (8.13.8/8.13.8) with ESMTP id r52CGO9d009519;
\r
24 Sun, 2 Jun 2013 09:16:24 -0300
\r
25 Received: from fctnnbsc30w-156034082078.dhcp-dynamic.fibreop.nb.bellaliant.net
\r
26 ([156.34.82.78] helo=zancas.localnet)
\r
27 by tesseract.cs.unb.ca with esmtpsa
\r
28 (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.80)
\r
29 (envelope-from <bremner@tethera.net>)
\r
30 id 1Uj7Cx-0005jE-Dw; Sun, 02 Jun 2013 09:16:23 -0300
\r
31 Received: from bremner by zancas.localnet with local (Exim 4.80)
\r
32 (envelope-from <bremner@tethera.net>)
\r
33 id 1Uj7Cr-0003Ym-RY; Sun, 02 Jun 2013 09:16:17 -0300
\r
34 From: david@tethera.net
\r
35 To: notmuch@notmuchmail.org
\r
36 Subject: [PATCH] emacs: replace (funcall 'foo ...) with (foo ...)
\r
37 Date: Sun, 2 Jun 2013 09:16:10 -0300
\r
38 Message-Id: <1370175370-13561-1-git-send-email-david@tethera.net>
\r
39 X-Mailer: git-send-email 1.8.2.rc2
\r
41 Cc: David Bremner <bremner@debian.org>
\r
42 X-BeenThere: notmuch@notmuchmail.org
\r
43 X-Mailman-Version: 2.1.13
\r
45 List-Id: "Use and development of the notmuch mail system."
\r
46 <notmuch.notmuchmail.org>
\r
47 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
48 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
49 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
50 List-Post: <mailto:notmuch@notmuchmail.org>
\r
51 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
52 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
53 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
54 X-List-Received-Date: Sun, 02 Jun 2013 12:16:40 -0000
\r
56 From: David Bremner <bremner@debian.org>
\r
58 I can't see any benefit to the funcall, and it looks like the result
\r
59 of cut-and-paste from some code that actually used a variable for the
\r
63 Mark and I were discussing some style issues in the context of pick,
\r
64 and it seems to me that some of the elisp style in the current code
\r
65 could be improved. I don't claim to be an elisp style expert by any
\r
66 stretch of the imagination. It would be great if some experts could
\r
67 add a section to devel/STYLE about elisp.
\r
70 emacs/notmuch-message.el | 2 +-
\r
71 emacs/notmuch-show.el | 6 +++---
\r
72 emacs/notmuch.el | 4 ++--
\r
73 3 files changed, 6 insertions(+), 6 deletions(-)
\r
75 diff --git a/emacs/notmuch-message.el b/emacs/notmuch-message.el
\r
76 index 4dc4883..914bdd1 100644
\r
77 --- a/emacs/notmuch-message.el
\r
78 +++ b/emacs/notmuch-message.el
\r
79 @@ -40,7 +40,7 @@ the \"inbox\" and \"todo\" tags, you would set:
\r
80 ;; get the in-reply-to header and parse it for the message id.
\r
81 (let ((rep (mail-header-parse-addresses (message-field-value "In-Reply-To"))))
\r
82 (when (and notmuch-message-replied-tags rep)
\r
83 - (funcall 'notmuch-tag (notmuch-id-to-query (car (car rep)))
\r
84 + (notmuch-tag (notmuch-id-to-query (car (car rep)))
\r
85 (notmuch-tag-change-list notmuch-message-replied-tags)))))
\r
87 (add-hook 'message-send-hook 'notmuch-message-mark-replied)
\r
88 diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
\r
89 index 613e666..18b4671 100644
\r
90 --- a/emacs/notmuch-show.el
\r
91 +++ b/emacs/notmuch-show.el
\r
92 @@ -1726,7 +1726,7 @@ TAG-CHANGES is a list of tag operations for `notmuch-tag'."
\r
93 (let* ((current-tags (notmuch-show-get-tags))
\r
94 (new-tags (notmuch-update-tags current-tags tag-changes)))
\r
95 (unless (equal current-tags new-tags)
\r
96 - (funcall 'notmuch-tag (notmuch-show-get-message-id) tag-changes)
\r
97 + (notmuch-tag (notmuch-show-get-message-id) tag-changes)
\r
98 (notmuch-show-set-tags new-tags))))
\r
100 (defun notmuch-show-tag (&optional tag-changes)
\r
101 @@ -1734,7 +1734,7 @@ TAG-CHANGES is a list of tag operations for `notmuch-tag'."
\r
103 See `notmuch-tag' for information on the format of TAG-CHANGES."
\r
105 - (setq tag-changes (funcall 'notmuch-tag (notmuch-show-get-message-id) tag-changes))
\r
106 + (setq tag-changes (notmuch-tag (notmuch-show-get-message-id) tag-changes))
\r
107 (let* ((current-tags (notmuch-show-get-tags))
\r
108 (new-tags (notmuch-update-tags current-tags tag-changes)))
\r
109 (unless (equal current-tags new-tags)
\r
110 @@ -1745,7 +1745,7 @@ See `notmuch-tag' for information on the format of TAG-CHANGES."
\r
112 See `notmuch-tag' for information on the format of TAG-CHANGES."
\r
114 - (setq tag-changes (funcall 'notmuch-tag (notmuch-show-get-messages-ids-search) tag-changes))
\r
115 + (setq tag-changes (notmuch-tag (notmuch-show-get-messages-ids-search) tag-changes))
\r
118 (let* ((current-tags (notmuch-show-get-tags))
\r
119 diff --git a/emacs/notmuch.el b/emacs/notmuch.el
\r
120 index 5a8c957..af107e2 100644
\r
121 --- a/emacs/notmuch.el
\r
122 +++ b/emacs/notmuch.el
\r
123 @@ -562,7 +562,7 @@ will be signaled."
\r
124 (defun notmuch-search-tag-region (beg end &optional tag-changes)
\r
125 "Change tags for threads in the given region."
\r
126 (let ((search-string (notmuch-search-find-thread-id-region-search beg end)))
\r
127 - (setq tag-changes (funcall 'notmuch-tag search-string tag-changes))
\r
128 + (setq tag-changes (notmuch-tag search-string tag-changes))
\r
129 (notmuch-search-foreach-result beg end
\r
131 (notmuch-search-set-tags
\r
132 @@ -576,7 +576,7 @@ See `notmuch-tag' for information on the format of TAG-CHANGES."
\r
134 (let* ((beg (if (region-active-p) (region-beginning) (point)))
\r
135 (end (if (region-active-p) (region-end) (point))))
\r
136 - (funcall 'notmuch-search-tag-region beg end tag-changes)))
\r
137 + (notmuch-search-tag-region beg end tag-changes)))
\r
139 (defun notmuch-search-add-tag ()
\r
140 "Same as `notmuch-search-tag' but sets initial input to '+'."
\r