1 Return-Path: <jani@nikula.org>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 3570C407494
\r
6 for <notmuch@notmuchmail.org>; Fri, 6 Jan 2012 13:33:38 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5
\r
12 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id gd4FOsEo+T32 for <notmuch@notmuchmail.org>;
\r
16 Fri, 6 Jan 2012 13:33:37 -0800 (PST)
\r
17 Received: from mail-ee0-f53.google.com (mail-ee0-f53.google.com
\r
18 [74.125.83.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client
\r
19 certificate requested) by olra.theworths.org (Postfix) with ESMTPS id
\r
20 5C10F4074CD for <notmuch@notmuchmail.org>; Fri, 6 Jan 2012 13:33:37 -0800
\r
22 Received: by eekd41 with SMTP id d41so1615964eek.26
\r
23 for <notmuch@notmuchmail.org>; Fri, 06 Jan 2012 13:33:36 -0800 (PST)
\r
24 Received: by 10.14.2.71 with SMTP id 47mr2899421eee.16.1325885616049;
\r
25 Fri, 06 Jan 2012 13:33:36 -0800 (PST)
\r
26 Received: from localhost (dsl-hkibrasgw4-fe5cdc00-23.dhcp.inet.fi.
\r
28 by mx.google.com with ESMTPS id u53sm205046306eeu.6.2012.01.06.13.33.33
\r
29 (version=SSLv3 cipher=OTHER); Fri, 06 Jan 2012 13:33:34 -0800 (PST)
\r
30 From: Jani Nikula <jani@nikula.org>
\r
31 To: Antoine =?utf-8?Q?Beaupr=C3=A9?= <anarcat@koumbit.org>, David Edmondson
\r
32 <dme@dme.org>, notmuch@notmuchmail.org
\r
33 Subject: Re: [PATCH 1/2] add notmuch keybinding 'd'
\r
34 In-Reply-To: <87k454wq0e.fsf@marcos.anarcat.ath.cx>
\r
35 References: <1266408746-28549-1-git-send-email-Sebastian@SSpaeth.de>
\r
36 <1310841600-28281-1-git-send-email-anarcat@koumbit.org>
\r
37 <cunvcos6dhp.fsf@hotblack-desiato.hh.sledj.net>
\r
38 <8762gsy2xp.fsf@nikula.org> <87k454wq0e.fsf@marcos.anarcat.ath.cx>
\r
39 User-Agent: Notmuch/0.10.2+182~g93862a2 (http://notmuchmail.org) Emacs/23.3.1
\r
41 Date: Fri, 06 Jan 2012 23:33:32 +0200
\r
42 Message-ID: <87aa608qj7.fsf@nikula.org>
\r
44 Content-Type: text/plain; charset=utf-8
\r
45 Content-Transfer-Encoding: quoted-printable
\r
46 X-BeenThere: notmuch@notmuchmail.org
\r
47 X-Mailman-Version: 2.1.13
\r
49 List-Id: "Use and development of the notmuch mail system."
\r
50 <notmuch.notmuchmail.org>
\r
51 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
52 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
53 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
54 List-Post: <mailto:notmuch@notmuchmail.org>
\r
55 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
56 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
57 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
58 X-List-Received-Date: Fri, 06 Jan 2012 21:33:38 -0000
\r
63 On Fri, 06 Jan 2012 15:10:57 -0500, Antoine Beaupr=C3=A9 <anarcat@koumbit.o=
\r
65 > On Tue, 03 Jan 2012 21:57:22 +0200, Jani Nikula <jani@nikula.org> wrote:
\r
66 > > I wouldn't use it either, and I don't use "deleted" tag in the first
\r
67 > > place. And even if I used it, I'd still like to keep the distinction
\r
68 > > between "deleted after reading" and "deleted unread", which this patch
\r
69 > > loses by removing the "unread" tag.
\r
71 > I have been using this for months now.
\r
73 > But honestly, I don't care much anymore: the hard part is not the tag,
\r
74 > it's what you do with it after (hint: just remove the damn file).
\r
76 > Most patches I have submitted here haven't been accepted and I have to
\r
77 > painfully reroll my own packages every time there's a new release, which
\r
78 > has been a very frustrating experience. To see such a trivial patch
\r
79 > obsoleted tops it.
\r
81 This patch, while trivial, fixes a specific use case for you, according
\r
82 to your preferences. I was hoping for something more generic, and
\r
83 Jameson showed how this can be done in one's .emacs without adding new
\r
84 code (or carrying your own patches) at all. If this approach does not
\r
85 work for you, please let us know why!
\r
87 > For the curious, those (other) patches are:
\r
89 > * lib: add 'safe' setting for flags
\r
90 > * lib: Add back the synchronization of 'T' flag with deleted tag
\r
91 > * run notmuch-hello-mode-hook at the end of the hello mode setup
\r
93 > Most of those do not change the current behavior, and I have been
\r
94 > running them for more than 4 months.
\r
96 I haven't looked at the patches, but please understand that not changing
\r
97 the current behaviour is not a sufficient reason for inclusion. Once in,
\r
98 people will start using the features, which will need to be maintained
\r
99 and supported potentially for a very long time. Once in, it's not easy
\r
100 to take features out. Especially so for lib. So we need to be careful.
\r
102 Tests have also become an increasingly important part in getting any
\r
103 non-trivial changes in. It's not enough that they work perfectly now; we
\r
104 need to be able to make sure later changes won't break them.
\r
106 > I'd very much like to get help to get this in...=20
\r
108 I'll try to find a moment to review your other patches.
\r
110 I've also had my moments of frustration, but things have really improved
\r
111 significantly since you've sent those patches. David is doing an
\r
112 excellent job. Be persistent!
\r
projects / notmuch-archives.git / blob