1 Return-Path: <tomi.ollila@iki.fi>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 0EEBD431FB6
\r
6 for <notmuch@notmuchmail.org>; Mon, 23 Jul 2012 06:54:17 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id EEWYekEHKuiS for <notmuch@notmuchmail.org>;
\r
16 Mon, 23 Jul 2012 06:54:05 -0700 (PDT)
\r
17 Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])
\r
18 by olra.theworths.org (Postfix) with ESMTP id 6293B431FAE
\r
19 for <notmuch@notmuchmail.org>; Mon, 23 Jul 2012 06:54:05 -0700 (PDT)
\r
20 Received: by guru.guru-group.fi (Postfix, from userid 501)
\r
21 id 7D57F1000E5; Mon, 23 Jul 2012 16:54:14 +0300 (EEST)
\r
22 From: Tomi Ollila <tomi.ollila@iki.fi>
\r
23 To: craven@gmx.net, notmuch@notmuchmail.org
\r
24 Subject: Re: [PATCH v8 0/3] notmuch-search: Structured Output Formatters
\r
25 In-Reply-To: <1343039986-2732-1-git-send-email-craven@gmx.net>
\r
26 References: <1343039986-2732-1-git-send-email-craven@gmx.net>
\r
27 User-Agent: Notmuch/0.13.2+93~ge4fdd97 (http://notmuchmail.org) Emacs/23.1.1
\r
28 (x86_64-redhat-linux-gnu)
\r
29 X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
\r
30 $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
\r
31 !)g;OY^,BjTbr)Np:%c_o'jj,Z
\r
32 Date: Mon, 23 Jul 2012 16:54:14 +0300
\r
33 Message-ID: <m27gtushvd.fsf@guru.guru-group.fi>
\r
35 Content-Type: text/plain; charset=us-ascii
\r
36 X-BeenThere: notmuch@notmuchmail.org
\r
37 X-Mailman-Version: 2.1.13
\r
39 List-Id: "Use and development of the notmuch mail system."
\r
40 <notmuch.notmuchmail.org>
\r
41 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
42 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
43 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
44 List-Post: <mailto:notmuch@notmuchmail.org>
\r
45 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
46 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
47 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
48 X-List-Received-Date: Mon, 23 Jul 2012 13:54:17 -0000
\r
50 On Mon, Jul 23 2012, craven@gmx.net wrote:
\r
52 > From: <craven@gmx.net>
\r
54 > Currently there is no easy way to add support for different structured
\r
55 > formatters (like JSON). For example, adding support for S-Expressions
\r
56 > would result in code duplication.
\r
58 > This patch series amends the situation by introducing structured
\r
59 > formatters, which allow different implementations of structures like
\r
60 > lists, maps, strings and numbers.
\r
67 > The new code in sprinter.h and sprinter-json.c can be used instead of
\r
68 > the current ad-hoc output in all parts of notmuch, a patch for
\r
69 > notmuch-search.c is included.
\r
71 > In a later patch, all other parts of notmuch should be adapted to the
\r
72 > structured formatters, and the creation of formatters should be
\r
73 > centralised (to make adding new formatters easier).
\r
75 > A "structured" formatter is provided for notmuch-search that prints the
\r
76 > current text format. This removes almost all the special-casing from
\r
79 > Changes versus v7 of this patch:
\r
80 > - added {} around "else" blocks (as mentioned in
\r
81 > id:20120722160843.GC31834@mit.edu)
\r
82 > - added fallback to INTERNAL_ERROR (which should never be called) in
\r
83 > notmuch-search.c if format is unknown (as mentioned in
\r
84 > id:m2r4s694ly.fsf@guru.guru-group.fi).
\r
89 > Add support for structured output formatters.
\r
90 > Add structured output formatter for JSON and plain text (but don't
\r
92 > Use the structured formatters in notmuch-search.c.
\r
94 > Makefile.local | 2 +
\r
95 > notmuch-search.c | 304 ++++++++++++++---------------------------------
\r
96 > sprinter-json.c | 187 +++++++++++++++++++++++++++++
\r
97 > sprinter-text.c | 126 ++++++++++++++++++++
\r
98 > sprinter.h | 68 +++++++++++
\r
99 > test/json | 34 +++---
\r
100 > 6 files changed, 489 insertions(+), 232 deletions(-)
\r
101 > create mode 100644 sprinter-json.c
\r
102 > create mode 100644 sprinter-text.c
\r
103 > create mode 100644 sprinter.h
\r
108 > _______________________________________________
\r
109 > notmuch mailing list
\r
110 > notmuch@notmuchmail.org
\r
111 > http://notmuchmail.org/mailman/listinfo/notmuch
\r