1 Return-Path: <sojkam1@fel.cvut.cz>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 06B54431FAE
\r
6 for <notmuch@notmuchmail.org>; Tue, 9 Feb 2010 06:40:08 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-1.17 tagged_above=-999 required=5 tests=[AWL=-0.986,
\r
12 BAYES_40=-0.185, WEIRD_PORT=0.001] autolearn=no
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id DtX33tobIGFe for <notmuch@notmuchmail.org>;
\r
16 Tue, 9 Feb 2010 06:40:06 -0800 (PST)
\r
17 Received: from max.feld.cvut.cz (max.feld.cvut.cz [147.32.192.36])
\r
18 by olra.theworths.org (Postfix) with ESMTP id 3EA17431FBC
\r
19 for <notmuch@notmuchmail.org>; Tue, 9 Feb 2010 06:40:06 -0800 (PST)
\r
20 Received: from localhost (unknown [192.168.200.4])
\r
21 by max.feld.cvut.cz (Postfix) with ESMTP id 2C4A019F33CB;
\r
22 Tue, 9 Feb 2010 15:40:05 +0100 (CET)
\r
23 X-Virus-Scanned: IMAP AMAVIS
\r
24 Received: from max.feld.cvut.cz ([192.168.200.1])
\r
25 by localhost (styx.feld.cvut.cz [192.168.200.4]) (amavisd-new,
\r
27 with ESMTP id 4ikEI12pgVL5; Tue, 9 Feb 2010 15:40:00 +0100 (CET)
\r
28 Received: from imap.feld.cvut.cz (imap.feld.cvut.cz [147.32.192.34])
\r
29 by max.feld.cvut.cz (Postfix) with ESMTP id E5CF219F338C;
\r
30 Tue, 9 Feb 2010 15:40:00 +0100 (CET)
\r
31 Received: from steelpick.localdomain (k335-30.felk.cvut.cz [147.32.86.30])
\r
32 (Authenticated sender: sojkam1)
\r
33 by imap.feld.cvut.cz (Postfix) with ESMTPSA id A7722FA003;
\r
34 Tue, 9 Feb 2010 15:40:00 +0100 (CET)
\r
35 Received: from wsh by steelpick.localdomain with local (Exim 4.71)
\r
36 (envelope-from <sojkam1@fel.cvut.cz>)
\r
37 id 1NerFw-0004aO-Cu; Tue, 09 Feb 2010 15:40:00 +0100
\r
38 From: Michal Sojka <sojkam1@fel.cvut.cz>
\r
39 To: Carl Worth <cworth@cworth.org>, notmuch@notmuchmail.org
\r
40 In-Reply-To: <87eikvpfzl.fsf@yoom.home.cworth.org>
\r
41 References: <87mxzjpl9v.fsf@yoom.home.cworth.org>
\r
42 <87eikvpfzl.fsf@yoom.home.cworth.org>
\r
43 Date: Tue, 09 Feb 2010 15:40:00 +0100
\r
44 Message-ID: <87r5oua2wv.fsf@steelpick.localdomain>
\r
46 Content-Type: text/plain; charset=utf-8
\r
47 Content-Transfer-Encoding: quoted-printable
\r
48 Subject: Re: [notmuch] [PATCH] Switch from random to sequential thread
\r
50 X-BeenThere: notmuch@notmuchmail.org
\r
51 X-Mailman-Version: 2.1.13
\r
53 List-Id: "Use and development of the notmuch mail system."
\r
54 <notmuch.notmuchmail.org>
\r
55 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
56 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
57 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
58 List-Post: <mailto:notmuch@notmuchmail.org>
\r
59 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
60 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
61 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
62 X-List-Received-Date: Tue, 09 Feb 2010 14:40:08 -0000
\r
64 On Mon, 08 Feb 2010 13:36:14 -0800, Carl Worth <cworth@cworth.org> wrote:
\r
65 > The sequential identifiers have the advantage of being guaranteed to
\r
66 > be unique (until we overflow a 64-bit unsigned integer), and also take
\r
67 > up half as much space in the "notmuch search" output (16 columns
\r
72 lib/database.cc: In function =E2=80=98const char* _notmuch_database_generat=
\r
73 e_thread_id(notmuch_database_t*)=E2=80=99:
\r
74 lib/database.cc:1309: warning: format =E2=80=98%016llx=E2=80=99 expects typ=
\r
75 e =E2=80=98long long unsigned int=E2=80=99, but argument 3 has type =E2=80=
\r
76 =98uint64_t=E2=80=99
\r
78 What about the following? This could also fix Sebastian's problem.
\r
81 >From afcc07ae03ae40cf7e1c33d8632fba0a9fc0b4c8 Mon Sep 17 00:00:00 2001
\r
82 From: Michal Sojka <sojkam1@fel.cvut.cz>
\r
83 Date: Tue, 9 Feb 2010 15:35:39 +0100
\r
84 Subject: [PATCH] Suppress warning on amd64
\r
87 lib/database.cc | 5 ++++-
\r
88 1 files changed, 4 insertions(+), 1 deletions(-)
\r
90 diff --git a/lib/database.cc b/lib/database.cc
\r
91 index 8641321..20a4c72 100644
\r
92 --- a/lib/database.cc
\r
93 +++ b/lib/database.cc
\r
98 +#define __STDC_FORMAT_MACROS
\r
99 +#include <inttypes.h>
\r
101 #include <glib.h> /* g_free, GPtrArray, GHashTable */
\r
103 using namespace std;
\r
104 @@ -1306,7 +1309,7 @@ _notmuch_database_generate_thread_id (notmuch_databas=
\r
107 notmuch->last_thread_id++;
\r
109 - sprintf (thread_id, "%016llx", notmuch->last_thread_id);
\r
110 + sprintf (thread_id, "%016"PRIx64, notmuch->last_thread_id);
\r
112 db->set_metadata ("last_thread_id", thread_id);
\r