1 Return-Path: <tomi.ollila@iki.fi>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 745BE431FB6
\r
6 for <notmuch@notmuchmail.org>; Mon, 5 Nov 2012 23:07:24 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id TgI9P9IHu+lo for <notmuch@notmuchmail.org>;
\r
16 Mon, 5 Nov 2012 23:07:23 -0800 (PST)
\r
17 Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])
\r
18 by olra.theworths.org (Postfix) with ESMTP id 9E2C9431FAE
\r
19 for <notmuch@notmuchmail.org>; Mon, 5 Nov 2012 23:07:23 -0800 (PST)
\r
20 Received: from guru.guru-group.fi (localhost [IPv6:::1])
\r
21 by guru.guru-group.fi (Postfix) with ESMTP id DA406100094;
\r
22 Tue, 6 Nov 2012 09:07:22 +0200 (EET)
\r
23 From: Tomi Ollila <tomi.ollila@iki.fi>
\r
24 To: Ethan Glasser-Camp <ethan.glasser.camp@gmail.com>, notmuch@notmuchmail.org
\r
25 Subject: Re: [PATCH 1/1] uncrustify.cfg: added 3 new types for uncrustify to
\r
27 In-Reply-To: <87390nid3c.fsf@betacantrips.com>
\r
28 References: <1351865226-916-1-git-send-email-tomi.ollila@iki.fi>
\r
29 <87390nid3c.fsf@betacantrips.com>
\r
30 User-Agent: Notmuch/0.14+81~gb8371cd (http://notmuchmail.org) Emacs/24.2.1
\r
31 (x86_64-unknown-linux-gnu)
\r
32 X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
\r
33 $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
\r
34 !)g;OY^,BjTbr)Np:%c_o'jj,Z
\r
35 Date: Tue, 06 Nov 2012 09:07:22 +0200
\r
36 Message-ID: <m2objb9plh.fsf@guru.guru-group.fi>
\r
38 Content-Type: text/plain
\r
39 X-BeenThere: notmuch@notmuchmail.org
\r
40 X-Mailman-Version: 2.1.13
\r
42 List-Id: "Use and development of the notmuch mail system."
\r
43 <notmuch.notmuchmail.org>
\r
44 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
45 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
46 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
47 List-Post: <mailto:notmuch@notmuchmail.org>
\r
48 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
49 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
50 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
51 X-List-Received-Date: Tue, 06 Nov 2012 07:07:24 -0000
\r
53 On Tue, Nov 06 2012, Ethan Glasser-Camp <ethan.glasser.camp@gmail.com> wrote:
\r
55 > Tomi Ollila <tomi.ollila@iki.fi> writes:
\r
57 >> Added FILE, notmuch_show_params_t and sprinter_t to be
\r
58 >> types when uncrustifying sources. This affect spacing
\r
59 >> when uncrustify is deciding for type declaration instead
\r
60 >> of binary multiplication operation.
\r
62 > This looks good to me. If you had plenty of time and no more patches to
\r
63 > review, I'd prefer the slightly cleaner English:
\r
65 > This affects how uncrustify puts spacing around pointers to these types,
\r
66 > since it can parse them as type declarations instead of binary
\r
67 > multiplication operations.
\r
69 > ... but even suggesting this indicates I've moved past the bike shed and
\r
70 > into somebody else's kitchen.
\r
72 I always appreciate anybody putting effort to translate my scrawls into
\r
73 more cleaner expressions ;D
\r
75 If the change were more important I'd take time to improve the commit
\r
78 Like one of our famous contributors have said:
\r
80 "I also don't think we have to be totally obsessive about our commit history."
\r
84 "I doubt it would make much difference in the grand scheme of things."
\r