1 Return-Path: <cworth@cworth.org>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id B2F79431FBD;
\r
6 Fri, 4 Dec 2009 16:56:58 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
8 Received: from olra.theworths.org ([127.0.0.1])
\r
9 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
10 with ESMTP id MtsIeXa8NAfm; Fri, 4 Dec 2009 16:56:57 -0800 (PST)
\r
11 Received: from yoom.home.cworth.org (localhost [127.0.0.1])
\r
12 by olra.theworths.org (Postfix) with ESMTP id A938B431FAE;
\r
13 Fri, 4 Dec 2009 16:56:57 -0800 (PST)
\r
14 Received: by yoom.home.cworth.org (Postfix, from userid 1000)
\r
15 id 620622542FB; Fri, 4 Dec 2009 16:56:57 -0800 (PST)
\r
16 From: Carl Worth <cworth@cworth.org>
\r
17 To: Jameson Graef Rollins <jrollins@finestructure.net>
\r
18 In-Reply-To: <20091205002050.GA26479@finestructure.net>
\r
19 References: <1259452657-27608-1-git-send-email-jrollins@finestructure.net>
\r
20 <87ocmee0sg.fsf@yoom.home.cworth.org>
\r
21 <20091205002050.GA26479@finestructure.net>
\r
22 Date: Fri, 04 Dec 2009 16:56:56 -0800
\r
23 Message-ID: <878wdidyqv.fsf@yoom.home.cworth.org>
\r
25 Content-Type: multipart/signed; boundary="=-=-=";
\r
26 micalg=pgp-sha1; protocol="application/pgp-signature"
\r
27 Cc: notmuch@notmuchmail.org
\r
28 Subject: Re: [notmuch] [PATCH 1/3] fix configure script to handle --prefix=
\r
29 and properly create Makefile.config
\r
30 X-BeenThere: notmuch@notmuchmail.org
\r
31 X-Mailman-Version: 2.1.12
\r
33 List-Id: "Use and development of the notmuch mail system."
\r
34 <notmuch.notmuchmail.org>
\r
35 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
36 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
37 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
38 List-Post: <mailto:notmuch@notmuchmail.org>
\r
39 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
40 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
41 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
42 X-List-Received-Date: Sat, 05 Dec 2009 00:56:58 -0000
\r
45 Content-Transfer-Encoding: quoted-printable
\r
47 On Fri, 4 Dec 2009 19:20:50 -0500, Jameson Graef Rollins <jrollins@finestru=
\r
49 > > Your commit message has that flag word of "also" in it, and as it turns
\r
50 > > out, the removal of Makefile.config from the repository has actually
\r
51 > > happened already. But that was easy enough to fix.
\r
53 > I was thinking that the removal of the Makefile.config from the repo
\r
54 > went together with the new auto-generation of that file from configure
\r
55 > script. Do you think they still should have been separate patches?
\r
57 No, it was fine. It's just funny to me how often that word "also" in a
\r
58 commit message seems to end up being a predictor for things later, (like
\r
59 this case where half of a patch is already implemented, or much worse,
\r
60 how often a bisect lands on a commit that makes multiple changes).
\r
62 So I was really just expressing amusement at seeing it again.
\r
64 > > > +# option parsing
\r
65 > > > +for option; do
\r
66 > > > + if [ "${option%=3D*}" =3D '--prefix' ] ; then
\r
67 > > > + PREFIX=3D"${option#*=3D}"
\r
71 > > I've gone ahead and committed that now. Then I noticed that we should
\r
72 > > really use ${option%%=3D*} to support the case of an option value
\r
73 > > containing an '=3D' character. So I fixed that.
\r
75 > Ah, good catch. Sorry about that.=20=20
\r
77 No worries. I was just impressed at the tiny amount of code needed for
\r
78 the parsing here, so ended up looking closer to understand it.
\r
80 > Autoconf terrifies me, so I agree I'm quite happy with the simple
\r
81 > configure script we have right now. If it gets the job done without
\r
82 > having to deal with autoconf then that's great in my book.
\r
84 Cool. At least not everyone thinks I'm crazy then. That's
\r
90 Content-Type: application/pgp-signature
\r
92 -----BEGIN PGP SIGNATURE-----
\r
93 Version: GnuPG v1.4.10 (GNU/Linux)
\r
95 iD8DBQFLGa/Z6JDdNq8qSWgRAjTaAKCCQ0n3l9Ae6Y7mWwaoJezCbBDPagCfSEwT
\r
96 MXBUsNBliQ3aQFzRjHlL0V8=
\r
98 -----END PGP SIGNATURE-----
\r