1 Return-Path: <cworth@cworth.org>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 9A7CD431FBF;
\r
6 Wed, 18 Nov 2009 03:31:38 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
8 Received: from olra.theworths.org ([127.0.0.1])
\r
9 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
10 with ESMTP id lIkozQzDmLNW; Wed, 18 Nov 2009 03:31:37 -0800 (PST)
\r
11 Received: from cworth.org (localhost [127.0.0.1])
\r
12 by olra.theworths.org (Postfix) with ESMTP id 51CE8431FAE;
\r
13 Wed, 18 Nov 2009 03:31:37 -0800 (PST)
\r
14 From: Carl Worth <cworth@cworth.org>
\r
15 To: Alex Botero-Lowry <alex.boterolowry@gmail.com>, notmuch@notmuchmail.org
\r
16 In-Reply-To: <cf0c4d610911171623q3e27a0adx802e47039b57604b@mail.gmail.com>
\r
17 References: <cf0c4d610911171623q3e27a0adx802e47039b57604b@mail.gmail.com>
\r
18 Date: Wed, 18 Nov 2009 03:31:23 -0800
\r
19 Message-ID: <877htoqdbo.fsf@yoom.home.cworth.org>
\r
21 Content-Type: text/plain; charset=us-ascii
\r
22 Subject: Re: [notmuch] [PATCH] Error out if no query is supplied to search
\r
23 instead of going into an infinite loop
\r
24 X-BeenThere: notmuch@notmuchmail.org
\r
25 X-Mailman-Version: 2.1.12
\r
27 List-Id: "Use and development of the notmuch mail system."
\r
28 <notmuch.notmuchmail.org>
\r
29 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
30 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
31 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
32 List-Post: <mailto:notmuch@notmuchmail.org>
\r
33 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
34 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
35 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
36 X-List-Received-Date: Wed, 18 Nov 2009 11:31:38 -0000
\r
38 On Tue, 17 Nov 2009 16:23:53 -0800, Alex Botero-Lowry <alex.boterolowry@gmail.com> wrote:
\r
39 > In this case error out when no query is supplied. There seems to be an
\r
40 > infinite-loop casued by i think notmuch_query_search_threads having
\r
42 > A Xapian exception occurred: Syntax: <expression> AND <expression>
\r
43 > A Xapian exception occurred: Syntax: <expression> AND <expression>
\r
44 > A Xapian exception occurred: Syntax: <expression> AND <expression>
\r
46 > I'll look into that bug specifically a bit later.
\r
48 > It might be better to do a usage instead of just throwing an error here?
\r
52 Priit Laes reported the same thing in IRC and I've just committed a
\r
53 patch to give a nice error message:
\r
56 Error: notmuch search requires at least one search term.
\r
58 Thanks for the report!
\r