1 Return-Path: <tomi.ollila@iki.fi>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id D4058431FAF
\r
6 for <notmuch@notmuchmail.org>; Sun, 2 Dec 2012 03:04:18 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id yjcOI85dVBND for <notmuch@notmuchmail.org>;
\r
16 Sun, 2 Dec 2012 03:04:14 -0800 (PST)
\r
17 Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])
\r
18 by olra.theworths.org (Postfix) with ESMTP id 965E8431FAE
\r
19 for <notmuch@notmuchmail.org>; Sun, 2 Dec 2012 03:04:14 -0800 (PST)
\r
20 Received: from guru.guru-group.fi (localhost [IPv6:::1])
\r
21 by guru.guru-group.fi (Postfix) with ESMTP id 423F4100045;
\r
22 Sun, 2 Dec 2012 13:04:10 +0200 (EET)
\r
23 From: Tomi Ollila <tomi.ollila@iki.fi>
\r
24 To: Mark Walters <markwalters1009@gmail.com>, notmuch@notmuchmail.org
\r
25 Subject: Re: [PATCH] emacs: stash bugfix
\r
26 In-Reply-To: <1354443068-5030-1-git-send-email-markwalters1009@gmail.com>
\r
27 References: <1354443068-5030-1-git-send-email-markwalters1009@gmail.com>
\r
28 User-Agent: Notmuch/0.14+116~g29fcdb5 (http://notmuchmail.org) Emacs/24.2.1
\r
29 (x86_64-unknown-linux-gnu)
\r
30 X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
\r
31 $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
\r
32 !)g;OY^,BjTbr)Np:%c_o'jj,Z
\r
33 Date: Sun, 02 Dec 2012 13:04:09 +0200
\r
34 Message-ID: <m2boecsok6.fsf@guru.guru-group.fi>
\r
36 Content-Type: text/plain
\r
37 X-BeenThere: notmuch@notmuchmail.org
\r
38 X-Mailman-Version: 2.1.13
\r
40 List-Id: "Use and development of the notmuch mail system."
\r
41 <notmuch.notmuchmail.org>
\r
42 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
43 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
44 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
45 List-Post: <mailto:notmuch@notmuchmail.org>
\r
46 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
47 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
48 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
49 X-List-Received-Date: Sun, 02 Dec 2012 11:04:19 -0000
\r
51 On Sun, Dec 02 2012, Mark Walters <markwalters1009@gmail.com> wrote:
\r
53 > Currently an attempt to stash a non-existent field (eg cc when not
\r
54 > present) throws an error. Catch this case and give the user a warning
\r
64 > While messing around with notmuch-pick key bindings I found the
\r
65 > following bug. The easiest way I have found to trigger it is cc
\r
66 > (stash-cc) in show mode on a message with no cc header.
\r
72 > emacs/notmuch-lib.el | 7 +++++--
\r
73 > 1 files changed, 5 insertions(+), 2 deletions(-)
\r
75 > diff --git a/emacs/notmuch-lib.el b/emacs/notmuch-lib.el
\r
76 > index 1d0ec17..c7d8e02 100644
\r
77 > --- a/emacs/notmuch-lib.el
\r
78 > +++ b/emacs/notmuch-lib.el
\r
79 > @@ -183,8 +183,11 @@ user-friendly queries."
\r
81 > (defun notmuch-common-do-stash (text)
\r
82 > "Common function to stash text in kill ring, and display in minibuffer."
\r
84 > - (message "Stashed: %s" text))
\r
88 > + (message "Stashed: %s" text))
\r
89 > + (message "Warning: Nothing to stash!")))
\r
96 > _______________________________________________
\r
97 > notmuch mailing list
\r
98 > notmuch@notmuchmail.org
\r
99 > http://notmuchmail.org/mailman/listinfo/notmuch
\r