1 Return-Path: <aclements@csail.mit.edu>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id CFB00431FC9
\r
6 for <notmuch@notmuchmail.org>; Wed, 21 Jan 2015 14:39:13 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=0.138 tagged_above=-999 required=5
\r
12 tests=[DNS_FROM_AHBL_RHSBL=2.438, RCVD_IN_DNSWL_MED=-2.3]
\r
14 Received: from olra.theworths.org ([127.0.0.1])
\r
15 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
16 with ESMTP id vRvldbayjeuK for <notmuch@notmuchmail.org>;
\r
17 Wed, 21 Jan 2015 14:39:10 -0800 (PST)
\r
18 Received: from outgoing.csail.mit.edu (outgoing.csail.mit.edu [128.30.2.149])
\r
19 by olra.theworths.org (Postfix) with ESMTP id 9ADEE431FBC
\r
20 for <notmuch@notmuchmail.org>; Wed, 21 Jan 2015 14:39:10 -0800 (PST)
\r
21 Received: from [104.131.20.129] (helo=awakeningjr)
\r
22 by outgoing.csail.mit.edu with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16)
\r
23 (Exim 4.72) (envelope-from <aclements@csail.mit.edu>)
\r
24 id 1YE3vZ-0002TM-KD; Wed, 21 Jan 2015 17:39:09 -0500
\r
25 Received: from amthrax by awakeningjr with local (Exim 4.84)
\r
26 (envelope-from <aclements@csail.mit.edu>)
\r
27 id 1YE3vZ-0001pR-4A; Wed, 21 Jan 2015 17:39:09 -0500
\r
28 Date: Wed, 21 Jan 2015 17:39:09 -0500
\r
29 From: Austin Clements <aclements@csail.mit.edu>
\r
30 To: Daniel Kahn Gillmor <dkg@fifthhorseman.net>
\r
31 Subject: Re: privacy problem: text/html parts pull in network resources
\r
32 Message-ID: <20150121223909.GL22599@csail.mit.edu>
\r
33 References: <87ppa7q25w.fsf@alice.fifthhorseman.net>
\r
34 <20150121211407.GK22599@csail.mit.edu>
\r
35 <87k30fq0hx.fsf@alice.fifthhorseman.net>
\r
37 Content-Type: text/plain; charset=us-ascii
\r
38 Content-Disposition: inline
\r
39 In-Reply-To: <87k30fq0hx.fsf@alice.fifthhorseman.net>
\r
40 User-Agent: Mutt/1.5.23 (2014-03-12)
\r
41 Cc: notmuch mailing list <notmuch@notmuchmail.org>
\r
42 X-BeenThere: notmuch@notmuchmail.org
\r
43 X-Mailman-Version: 2.1.13
\r
45 List-Id: "Use and development of the notmuch mail system."
\r
46 <notmuch.notmuchmail.org>
\r
47 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
48 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
49 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
50 List-Post: <mailto:notmuch@notmuchmail.org>
\r
51 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
52 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
53 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
54 X-List-Received-Date: Wed, 21 Jan 2015 22:39:14 -0000
\r
56 Quoth Daniel Kahn Gillmor on Jan 21 at 4:36 pm:
\r
57 > On Wed 2015-01-21 16:14:07 -0500, Austin Clements wrote:
\r
58 > > I have a fix for this on shr buried deep in an old patch series that I
\r
59 > > never got back to: id:1398105468-14317-12-git-send-email-amdragon@mit.edu
\r
61 > > For shr, the key is to set shr-blocked-images to ".".
\r
63 > I've just done this, but it doesn't seem to help.
\r
65 > > However, IIRC, in the current notmuch message rendering pipeline, mm
\r
66 > > overrides this variable with something computed from
\r
67 > > gnus-blocked-images. That said, I'm not sure why gnus-blocked-images
\r
68 > > isn't *already* taking care of this, but that's probably the place to
\r
71 > gnus-blocked-images is set for me to the function
\r
72 > gnus-block-private-groups, but i don't know what that is (the function
\r
73 > is undocumented afaict). Setting gnus-blocked-images to a regexp of "."
\r
74 > seems to work for me, though.
\r
76 In notmuch, mm will wind up calling (gnus-block-private-groups nil).
\r
77 Unfortunately, gnus apparently considers nil to be a news group rather
\r
78 than a "private group" (gnus speak for email, I think), so
\r
79 gnus-block-private-groups returns nil (meaning *don't* block images)
\r
82 Probably notmuch should override the gnus-blocked-images variable,
\r
83 since the default value is simply wrong for notmuch. Maybe something
\r
84 along the lines of the following should go around our text/html
\r
87 (let ((gnus-blocked-images
\r
88 (if (eq gnus-blocked-images 'gnus-block-private-groups)
\r
89 ;; mm uses gnus-blocked-images to control image loading.
\r
90 ;; However, the default value of gnus-blocked-images
\r
91 ;; doesn't work for notmuch because
\r
92 ;; gnus-block-private-groups depends on gnus variables we
\r
93 ;; don't set. Override it to disallow network image
\r
96 ;; Use the user's customized value.
\r
97 gnus-blocked-images)))
\r
100 Long live abstraction!
\r