1 Return-Path: <dmitry.kurochkin@gmail.com>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 3438B429E57
\r
6 for <notmuch@notmuchmail.org>; Sun, 29 Jan 2012 15:10:50 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5
\r
12 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,
\r
13 FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
\r
14 Received: from olra.theworths.org ([127.0.0.1])
\r
15 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
16 with ESMTP id iQESay1g4FRp for <notmuch@notmuchmail.org>;
\r
17 Sun, 29 Jan 2012 15:10:49 -0800 (PST)
\r
18 Received: from mail-bk0-f53.google.com (mail-bk0-f53.google.com
\r
19 [209.85.214.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits))
\r
20 (No client certificate requested)
\r
21 by olra.theworths.org (Postfix) with ESMTPS id 9D1D4429E54
\r
22 for <notmuch@notmuchmail.org>; Sun, 29 Jan 2012 15:10:49 -0800 (PST)
\r
23 Received: by bke11 with SMTP id 11so870975bke.26
\r
24 for <notmuch@notmuchmail.org>; Sun, 29 Jan 2012 15:10:48 -0800 (PST)
\r
25 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;
\r
26 h=from:to:cc:subject:in-reply-to:references:user-agent:date
\r
27 :message-id:mime-version:content-type;
\r
28 bh=9Ti4cQabq+sg8C0YE61dY040y+/IGxAgesgK+UIQ7Pk=;
\r
29 b=B/a3qv6W6iX1DdUASmRSiUiFJYfZ0b1Wx3Nw2KjbS2Ph8vInK2A4kJnJayGen0je/A
\r
30 GKG4IiXsfGE2Zii89iwnFHg6klUwK9LMaIhivhsFNKFFATuU8JRZtH0fMbXhVBVHudkS
\r
31 venWYL9iamfdfJlPPGp7bNYRrakdmt16tuVBQ=
\r
32 Received: by 10.204.152.219 with SMTP id h27mr7451627bkw.40.1327878648322;
\r
33 Sun, 29 Jan 2012 15:10:48 -0800 (PST)
\r
34 Received: from localhost ([91.144.186.21])
\r
35 by mx.google.com with ESMTPS id d2sm33295507bky.11.2012.01.29.15.10.47
\r
36 (version=TLSv1/SSLv3 cipher=OTHER);
\r
37 Sun, 29 Jan 2012 15:10:47 -0800 (PST)
\r
38 From: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>
\r
39 To: Austin Clements <amdragon@MIT.EDU>
\r
40 Subject: Re: [PATCH 4/6] test: fix emacs tests after tagging operations
\r
42 In-Reply-To: <20120129225841.GH17991@mit.edu>
\r
43 References: <1327725684-5887-1-git-send-email-dmitry.kurochkin@gmail.com>
\r
44 <1327725684-5887-4-git-send-email-dmitry.kurochkin@gmail.com>
\r
45 <20120129225841.GH17991@mit.edu>
\r
46 User-Agent: Notmuch/0.11+134~g7ddba9d (http://notmuchmail.org) Emacs/23.3.1
\r
47 (x86_64-pc-linux-gnu)
\r
48 Date: Mon, 30 Jan 2012 03:09:38 +0400
\r
49 Message-ID: <87d3a285sd.fsf@gmail.com>
\r
51 Content-Type: text/plain; charset=us-ascii
\r
52 Cc: notmuch@notmuchmail.org
\r
53 X-BeenThere: notmuch@notmuchmail.org
\r
54 X-Mailman-Version: 2.1.13
\r
56 List-Id: "Use and development of the notmuch mail system."
\r
57 <notmuch.notmuchmail.org>
\r
58 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
59 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
60 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
61 List-Post: <mailto:notmuch@notmuchmail.org>
\r
62 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
63 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
64 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
65 X-List-Received-Date: Sun, 29 Jan 2012 23:10:50 -0000
\r
67 On Sun, 29 Jan 2012 17:58:41 -0500, Austin Clements <amdragon@MIT.EDU> wrote:
\r
68 > Quoth Dmitry Kurochkin on Jan 28 at 8:41 am:
\r
69 > > After the recent tagging operations changes, functions bound to "+"
\r
70 > > and "-" in notmuch-search and notmuch-show views always read input
\r
71 > > from the minibuffer. Use kbd macros instead of calling them directly.
\r
73 > Should this be folded into the previous patch so these tests aren't
\r
74 > temporarily broken?
\r
76 I think it is a common approach for notmuch. IIRC I sent patches which
\r
77 changes both code and tests, and I was asked to move the tests to a
\r
78 separate patch. So I will leave it as is for now. Though if you point
\r
79 me to a relevant discussion or policy, which says that the tests should
\r
80 be merged, I would be happy to do it.
\r