1 Return-Path: <tomi.ollila@iki.fi>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id C5A7A431E62
\r
6 for <notmuch@notmuchmail.org>; Fri, 3 Aug 2012 02:35:26 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id buHikfsnnLRs for <notmuch@notmuchmail.org>;
\r
16 Fri, 3 Aug 2012 02:35:25 -0700 (PDT)
\r
17 Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])
\r
18 by olra.theworths.org (Postfix) with ESMTP id AA2D0431FAE
\r
19 for <notmuch@notmuchmail.org>; Fri, 3 Aug 2012 02:35:25 -0700 (PDT)
\r
20 Received: by guru.guru-group.fi (Postfix, from userid 501)
\r
21 id 29137100372; Fri, 3 Aug 2012 12:35:29 +0300 (EEST)
\r
22 From: Tomi Ollila <tomi.ollila@iki.fi>
\r
23 To: Austin Clements <amdragon@MIT.EDU>, notmuch@notmuchmail.org
\r
24 Subject: Re: [PATCH v3 00/13] Convert notmuch show to use structure printers
\r
25 In-Reply-To: <1343956499-14543-1-git-send-email-amdragon@mit.edu>
\r
26 References: <1343956499-14543-1-git-send-email-amdragon@mit.edu>
\r
27 User-Agent: Notmuch/0.13.2+123~gc7b631e (http://notmuchmail.org) Emacs/23.1.1
\r
28 (x86_64-redhat-linux-gnu)
\r
29 X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
\r
30 $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
\r
31 !)g;OY^,BjTbr)Np:%c_o'jj,Z
\r
32 Date: Fri, 03 Aug 2012 12:35:29 +0300
\r
33 Message-ID: <m2zk6c48ta.fsf@guru.guru-group.fi>
\r
35 Content-Type: text/plain; charset=us-ascii
\r
36 X-BeenThere: notmuch@notmuchmail.org
\r
37 X-Mailman-Version: 2.1.13
\r
39 List-Id: "Use and development of the notmuch mail system."
\r
40 <notmuch.notmuchmail.org>
\r
41 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
42 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
43 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
44 List-Post: <mailto:notmuch@notmuchmail.org>
\r
45 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
46 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
47 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
48 X-List-Received-Date: Fri, 03 Aug 2012 09:35:26 -0000
\r
50 On Fri, Aug 03 2012, Austin Clements <amdragon@MIT.EDU> wrote:
\r
52 > Relative to version 2 [0], this version fixes a duplicate typedef of
\r
53 > struct sprinter that was not standards compliant and failed to compile
\r
54 > on older gccs [1] (thanks to Tomi for discovering that and figuring
\r
55 > out what was going on).
\r
61 > The diff relative to version 2 follows.
\r
63 > [0] id:"1343449754-9010-1-git-send-email-amdragon@mit.edu"
\r
65 > [1] http://stackoverflow.com/questions/8594954/repeated-typedefs-invalid-in-c-but-valid-in-c
\r
67 > diff --git a/notmuch-client.h b/notmuch-client.h
\r
68 > index de31aa1..ae9344b 100644
\r
69 > --- a/notmuch-client.h
\r
70 > +++ b/notmuch-client.h
\r
71 > @@ -66,12 +66,12 @@ typedef GMimeCipherContext notmuch_crypto_context_t;
\r
72 > #define STRINGIFY_(s) #s
\r
74 > typedef struct mime_node mime_node_t;
\r
75 > -typedef struct sprinter sprinter_t;
\r
77 > struct notmuch_show_params;
\r
79 > typedef struct notmuch_show_format {
\r
80 > - sprinter_t *(*new_sprinter) (const void *ctx, FILE *stream);
\r
81 > - notmuch_status_t (*part) (const void *ctx, sprinter_t *sprinter,
\r
82 > + struct sprinter *(*new_sprinter) (const void *ctx, FILE *stream);
\r
83 > + notmuch_status_t (*part) (const void *ctx, struct sprinter *sprinter,
\r
84 > struct mime_node *node, int indent,
\r
85 > const struct notmuch_show_params *params);
\r
86 > } notmuch_show_format_t;
\r
87 > @@ -175,11 +175,11 @@ notmuch_status_t
\r
88 > show_one_part (const char *filename, int part);
\r
91 > -format_part_json (const void *ctx, sprinter_t *sp, mime_node_t *node,
\r
92 > +format_part_json (const void *ctx, struct sprinter *sp, mime_node_t *node,
\r
93 > notmuch_bool_t first, notmuch_bool_t output_body);
\r
96 > -format_headers_json (sprinter_t *sp, GMimeMessage *message,
\r
97 > +format_headers_json (struct sprinter *sp, GMimeMessage *message,
\r
98 > notmuch_bool_t reply);
\r
103 > _______________________________________________
\r
104 > notmuch mailing list
\r
105 > notmuch@notmuchmail.org
\r
106 > http://notmuchmail.org/mailman/listinfo/notmuch
\r