1 Return-Path: <jani@nikula.org>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 2DF10431FB6
\r
6 for <notmuch@notmuchmail.org>; Thu, 2 May 2013 09:20:42 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5
\r
12 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id x5Pj5WEZ1RU6 for <notmuch@notmuchmail.org>;
\r
16 Thu, 2 May 2013 09:20:38 -0700 (PDT)
\r
17 Received: from mail-la0-f46.google.com (mail-la0-f46.google.com
\r
18 [209.85.215.46]) (using TLSv1 with cipher RC4-SHA (128/128 bits))
\r
19 (No client certificate requested)
\r
20 by olra.theworths.org (Postfix) with ESMTPS id C1201431FAF
\r
21 for <notmuch@notmuchmail.org>; Thu, 2 May 2013 09:20:37 -0700 (PDT)
\r
22 Received: by mail-la0-f46.google.com with SMTP id fk20so702834lab.33
\r
23 for <notmuch@notmuchmail.org>; Thu, 02 May 2013 09:20:36 -0700 (PDT)
\r
24 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
\r
25 d=google.com; s=20120113;
\r
26 h=x-received:from:to:cc:subject:in-reply-to:references:user-agent
\r
27 :date:message-id:mime-version:content-type:x-gm-message-state;
\r
28 bh=Kbig8zRFV5QxiiFKLAkpnX13r00hHw7FkgqoUoTMZF8=;
\r
29 b=VkOeMKJB8Tc3slhtvA2HfMAmbz2OlbDluD4X2Rtgz4DZ4JBh5rqCef3gQ1hNC+oI0Z
\r
30 fqcEl7rxzmAH4xXFkiXz+wj7/g63sQadjhr3PX+OygkbmWHDkbv8bVYVfn+ZtR4kBLk3
\r
31 UNiKF5Kk2FjvdHmhQSyf/JawDPBPK5WXuKuEXGH1TnyaD8AMzZFrtVBzYOqbp56aqyW5
\r
32 KFQE0hHADzTVfFZhT8zxbKSw0baqHRt39Ke/sVr2aA3YpVR17kutcboHElmcfCzruNgw
\r
33 lIc0B1WuH6DqNN/rBxaSa4IwnlL3waN8+lZh9x/CV7/Co3UyogwqVdxeJ3IwqYpVjdD3
\r
35 X-Received: by 10.152.6.229 with SMTP id e5mr2468033laa.6.1367511636197;
\r
36 Thu, 02 May 2013 09:20:36 -0700 (PDT)
\r
37 Received: from localhost (dsl-hkibrasgw2-58c376-211.dhcp.inet.fi.
\r
39 by mx.google.com with ESMTPSA id r9sm2970061lbr.3.2013.05.02.09.20.34
\r
40 for <multiple recipients>
\r
41 (version=TLSv1.2 cipher=RC4-SHA bits=128/128);
\r
42 Thu, 02 May 2013 09:20:35 -0700 (PDT)
\r
43 From: Jani Nikula <jani@nikula.org>
\r
44 To: Vladimir.Marek@oracle.com, notmuch@notmuchmail.org
\r
45 Subject: Re: [PATCH] lib/message.cc: stale pointer bug (v3)
\r
46 In-Reply-To: <1367505102-12860-1-git-send-email-Vladimir.Marek@oracle.com>
\r
47 References: <1367505102-12860-1-git-send-email-Vladimir.Marek@oracle.com>
\r
48 User-Agent: Notmuch/0.15.2+70~g2eeb96a (http://notmuchmail.org) Emacs/24.2.1
\r
49 (x86_64-pc-linux-gnu)
\r
50 Date: Thu, 02 May 2013 19:20:30 +0300
\r
51 Message-ID: <87ppx94alt.fsf@nikula.org>
\r
53 Content-Type: text/plain
\r
55 ALoCoQmYutxrV69Xb5RCUw7L15OCv4aoorjKzUkmv2EWs2x8XEwvHFQeLRIrgjmNLZWUGkrz3Pku
\r
56 Cc: Vladimir Marek <vlmarek@volny.cz>
\r
57 X-BeenThere: notmuch@notmuchmail.org
\r
58 X-Mailman-Version: 2.1.13
\r
60 List-Id: "Use and development of the notmuch mail system."
\r
61 <notmuch.notmuchmail.org>
\r
62 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
63 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
64 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
65 List-Post: <mailto:notmuch@notmuchmail.org>
\r
66 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
67 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
68 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
69 X-List-Received-Date: Thu, 02 May 2013 16:20:42 -0000
\r
74 On Thu, 02 May 2013, Vladimir.Marek@oracle.com wrote:
\r
75 > From: Vladimir Marek <vlmarek@volny.cz>
\r
77 > Xapian::TermIterator::operator* returns std::string which is destroyed
\r
78 > as soon as (*i).c_str() finishes. The remembered pointer 'term' then
\r
79 > references invalid memory.
\r
81 > Signed-off-by: Vladimir Marek <vlmarek@volny.cz>
\r
83 > lib/message.cc | 10 +++++-----
\r
84 > 1 file changed, 5 insertions(+), 5 deletions(-)
\r
86 > diff --git a/lib/message.cc b/lib/message.cc
\r
87 > index 8720c1b..c4261e6 100644
\r
88 > --- a/lib/message.cc
\r
89 > +++ b/lib/message.cc
\r
90 > @@ -266,18 +266,18 @@ _notmuch_message_get_term (notmuch_message_t *message,
\r
91 > const char *prefix)
\r
93 > int prefix_len = strlen (prefix);
\r
94 > - const char *term = NULL;
\r
97 > i.skip_to (prefix);
\r
100 > - term = (*i).c_str ();
\r
104 > - if (!term || strncmp (term, prefix, prefix_len))
\r
105 > + std::string term = *i;
\r
106 > + if (strncmp (term.c_str(), prefix, prefix_len))
\r
109 > - value = talloc_strdup (message, term + prefix_len);
\r
110 > + value = talloc_strdup (message, term.c_str() + prefix_len);
\r
112 > #if DEBUG_DATABASE_SANITY
\r
117 > _______________________________________________
\r
118 > notmuch mailing list
\r
119 > notmuch@notmuchmail.org
\r
120 > http://notmuchmail.org/mailman/listinfo/notmuch
\r