1 Return-Path: <cworth@cworth.org>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 0F665429E28
\r
6 for <notmuch@notmuchmail.org>; Wed, 25 May 2011 15:46:48 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=0.01 tagged_above=-999 required=5
\r
12 tests=[T_MIME_NO_TEXT=0.01] autolearn=disabled
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id JMptdDc3IECG for <notmuch@notmuchmail.org>;
\r
16 Wed, 25 May 2011 15:46:47 -0700 (PDT)
\r
17 Received: from arlo.cworth.org (arlo.cworth.org [50.43.72.2])
\r
18 by olra.theworths.org (Postfix) with ESMTP id 9EC78431FB6
\r
19 for <notmuch@notmuchmail.org>; Wed, 25 May 2011 15:46:47 -0700 (PDT)
\r
20 Received: from yoom.home.cworth.org (localhost [127.0.0.1])
\r
21 by arlo.cworth.org (Postfix) with ESMTP id 9181B29A4FA;
\r
22 Wed, 25 May 2011 15:46:46 -0700 (PDT)
\r
23 Received: by yoom.home.cworth.org (Postfix, from userid 1000)
\r
24 id 7E51B25417E; Wed, 25 May 2011 15:46:46 -0700 (PDT)
\r
25 From: Carl Worth <cworth@cworth.org>
\r
26 To: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>, notmuch@notmuchmail.org
\r
27 Subject: Re: [PATCH 3/5] Fix hiding a message while some citations are shown
\r
28 in notmuch-show view.
\r
29 In-Reply-To: <87k4depfyj.fsf@gmail.com>
\r
30 References: <1306361416-5019-1-git-send-email-dmitry.kurochkin@gmail.com>
\r
31 <1306361416-5019-4-git-send-email-dmitry.kurochkin@gmail.com>
\r
32 <87oc2qa07g.fsf@yoom.home.cworth.org> <87k4depfyj.fsf@gmail.com>
\r
33 User-Agent: Notmuch/0.5 (http://notmuchmail.org) Emacs/23.3.1
\r
35 Date: Wed, 25 May 2011 15:46:40 -0700
\r
36 Message-ID: <87lixu9z5b.fsf@yoom.home.cworth.org>
\r
38 Content-Type: multipart/signed; boundary="=-=-=";
\r
39 micalg=pgp-sha1; protocol="application/pgp-signature"
\r
40 X-BeenThere: notmuch@notmuchmail.org
\r
41 X-Mailman-Version: 2.1.13
\r
43 List-Id: "Use and development of the notmuch mail system."
\r
44 <notmuch.notmuchmail.org>
\r
45 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
46 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
47 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
48 List-Post: <mailto:notmuch@notmuchmail.org>
\r
49 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
50 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
51 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
52 X-List-Received-Date: Wed, 25 May 2011 22:46:48 -0000
\r
56 On Thu, 26 May 2011 02:34:28 +0400, Dmitry Kurochkin <dmitry.kurochkin@gmail.com> wrote:
\r
57 > I am not sure how it is best to test this. The common `printc' method
\r
58 > for emacs tests does not work, because it prints invisible parts as
\r
59 > well. We need either to find a way to print only visible text on the
\r
60 > console, or test it inside emacs somehow. Any suggestions?
\r
62 Unfortunately, I don't have a good plan here. I delayed implementing any
\r
63 automated testing at all of the emacs interface precisely because of
\r
64 this problem. It's seems to me that surely emacs must have some built-in
\r
65 mechanism for copying the visible portion of a block of text, but I've
\r
66 not been able to find it.
\r
68 We could do something cheesy (and slow) by marching through the buffer
\r
69 character-by-character in elisp and testing for visibility, but the
\r
70 emacs tests are already the slowest part of "make test"[*] so that would
\r
73 > Note that this is exactly the patch that hits the isearch emacs bug. Do
\r
74 > I understand correctly that you are ready to push the series despite of
\r
75 > it (given that we have a test)?
\r
77 Breaking isearch would be really unfortunate. That's a really nice
\r
78 feature of the emacs frontend currently.
\r
80 So I would notice that breakage, (while I've apparently never before
\r
81 noticed the breakage of having visible citations in a hidden message).
\r
83 So no, I'm not saying I'm ready to push the series while emacs is broken.
\r
87 [*] Maybe the performance of the emacs testing could be significantly
\r
88 improved by sharing a single invocation of emacs? Perhaps this wouldn't
\r
89 even be hard by just using emacsclient?
\r
93 Content-Type: application/pgp-signature
\r
95 -----BEGIN PGP SIGNATURE-----
\r
96 Version: GnuPG v1.4.11 (GNU/Linux)
\r
98 iEYEARECAAYFAk3dhtAACgkQ6JDdNq8qSWjhZQCgg2l2/aHq3LBhQPfsGWKHHFfj
\r
99 frwAnibcwJNHfY6ddcTMbguX7mADjEHb
\r
101 -----END PGP SIGNATURE-----
\r