1 Return-Path: <tomi.ollila@iki.fi>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 2193D431FBD
\r
6 for <notmuch@notmuchmail.org>; Sun, 26 Jan 2014 03:10:00 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id 6m96vEAEJfOj for <notmuch@notmuchmail.org>;
\r
16 Sun, 26 Jan 2014 03:09:52 -0800 (PST)
\r
17 Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])
\r
18 by olra.theworths.org (Postfix) with ESMTP id A7CA8431FBC
\r
19 for <notmuch@notmuchmail.org>; Sun, 26 Jan 2014 03:09:52 -0800 (PST)
\r
20 Received: from guru.guru-group.fi (localhost [IPv6:::1])
\r
21 by guru.guru-group.fi (Postfix) with ESMTP id 0BDD5100051;
\r
22 Sun, 26 Jan 2014 13:09:46 +0200 (EET)
\r
23 From: Tomi Ollila <tomi.ollila@iki.fi>
\r
24 To: David Bremner <david@tethera.net>,
\r
25 Mark Walters <markwalters1009@gmail.com>, notmuch@notmuchmail.org
\r
26 Subject: Re: [PATCH] emacs: initialize ido mode in notmuch-mua.el
\r
27 In-Reply-To: <87y523mtd1.fsf@zancas.localnet>
\r
28 References: <87y5sipcjn.fsf@qmul.ac.uk>
\r
29 <1329900529-16295-1-git-send-email-markwalters1009@gmail.com>
\r
30 <87bnyzoqq9.fsf@zancas.localnet>
\r
31 <m2a9ejkb05.fsf@guru.guru-group.fi>
\r
32 <87y523mtd1.fsf@zancas.localnet>
\r
33 User-Agent: Notmuch/0.17+41~g8e7fabf (http://notmuchmail.org) Emacs/24.3.1
\r
34 (x86_64-unknown-linux-gnu)
\r
35 X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
\r
36 $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
\r
37 !)g;OY^,BjTbr)Np:%c_o'jj,Z
\r
38 Date: Sun, 26 Jan 2014 13:09:45 +0200
\r
39 Message-ID: <m2iot7uhhi.fsf@guru.guru-group.fi>
\r
41 Content-Type: text/plain
\r
42 X-BeenThere: notmuch@notmuchmail.org
\r
43 X-Mailman-Version: 2.1.13
\r
45 List-Id: "Use and development of the notmuch mail system."
\r
46 <notmuch.notmuchmail.org>
\r
47 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
48 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
49 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
50 List-Post: <mailto:notmuch@notmuchmail.org>
\r
51 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
52 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
53 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
54 X-List-Received-Date: Sun, 26 Jan 2014 11:10:00 -0000
\r
56 On Sun, Jan 26 2014, David Bremner <david@tethera.net> wrote:
\r
58 > Tomi Ollila <tomi.ollila@iki.fi> writes:
\r
61 >> How about doing it with defadvice with something like:
\r
63 >> (from http://comments.gmane.org/gmane.emacs.bugs/27856 one can notice
\r
64 >> this happening with emacs 23.3 -- David can check whether 23.4 if
\r
67 > It's fixed in 23.4
\r
70 >> (if (and (= emacs-major-version 23) (< emacs-minor-version 4))
\r
71 >> (defadvice ido-completing-read (before notmuch-ido-mode-init activate)
\r
72 >> (unless (ido-mode) (ido-mode t))
\r
73 >> (ad-disable-advice 'ido-completing-read 'before 'notmuch-ido-mode-init)))
\r
75 > Advice always seems over complex to me, but maybe I'm just
\r
76 > prejudiced/ignorant.
\r
78 With defadvice we can keep "mainline code less messy and less hard to
\r
79 maintain" ;) -- and only install the advice on versions that need it.
\r
81 Also with defadvice the other use of ido-completing-read is covered.
\r
83 > Can you decode/reverse-engineer the fix in
\r
85 > http://permalink.gmane.org/gmane.emacs.bugs/41957
\r
89 > Maybe the advice or whatever should call
\r
91 > (ido-init-completion-maps)
\r
92 > (add-hook 'minibuffer-setup-hook 'ido-minibuffer-setup)
\r
93 > (add-hook 'choose-completion-string-functions
\r
94 > 'ido-choose-completion-string))
\r
96 > Although that looks worryingly permanent.
\r
98 (emacs-version) -> 24.3.1
\r
100 (describe-variable 'minibuffer-setup-hook)
\r
102 -> (rfn-eshadow-setup-minibuffer minibuffer-history-isearch-setup minibuffer-history-initialize)
\r
104 (ido-completing-read "test" '("foo" "bar"))
\r
107 (describe-variable 'minibuffer-setup-hook)
\r
109 -> (ido-minibuffer-setup rfn-eshadow-setup-minibuffer minibuffer-history-isearch-setup minibuffer-history-initialize)
\r
111 SO, although permanent, consistent w/ newer emacs versions...
\r