1 Return-Path: <tomi.ollila@nixu.com>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 59B80431FD0
\r
6 for <notmuch@notmuchmail.org>; Sun, 18 Dec 2011 00:49:01 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id sTPVL-eEZ8ks for <notmuch@notmuchmail.org>;
\r
16 Sun, 18 Dec 2011 00:48:59 -0800 (PST)
\r
17 Received: from mail-gw3.nixu.fi (mail-gw3.nixu.fi [193.209.237.7])
\r
18 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
\r
19 (No client certificate requested)
\r
20 by olra.theworths.org (Postfix) with ESMTPS id AFA4C431FB6
\r
21 for <notmuch@notmuchmail.org>; Sun, 18 Dec 2011 00:48:58 -0800 (PST)
\r
22 Received: from pps.filterd (mail-gw3 [127.0.0.1])
\r
23 by mail-gw3.nixu.fi (8.14.4/8.14.4) with SMTP id pBI8mk8Z030360;
\r
24 Sun, 18 Dec 2011 10:48:46 +0200
\r
25 Received: from taco2.nixu.fi (taco2.nixu.fi [194.197.118.31])
\r
26 by mail-gw3.nixu.fi with ESMTP id 114cs0u59m-1
\r
27 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT);
\r
28 Sun, 18 Dec 2011 10:48:45 +0200
\r
29 Received: from taco2.nixu.fi (taco2.nixu.fi [194.197.118.31])
\r
30 by taco2.nixu.fi (8.14.3/8.14.3/Debian-5+lenny1) with ESMTP id
\r
31 pBI8mixf031592; Sun, 18 Dec 2011 10:48:45 +0200
\r
32 From: Tomi Ollila <tomi.ollila@iki.fi>
\r
33 To: David Bremner <david@tethera.net>, notmuch@notmuchmail.org
\r
34 Subject: Re: [PATCH] build-system: use a shell variable for TMPFILE in
\r
36 In-Reply-To: <1324178211-30739-1-git-send-email-david@tethera.net>
\r
37 References: <1324136185-4509-1-git-send-email-aaronecay@gmail.com>
\r
38 <1324178211-30739-1-git-send-email-david@tethera.net>
\r
39 User-Agent: Notmuch/0.10.2+93~g631d290 (http://notmuchmail.org) Emacs/23.3.1
\r
41 X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
\r
42 $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
\r
43 !)g;OY^,BjTbr)Np:%c_o'jj,Z
\r
44 Date: Sun, 18 Dec 2011 10:48:44 +0200
\r
45 Message-ID: <yf6ehw2jmdv.fsf@taco2.nixu.fi>
\r
47 Content-Type: text/plain; charset=us-ascii
\r
48 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:5.5.7110,
\r
49 1.0.211, 0.0.0000 definitions=2011-12-18_02:2011-12-16, 2011-12-18,
\r
50 1970-01-01 signatures=0
\r
51 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0
\r
52 ipscore=0 suspectscore=0
\r
53 phishscore=0 bulkscore=0 adultscore=0 classifier=spam adjust=0
\r
55 scancount=1 engine=6.0.2-1012030000 definitions=main-1112180007
\r
56 Cc: David Bremner <bremner@debian.org>
\r
57 X-BeenThere: notmuch@notmuchmail.org
\r
58 X-Mailman-Version: 2.1.13
\r
60 List-Id: "Use and development of the notmuch mail system."
\r
61 <notmuch.notmuchmail.org>
\r
62 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
63 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
64 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
65 List-Post: <mailto:notmuch@notmuchmail.org>
\r
66 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
67 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
68 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
69 X-List-Received-Date: Sun, 18 Dec 2011 08:49:01 -0000
\r
71 On Sat, 17 Dec 2011 23:16:51 -0400, David Bremner <david@tethera.net> wrote:
\r
72 > From: David Bremner <bremner@debian.org>
\r
74 > Aaron Ecay points out in
\r
75 > id:"1324136185-4509-1-git-send-email-aaronecay@gmail.com" that the
\r
78 > debian-snapshot: TMPFILE := $(shell mktemp)
\r
80 > Is being evaluated for every target. As best I can tell, this is
\r
81 > because make is evaluating the right hand side, even though it is not
\r
82 > doing the assignment.
\r
84 > Of course, it isn't quite as nice to edit with the line continuations,
\r
85 > but it is ideomatic make.
\r
88 I was originally suggesting to add 'set -e' and trap 'cleanup' 0
\r
89 to the code but that starts looking ever messier. In case of
\r
90 debian-snapshot: one needs to check whether output is procuded
\r
91 as it should be; building this goal will always exit with
\r
92 zero value (provided that last echo ... succeeds).
\r
94 Ok, provided that the above is OK with this particular target.
\r
96 (please push fast, I'm tired with all the /tmp/tmp.XXXXXX files
\r
97 I've got to clean up so far >;)
\r
101 > Makefile.local | 15 ++++++++-------
\r
102 > 1 files changed, 8 insertions(+), 7 deletions(-)
\r
104 > diff --git a/Makefile.local b/Makefile.local
\r
105 > index 5108a0c..97f397f 100644
\r
106 > --- a/Makefile.local
\r
107 > +++ b/Makefile.local
\r
108 > @@ -139,15 +139,16 @@ pre-release:
\r
109 > mv $(TAR_FILE) $(DEB_TAR_FILE) releases
\r
111 > .PHONY: debian-snapshot
\r
112 > -debian-snapshot: TMPFILE := $(shell mktemp)
\r
114 > make VERSION=$(VERSION) clean
\r
115 > - cp debian/changelog $(TMPFILE)
\r
116 > - EDITOR=/bin/true dch -b -v $(VERSION)+1 -D UNRELEASED 'test build, not for upload'
\r
117 > - echo '3.0 (native)' > debian/source/format
\r
118 > - debuild -us -uc
\r
119 > - mv -f $(TMPFILE) debian/changelog
\r
120 > - echo '3.0 (quilt)' > debian/source/format
\r
121 > + TMPFILE=$$(mktemp /tmp/notmuch.XXXXXX); \
\r
122 > + cp debian/changelog $${TMPFILE}; \
\r
123 > + EDITOR=/bin/true dch -b -v $(VERSION)+1 \
\r
124 > + -D UNRELEASED 'test build, not for upload'; \
\r
125 > + echo '3.0 (native)' > debian/source/format; \
\r
126 > + debuild -us -uc; \
\r
127 > + mv -f $${TMPFILE} debian/changelog; \
\r
128 > + echo '3.0 (quilt)' > debian/source/format
\r
130 > .PHONY: release-message
\r
projects / notmuch-archives.git / blob