49/213549df744dbc2ba3562d50fc07c1a48ecdc7

   1 Return-Path: <amdragon@mit.edu>\r
   2 X-Original-To: notmuch@notmuchmail.org\r
   3 Delivered-To: notmuch@notmuchmail.org\r
   4 Received: from localhost (localhost [127.0.0.1])\r
   5         by olra.theworths.org (Postfix) with ESMTP id 983F5431FAF\r
   6         for <notmuch@notmuchmail.org>; Thu, 12 Apr 2012 14:04:18 -0700 (PDT)\r
   7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
   8 X-Spam-Flag: NO\r
   9 X-Spam-Score: -0.7\r
  10 X-Spam-Level: \r
  11 X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
  12         tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
  13 Received: from olra.theworths.org ([127.0.0.1])\r
  14         by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
  15         with ESMTP id I0E2kUoGO3VT for <notmuch@notmuchmail.org>;\r
  16         Thu, 12 Apr 2012 14:04:18 -0700 (PDT)\r
  17 Received: from dmz-mailsec-scanner-5.mit.edu (DMZ-MAILSEC-SCANNER-5.MIT.EDU\r
  18         [18.7.68.34])\r
  19         by olra.theworths.org (Postfix) with ESMTP id EFB0D431FAE\r
  20         for <notmuch@notmuchmail.org>; Thu, 12 Apr 2012 14:04:17 -0700 (PDT)\r
  21 X-AuditID: 12074422-b7fd66d0000008f9-6a-4f874351da85\r
  22 Received: from mailhub-auth-2.mit.edu ( [18.7.62.36])\r
  23         by dmz-mailsec-scanner-5.mit.edu (Symantec Messaging Gateway) with SMTP\r
  24         id 86.B7.02297.153478F4; Thu, 12 Apr 2012 17:04:17 -0400 (EDT)\r
  25 Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103])\r
  26         by mailhub-auth-2.mit.edu (8.13.8/8.9.2) with ESMTP id q3CL4G16031950; \r
  27         Thu, 12 Apr 2012 17:04:16 -0400\r
  28 Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91])\r
  29         (authenticated bits=0)\r
  30         (User authenticated as amdragon@ATHENA.MIT.EDU)\r
  31         by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id q3CL4ERX029107\r
  32         (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT);\r
  33         Thu, 12 Apr 2012 17:04:15 -0400 (EDT)\r
  34 Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.77)\r
  35         (envelope-from <amdragon@mit.edu>)\r
  36         id 1SIRBe-0004qI-OO; Thu, 12 Apr 2012 17:04:14 -0400\r
  37 Date: Thu, 12 Apr 2012 17:04:14 -0400\r
  38 From: Austin Clements <amdragon@MIT.EDU>\r
  39 To: Jani Nikula <jani@nikula.org>\r
  40 Subject: Re: [PATCH] lib: work around talloc_steal usage from C++ code\r
  41 Message-ID: <20120412210414.GI13549@mit.edu>\r
  42 References: <1334264259-17632-1-git-send-email-jani@nikula.org>\r
  43 MIME-Version: 1.0\r
  44 Content-Type: text/plain; charset=us-ascii\r
  45 Content-Disposition: inline\r
  46 In-Reply-To: <1334264259-17632-1-git-send-email-jani@nikula.org>\r
  47 User-Agent: Mutt/1.5.21 (2010-09-15)\r
  48 X-Brightmail-Tracker:\r
  49  H4sIAAAAAAAAA+NgFupkleLIzCtJLcpLzFFi42IRYrdT0Q10bvc3+NAqZdE03dni+s2ZzBYd\r
  50         t3ezOTB73Lr/mt3j2apbzB4fn95iCWCO4rJJSc3JLEst0rdL4MqY0TOLsWAaa0XXrkPsDYwT\r
  51         WboYOTkkBEwkDiz+zQxhi0lcuLeerYuRi0NIYB+jxKbuN+wgCSGBDYwSC5+bQ9gnmSQmz1SF\r
  52         sJcwSmycwQhiswioShz98Q2snk1AQ2Lb/uVgcREBRYnNJ/cD2RwczALuEieXGYGEhQXcJPqP\r
  53         HwC7gVdAR+L8vTnMECPtJSb+XskEEReUODnzCVgNs4CWxI1/L5kgxkhLLP/HARLmFHCQOH4c\r
  54         YpOogIrElJPb2CYwCs1C0j0LSfcshO4FjMyrGGVTcqt0cxMzc4pTk3WLkxPz8lKLdE31cjNL\r
  55         9FJTSjcxgkPcRWkH48+DSocYBTgYlXh4Xz5r8xdiTSwrrsw9xCjJwaQkymvg1O4vxJeUn1KZ\r
  56         kVicEV9UmpNafIhRgoNZSYT3z2Ogct6UxMqq1KJ8mJQ0B4uSOK+61js/IYH0xJLU7NTUgtQi\r
  57         mKwMB4eSBO9qkKGCRanpqRVpmTklCGkmDk6Q4TxAw0+C1PAWFyTmFmemQ+RPMSpKifOeBkkI\r
  58         gCQySvPgemEp6BWjONArwryzQKp4gOkLrvsV0GAmoMF8CiBXF5ckIqSkGhgZCq9G+24+3355\r
  59         945US00hG9FLDmuyZJhK8rOTV8wRTBVMYMvZGMcbG5zNn/y+ch//530ffcRNRSaJ6O0xbdyS\r
  60         /SRD7RlDrTP3/QzG/rzEpYkpe5zkNy6c/ETx8YXHob862HawNBUlPPNmSAj9Wc+XdPGmWekd\r
  61         4X6vAFGeU3+3XLrE33RaTYmlOCPRUIu5qDgRABUpF3scAwAA\r
  62 Cc: notmuch@notmuchmail.org\r
  63 X-BeenThere: notmuch@notmuchmail.org\r
  64 X-Mailman-Version: 2.1.13\r
  65 Precedence: list\r
  66 List-Id: "Use and development of the notmuch mail system."\r
  67         <notmuch.notmuchmail.org>\r
  68 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
  69         <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
  70 List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
  71 List-Post: <mailto:notmuch@notmuchmail.org>\r
  72 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
  73 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
  74         <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
  75 X-List-Received-Date: Thu, 12 Apr 2012 21:04:18 -0000\r
  76 \r
  77 Quoth Jani Nikula on Apr 12 at 11:57 pm:\r
  78 > Implicit typecast from 'void *' to 'T *' is okay in C, but not in\r
  79 > C++. In talloc_steal, an explicit cast is provided for type safety in\r
  80 > some GCC versions. Otherwise, a cast is required. Provide a template\r
  81 > function for this to maintain type safety, and redefine talloc_steal\r
  82 > to use it.\r
  83 > \r
  84 > The template must be outside the extern "C" block (NOTMUCH_BEGIN_DECLS\r
  85 > and NOTMUCH_END_DECLS), but keep it within the GCC visibility #pragma.\r
  86 > \r
  87 > No functional changes, apart from making the library build with\r
  88 > compilers other than recent GCC.\r
  89 > \r
  90 > Signed-off-by: Jani Nikula <jani@nikula.org>\r
  91 \r
  92 LGTM.\r